Mbed-TLS/mbedtls-framework
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls-framework.git synced 2026-10-12 03:37:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

check_names: use set, not list, when only testing membership

Browse Source 
It's both clearer and faster.

No semantic change.

Signed-off-by: Gilles Peskine <[email protected]>
This commit is contained in:
Gilles Peskine
2026-01-15 18:09:14 +01:00
parent 2f01eca203
commit 21007fc2bc
1 changed files with 11 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/check_names.py
+11 -18
View File
@@ -281,7 +281,7 @@ class CodeParser():
) )
# Remove identifier macros like mbedtls_printf or mbedtls_calloc # Remove identifier macros like mbedtls_printf or mbedtls_calloc
identifiers_justname = [x.name for x in identifiers] identifiers_justname = frozenset(x.name for x in identifiers)
actual_macros = {"public": [], "internal": []} #type: Dict[str, List[Match]] actual_macros = {"public": [], "internal": []} #type: Dict[str, List[Match]]
for scope in actual_macros: for scope in actual_macros:
for macro in all_macros[scope]: for macro in all_macros[scope]:
@@ -1123,17 +1123,13 @@ class NameChecker():
Returns the number of problems that need fixing. Returns the number of problems that need fixing.
""" """
problems = [] #type: List[Problem] problems = [] #type: List[Problem]
all_identifiers = self.parse_result.identifiers + \ all_identifiers = frozenset(
self.parse_result.excluded_identifiers match.name
for match in (self.parse_result.identifiers +
self.parse_result.excluded_identifiers))
for symbol in self.parse_result.symbols: for symbol in self.parse_result.symbols:
found_symbol_declared = False if symbol not in all_identifiers:
for identifier_match in all_identifiers:
if symbol == identifier_match.name:
found_symbol_declared = True
break
if not found_symbol_declared:
problems.append(SymbolNotInHeader(symbol)) problems.append(SymbolNotInHeader(symbol))
self.output_check_result("All symbols in header", problems) self.output_check_result("All symbols in header", problems)
@@ -1176,15 +1172,12 @@ class NameChecker():
""" """
problems = [] #type: List[Problem] problems = [] #type: List[Problem]
# Set comprehension, equivalent to a list comprehension wrapped by set() all_caps_names = frozenset(
all_caps_names = {
match.name match.name
for match for match in (self.parse_result.public_macros +
in self.parse_result.public_macros + self.parse_result.internal_macros +
self.parse_result.internal_macros + self.parse_result.private_macros +
self.parse_result.private_macros + self.parse_result.enum_consts))
self.parse_result.enum_consts
}
typo_exclusion = re.compile(r"XXX|__|_$|^MBEDTLS_.*CONFIG_FILE$|" typo_exclusion = re.compile(r"XXX|__|_$|^MBEDTLS_.*CONFIG_FILE$|"
r"MBEDTLS_TEST_LIBTESTDRIVER*|" r"MBEDTLS_TEST_LIBTESTDRIVER*|"
r"PSA_CRYPTO_DRIVER_TEST") r"PSA_CRYPTO_DRIVER_TEST")