From fbfd68087ea743c6eb37ddc9daaa1b6aa64b660c Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Thu, 10 Oct 2024 18:46:51 +0200 Subject: [PATCH 1/4] Add pull request template Signed-off-by: Gilles Peskine --- .github/pull_request_template.md | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..359e8ea41 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,29 @@ +## Description + +Please write a few sentences describing the overall goals of the pull request's commits. + + + +## PR checklist + +Please add the numbers of the associated pull requests for consuming branches +(a link is fine). For the time being, even if a change is only needed in one +branch, a pull request is needed in all branches so that the CI can validate +the change as non-harmful. + +- [ ] **development PR** Mbed-TLS/mbedtls# +- [ ] **3.6 PR** Mbed-TLS/mbedtls# + + + +## Notes for the submitter + +Please refer to the [contributing guidelines](https://github.com/Mbed-TLS/mbedtls/blob/development/CONTRIBUTING.md), especially the +checklist for PR contributors. + +Help make review efficient: +* Multiple simple commits + - please structure your PR into a series of small commits, each of which does one thing +* Avoid force-push + - please do not force-push to update your PR - just add new commit(s) +* See our [Guidelines for Contributors](https://mbed-tls.readthedocs.io/en/latest/reviews/review-for-contributors/) for more details about the review process. From 8acd99d6f2a67998f291d3b785399b618f03c6a0 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Mon, 25 Nov 2024 11:51:56 +0100 Subject: [PATCH 2/4] We now have a CI in mbedtls-framework Signed-off-by: Gilles Peskine --- .github/pull_request_template.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 359e8ea41..cde5cce6d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,11 +6,8 @@ Please write a few sentences describing the overall goals of the pull request's ## PR checklist -Please add the numbers of the associated pull requests for consuming branches -(a link is fine). For the time being, even if a change is only needed in one -branch, a pull request is needed in all branches so that the CI can validate -the change as non-harmful. - +Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed. +. - [ ] **development PR** Mbed-TLS/mbedtls# - [ ] **3.6 PR** Mbed-TLS/mbedtls# From dc52dad8b00f2291cacc948d37effd609b6a6f1e Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Mon, 25 Nov 2024 16:39:15 +0100 Subject: [PATCH 3/4] Remove stray dot Signed-off-by: Gilles Peskine --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index cde5cce6d..907f563d7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,7 +7,7 @@ Please write a few sentences describing the overall goals of the pull request's ## PR checklist Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed. -. + - [ ] **development PR** Mbed-TLS/mbedtls# - [ ] **3.6 PR** Mbed-TLS/mbedtls# From 7a310616325b4ac8f37e9a26a4b28ae640ca1dfb Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Tue, 17 Dec 2024 12:18:07 +0100 Subject: [PATCH 4/4] Add a line for a crypto PR Signed-off-by: Gilles Peskine --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 907f563d7..8e83e1a23 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,6 +8,7 @@ Please write a few sentences describing the overall goals of the pull request's Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed. +- [ ] **crypto PR** Mbed-TLS/TF-PSA-Crypto# - [ ] **development PR** Mbed-TLS/mbedtls# - [ ] **3.6 PR** Mbed-TLS/mbedtls#