From 50b681b94fb84e1e010d7d3f53936853dc73c578 Mon Sep 17 00:00:00 2001 From: Akshay Iyyadurai Balasundaram Date: Thu, 13 Feb 2020 11:21:52 +0100 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bc21130..bb2c52b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -111,8 +111,8 @@ These are some of the rules we try to follow: - Apply a clean coding style adapted to the surrounding code, even though we are aware the existing code is not fully clean - Use (4)spaces for indentation (except if the modified file consistently uses tabs) - Use variable naming conventions like in the other files you are seeing (camelcase) -- No console.log() - use logging service -- Run the ESLint code check and make it succeed +- No console.log() - instead use GitHub Action Native logging service (For example `core.info("Hello World")`) +- Run the TSLint code check and make it succeed - Comment your code where it gets non-trivial - Keep an eye on performance and memory consumption, properly destroy objects when not used anymore - Write a unit test