espressif/esp-lwip
1
0
Fork 0
mirror of https://github.com/espressif/esp-lwip.git synced 2026-09-05 00:30:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

ND6: reply NS without LL opt

Browse Source 
* This issue should be fixed for the upstream
* Reference to the RFC-4861#section-4.3 source Link-Layer address
  SHOULD be included in unicast solicitations. But there might be
  some NS messages which do not contain source link-layer address option.
* NA will be replied to those NS messages which do not contain
  source link layer option.
This commit is contained in:
zwx
2024-08-27 17:39:04 +08:00
parent f1c0a3d820
commit 6bc36ec020
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/ipv6/nd6.c
+10 -1
View File
@@ -505,7 +505,16 @@ nd6_input(struct pbuf *p, struct netif *inp)
/* Sender is trying to resolve our address. */ /* Sender is trying to resolve our address. */
/* Verify that they included their own link-layer address. */ /* Verify that they included their own link-layer address. */
if (lladdr_opt == NULL) { if (lladdr_opt == NULL) {
/* Not a valid message. */ /* Per RFC4861#section-4.3, source Link-Layer address SHOULD be included in unicast solicitations.
* But, there might be some NSs which do not contain source link-layer address option.
* For LwIP implement, this kind of NS will be ignored. This issue should be fixed.
* Although this Neighbor Solicitation (NS) will be ignored in the subsequent process,
* a Neighbor Advertisement (NA) is still sent in response. */
#if ESP_LWIP && LWIP_FORCE_ROUTER_FORWARDING
nd6_send_na(inp, &target_address, ND6_FLAG_ROUTER | ND6_FLAG_SOLICITED | ND6_FLAG_OVERRIDE);
#else
nd6_send_na(inp, &target_address, ND6_FLAG_SOLICITED | ND6_FLAG_OVERRIDE);
#endif
pbuf_free(p); pbuf_free(p);
ND6_STATS_INC(nd6.proterr); ND6_STATS_INC(nd6.proterr);
ND6_STATS_INC(nd6.drop); ND6_STATS_INC(nd6.drop);
src/include/lwip/opt.h
+1 -1
View File
@@ -2424,7 +2424,7 @@
#endif #endif
/** /**
* when LWIP_FORCE_ROUTER_FORWARDING is enbaled in lwip, the router flag in NA packet will always * when LWIP_FORCE_ROUTER_FORWARDING is enabled in lwip, the router flag in NA packet will always
* set to 1, otherwise, never set router flag for NA packets. * set to 1, otherwise, never set router flag for NA packets.
*/ */
#if !defined LWIP_FORCE_ROUTER_FORWARDING || defined __DOXYGEN__ #if !defined LWIP_FORCE_ROUTER_FORWARDING || defined __DOXYGEN__