From 03df51a35cf85a53fe921b595f73943cafb67f79 Mon Sep 17 00:00:00 2001 From: Prasad Alatkar Date: Tue, 14 Jul 2020 12:07:10 +0530 Subject: [PATCH] nimble/porting: Explicitly NULL terminate potential non NULL terminated string buffer os_mempool.c: Using strncpy, buffer will not be NULL terminated if size of source string is same as buffer size. Explicitly added NULL character at the end. --- porting/nimble/src/os_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/porting/nimble/src/os_mempool.c b/porting/nimble/src/os_mempool.c index 74c534e25..79630baea 100644 --- a/porting/nimble/src/os_mempool.c +++ b/porting/nimble/src/os_mempool.c @@ -473,8 +473,8 @@ os_mempool_info_get_next(struct os_mempool *mp, struct os_mempool_info *omi) omi->omi_num_blocks = cur->mp_num_blocks; omi->omi_num_free = cur->mp_num_free; omi->omi_min_free = cur->mp_min_free; - omi->omi_name[0] = '\0'; - strncat(omi->omi_name, cur->name, sizeof(omi->omi_name) - 1); + strncpy(omi->omi_name, cur->name, sizeof(omi->omi_name) - 1); + omi->omi_name[sizeof(omi->omi_name) - 1] = '\0'; return (cur); }