From 7e4f538a23591dfd361b90415eb517c6fc901a40 Mon Sep 17 00:00:00 2001 From: Rahul Tank Date: Tue, 12 Mar 2024 16:48:41 +0530 Subject: [PATCH] fix(nimble): Add coverity failure fixes --- nimble/host/src/ble_att_svr.c | 4 ++-- nimble/host/src/ble_sm.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/nimble/host/src/ble_att_svr.c b/nimble/host/src/ble_att_svr.c index f15b4b0b2..1dca00f59 100644 --- a/nimble/host/src/ble_att_svr.c +++ b/nimble/host/src/ble_att_svr.c @@ -2456,10 +2456,10 @@ ble_att_svr_rx_signed_write(uint16_t conn_handle, struct os_mbuf **rxom) goto err; } - if(message != NULL) nimble_platform_mem_free(message); + nimble_platform_mem_free(message); return 0; err: - if(message != NULL) nimble_platform_mem_free(message); + nimble_platform_mem_free(message); return rc; } diff --git a/nimble/host/src/ble_sm.c b/nimble/host/src/ble_sm.c index 6ec34f5c9..40acbc25a 100644 --- a/nimble/host/src/ble_sm.c +++ b/nimble/host/src/ble_sm.c @@ -974,7 +974,7 @@ ble_sm_process_result(uint16_t conn_handle, struct ble_sm_result *res, &prev); if (proc != NULL) { - if (res->execute) { + if (res && res->execute) { ble_sm_exec(proc, res, res->state_arg); } @@ -993,7 +993,7 @@ ble_sm_process_result(uint16_t conn_handle, struct ble_sm_result *res, } } - if (res->sm_err != 0 && tx_fail) { + if (res && (res->sm_err != 0) && tx_fail) { ble_sm_pair_fail_tx(conn_handle, res->sm_err); }