From fe1d908760e4b1731a4da3d9e97a59c61abb822b Mon Sep 17 00:00:00 2001 From: Prasad Alatkar Date: Tue, 14 Jul 2020 12:07:10 +0530 Subject: [PATCH] nimble/porting: Explicitly NULL terminate potential non NULL terminated string buffer os_mempool.c: Using strncpy, buffer will not be NULL terminated if size of source string is same as buffer size. Explicitly added NULL character at the end. --- porting/nimble/src/os_mempool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/porting/nimble/src/os_mempool.c b/porting/nimble/src/os_mempool.c index f4c712ff1..ba837e7d6 100644 --- a/porting/nimble/src/os_mempool.c +++ b/porting/nimble/src/os_mempool.c @@ -346,7 +346,8 @@ os_mempool_info_get_next(struct os_mempool *mp, struct os_mempool_info *omi) omi->omi_num_blocks = cur->mp_num_blocks; omi->omi_num_free = cur->mp_num_free; omi->omi_min_free = cur->mp_min_free; - strncpy(omi->omi_name, cur->name, sizeof(omi->omi_name)); + strncpy(omi->omi_name, cur->name, sizeof(omi->omi_name) - 1); + omi->omi_name[sizeof(omi->omi_name) - 1] = '\0'; return (cur); }