From 62de767b275a4a82980be1c9a7818ef99f03959e Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Thu, 21 Apr 2022 11:05:16 +0200 Subject: [PATCH] test_psa_crypto_config_accel_ecdsa: disable obsolete hashes MD2 and MD4 were declared as enabled (PSA_WANT_ALG_MD{2,4} defined) but not actually implemented in the test driver (MBEDTLS_MD{2,4}_C) not defined. Fix this inconsistency caued deterministic ECDSA tests using those hashes to fail. Now MD2 and MD4 are consistently off and the offending test cases don't run. Signed-off-by: Gilles Peskine --- tests/scripts/all.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh index a517f2bf18..eb6165af3c 100755 --- a/tests/scripts/all.sh +++ b/tests/scripts/all.sh @@ -1609,6 +1609,10 @@ component_test_psa_crypto_config_accel_ecdsa () { # partial support for cipher operations in the driver test library. scripts/config.py -f include/psa/crypto_config.h unset PSA_WANT_ALG_STREAM_CIPHER scripts/config.py -f include/psa/crypto_config.h unset PSA_WANT_ALG_ECB_NO_PADDING + # Disable obsolete hashes (alternatively we could enable support for them + # in the driver test library). + scripts/config.py -f include/psa/crypto_config.h unset PSA_WANT_ALG_MD2 + scripts/config.py -f include/psa/crypto_config.h unset PSA_WANT_ALG_MD4 # SHA384 needed for some ECDSA signature tests. scripts/config.py -f tests/include/test/drivers/config_test_driver.h set MBEDTLS_SHA512_C