From 02e73a058606bbbd33edf3468d6a3327249a4042 Mon Sep 17 00:00:00 2001
From: Li Cao <irvingcl@google.com>
Date: Tue, 15 Jul 2025 01:30:45 +0800
Subject: [PATCH] [format] enable simplify demorgan option (#11715)

---
 .clang-tidy                        |  3 ---
 src/core/common/debug.hpp          | 10 ++++++++--
 src/core/net/srp_server.cpp        |  2 +-
 src/core/utils/channel_manager.cpp |  2 +-
 src/lib/platform/exit_code.h       |  5 ++++-
 tests/unit/test_util.h             |  5 ++++-
 6 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index bf6dfdce6..224827af6 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -20,8 +20,5 @@ Checks: >
   readability-redundant-member-init,
   readability-simplify-boolean-expr,
   readability-static-accessed-through-instance
-CheckOptions:
-  - key: readability-simplify-boolean-expr.SimplifyDeMorgan
-    value: false
 WarningsAsErrors: '*'
 HeaderFilterRegex: '(examples|include|src).*(?<!third_party.*repo)'
diff --git a/src/core/common/debug.hpp b/src/core/common/debug.hpp
index 9e38eb735..de159559f 100644
--- a/src/core/common/debug.hpp
+++ b/src/core/common/debug.hpp
@@ -55,7 +55,10 @@
 #define OT_ASSERT(cond)                            \
     do                                             \
     {                                              \
-        if (!(cond))                               \
+        if (cond)                                  \
+        {                                          \
+        }                                          \
+        else                                       \
         {                                          \
             otPlatAssertFail(FILE_NAME, __LINE__); \
             while (1)                              \
@@ -75,7 +78,10 @@
 #define OT_ASSERT(cond) \
     do                  \
     {                   \
-        if (!(cond))    \
+        if (cond)       \
+        {               \
+        }               \
+        else            \
         {               \
             while (1)   \
             {           \
diff --git a/src/core/net/srp_server.cpp b/src/core/net/srp_server.cpp
index 87f8e9688..38a055eb0 100644
--- a/src/core/net/srp_server.cpp
+++ b/src/core/net/srp_server.cpp
@@ -721,7 +721,7 @@ void Server::CommitSrpUpdate(Error                    aError,
 exit:
     if (aMessageInfo != nullptr)
     {
-        if (aError == kErrorNone && !(grantedLease == hostLease && grantedKeyLease == hostKeyLease))
+        if (aError == kErrorNone && (grantedLease != hostLease || grantedKeyLease != hostKeyLease))
         {
             SendResponse(aDnsHeader, grantedLease, grantedKeyLease, useShortLease, *aMessageInfo);
         }
diff --git a/src/core/utils/channel_manager.cpp b/src/core/utils/channel_manager.cpp
index 823b1c175..8a7957507 100644
--- a/src/core/utils/channel_manager.cpp
+++ b/src/core/utils/channel_manager.cpp
@@ -112,7 +112,7 @@ exit:
 #if OPENTHREAD_CONFIG_CHANNEL_MANAGER_CSL_CHANNEL_SELECT_ENABLE
 void ChannelManager::ChangeCslChannel(uint8_t aChannel)
 {
-    if (!(!Get<Mle::Mle>().IsRxOnWhenIdle() && Get<Mac::Mac>().IsCslEnabled()))
+    if (Get<Mle::Mle>().IsRxOnWhenIdle() || !Get<Mac::Mac>().IsCslEnabled())
     {
         // cannot select or use other channel
         ExitNow();
diff --git a/src/lib/platform/exit_code.h b/src/lib/platform/exit_code.h
index 720fcb73f..7a255981e 100644
--- a/src/lib/platform/exit_code.h
+++ b/src/lib/platform/exit_code.h
@@ -113,7 +113,10 @@ const char *otExitCodeToString(uint8_t aExitCode);
 #define VerifyOrDie(aCondition, aExitCode)                                                         \
     do                                                                                             \
     {                                                                                              \
-        if (!(aCondition))                                                                         \
+        if (aCondition)                                                                            \
+        {                                                                                          \
+        }                                                                                          \
+        else                                                                                       \
         {                                                                                          \
             const char *start = strrchr(__FILE__, '/');                                            \
             OT_UNUSED_VARIABLE(start);                                                             \
diff --git a/tests/unit/test_util.h b/tests/unit/test_util.h
index ace804298..332f9dfeb 100644
--- a/tests/unit/test_util.h
+++ b/tests/unit/test_util.h
@@ -66,7 +66,10 @@ extern "C" {
 #define VerifyOrQuit(...)                                                                                       \
     do                                                                                                          \
     {                                                                                                           \
-        if (!(OT_FIRST_ARG(__VA_ARGS__)))                                                                       \
+        if ((OT_FIRST_ARG(__VA_ARGS__)))                                                                        \
+        {                                                                                                       \
+        }                                                                                                       \
+        else                                                                                                    \
         {                                                                                                       \
             fprintf(stderr, "\nFAILED %s:%d - VerifyOrQuit(%s) " OT_SECOND_ARG(__VA_ARGS__) "\n", __FUNCTION__, \
                     __LINE__, _Stringize(OT_FIRST_ARG(__VA_ARGS__)));                                           \