From 099dfa27316e4f148488ba1e7359ee2cc0680870 Mon Sep 17 00:00:00 2001 From: kangping Date: Sat, 6 Feb 2021 02:11:07 +0800 Subject: [PATCH] [tests] fix test_srp_name_confclicts.py (#6143) The SRP service may be in different intermediate states when rejected by the server and we only need to make sure that the state is not Registered. --- tests/scripts/thread-cert/test_srp_name_conflicts.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/scripts/thread-cert/test_srp_name_conflicts.py b/tests/scripts/thread-cert/test_srp_name_conflicts.py index 3a54919ac..1e2851891 100755 --- a/tests/scripts/thread-cert/test_srp_name_conflicts.py +++ b/tests/scripts/thread-cert/test_srp_name_conflicts.py @@ -151,8 +151,8 @@ class SrpNameConflicts(thread_cert.TestCase): # It is expected that the registration will be rejected. client_2_service = client_2.srp_client_get_services()[0] - self.assertEqual(client_2_service['state'], 'Adding') - self.assertEqual(client_2.srp_client_get_host_state(), 'ToAdd') + self.assertNotEqual(client_2_service['state'], 'Registered') + self.assertNotEqual(client_2.srp_client_get_host_state(), 'Registered') self.assertEqual(len(server.srp_server_get_services()), 1) self.assertEqual(len(server.srp_server_get_hosts()), 1) @@ -172,8 +172,8 @@ class SrpNameConflicts(thread_cert.TestCase): # It is expected that the registration will be rejected. client_2_service = client_2.srp_client_get_services()[0] - self.assertEqual(client_2_service['state'], 'Adding') - self.assertEqual(client_2.srp_client_get_host_state(), 'ToAdd') + self.assertNotEqual(client_2_service['state'], 'Registered') + self.assertNotEqual(client_2.srp_client_get_host_state(), 'Registered') self.assertEqual(len(server.srp_server_get_services()), 1) self.assertEqual(len(server.srp_server_get_hosts()), 1) @@ -225,8 +225,8 @@ class SrpNameConflicts(thread_cert.TestCase): # It is expected that the registration will be rejected. client_2_service = client_2.srp_client_get_services()[0] - self.assertEqual(client_2_service['state'], 'Adding') - self.assertEqual(client_2.srp_client_get_host_state(), 'ToAdd') + self.assertNotEqual(client_2_service['state'], 'Registered') + self.assertNotEqual(client_2.srp_client_get_host_state(), 'Registered') # The service 'my-service-1' is removed but its name is retained. # This is why we can see the service record on the SRP server.