From 0c6c2fedadf6516282f4430da89d2b99d551934a Mon Sep 17 00:00:00 2001
From: Abtin Keshavarzian <abtink@google.com>
Date: Tue, 30 Apr 2024 08:56:07 -0700
Subject: [PATCH] [dataset] define `MgmtSetCallback` type (#10120)

---
 src/core/meshcop/dataset_manager.cpp | 10 +++++-----
 src/core/meshcop/dataset_manager.hpp | 18 ++++++++++++------
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/src/core/meshcop/dataset_manager.cpp b/src/core/meshcop/dataset_manager.cpp
index a7b0b69bd..b45bf8fc1 100644
--- a/src/core/meshcop/dataset_manager.cpp
+++ b/src/core/meshcop/dataset_manager.cpp
@@ -420,11 +420,11 @@ exit:
     return error;
 }
 
-Error DatasetManager::SendSetRequest(const Dataset::Info     &aDatasetInfo,
-                                     const uint8_t           *aTlvs,
-                                     uint8_t                  aLength,
-                                     otDatasetMgmtSetCallback aCallback,
-                                     void                    *aContext)
+Error DatasetManager::SendSetRequest(const Dataset::Info &aDatasetInfo,
+                                     const uint8_t       *aTlvs,
+                                     uint8_t              aLength,
+                                     MgmtSetCallback      aCallback,
+                                     void                *aContext)
 {
     Error            error   = kErrorNone;
     Coap::Message   *message = nullptr;
diff --git a/src/core/meshcop/dataset_manager.hpp b/src/core/meshcop/dataset_manager.hpp
index 5972397bf..fa21d5cc2 100644
--- a/src/core/meshcop/dataset_manager.hpp
+++ b/src/core/meshcop/dataset_manager.hpp
@@ -54,6 +54,12 @@ namespace MeshCoP {
 class DatasetManager : public InstanceLocator
 {
 public:
+    /**
+     * Callback function pointer, invoked when a response to a MGMT_SET request is received or times out.
+     *
+     */
+    typedef otDatasetMgmtSetCallback MgmtSetCallback;
+
     /**
      * Returns a pointer to the Timestamp.
      *
@@ -146,11 +152,11 @@ public:
      * @retval kErrorBusy    A previous request is ongoing.
      *
      */
-    Error SendSetRequest(const Dataset::Info     &aDatasetInfo,
-                         const uint8_t           *aTlvs,
-                         uint8_t                  aLength,
-                         otDatasetMgmtSetCallback aCallback,
-                         void                    *aContext);
+    Error SendSetRequest(const Dataset::Info &aDatasetInfo,
+                         const uint8_t       *aTlvs,
+                         uint8_t              aLength,
+                         MgmtSetCallback      aCallback,
+                         void                *aContext);
 
     /**
      * Sends a MGMT_GET request.
@@ -368,7 +374,7 @@ private:
     bool       mMgmtPending : 1;
     TimerMilli mTimer;
 
-    Callback<otDatasetMgmtSetCallback> mMgmtSetCallback;
+    Callback<MgmtSetCallback> mMgmtSetCallback;
 };
 
 class ActiveDatasetManager : public DatasetManager, private NonCopyable