espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-04 00:00:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[netif] change UnsubscribeAllNodesMulticast() to return void (#4942)

Browse Source
This commit is contained in:
Jonathan Hui
2020-05-11 14:07:25 -07:00
parent 8ff86bba70
commit 19ecc83acc
4 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_netif.cpp
+6 -6
View File
@@ -51,8 +51,8 @@ public:
// Provide `protected` methods in `Netif` as `public` from `TestNetif`
// so that we can verify their behavior in this test
void SubscribeAllNodesMulticast(void) { Ip6::Netif::SubscribeAllNodesMulticast(); }
otError UnsubscribeAllNodesMulticast(void) { return Ip6::Netif::UnsubscribeAllNodesMulticast(); }
void SubscribeAllNodesMulticast(void) { Ip6::Netif::SubscribeAllNodesMulticast(); }
void UnsubscribeAllNodesMulticast(void) { Ip6::Netif::UnsubscribeAllNodesMulticast(); }
};
// This function verifies the multicast addresses on Netif matches the list of given addresses.
@@ -141,11 +141,11 @@ void TestNetifMulticastAddresses(void)
netif.SubscribeMulticast(netifAddress);
VerifyMulticastAddressList(netif, &addresses[2], 4);
SuccessOrQuit(netif.UnsubscribeAllNodesMulticast(), "UnsubscribeAllNodesMulticast() failed");
netif.UnsubscribeAllNodesMulticast();
VerifyMulticastAddressList(netif, &addresses[5], 1);
VerifyOrQuit(netif.UnsubscribeAllNodesMulticast() == OT_ERROR_NOT_FOUND,
"UnsubscribeAllNodesMulticast() did not fail when not subscribed");
netif.UnsubscribeAllNodesMulticast();
VerifyMulticastAddressList(netif, &addresses[5], 1);
IgnoreError(address.FromString(kTestAddress2));
SuccessOrQuit(netif.SubscribeExternalMulticast(address), "SubscribeExternalMulticast() failed");
@@ -190,7 +190,7 @@ void TestNetifMulticastAddresses(void)
netif.UnsubscribeMulticast(netifAddress);
VerifyMulticastAddressList(netif, &addresses[2], 3);
SuccessOrQuit(netif.UnsubscribeAllNodesMulticast(), "UnsubscribeAllNodesMulticast() failed");
netif.UnsubscribeAllNodesMulticast();
VerifyMulticastAddressList(netif, NULL, 0);
// The first five elements in `addresses[]` are the default/fixed addresses: