From 1b9b73f2b781224db8055e8517617497c357cb73 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Wed, 12 Feb 2025 11:02:40 -0800 Subject: [PATCH] [routing-manager] simplify `PdPrefixManager::HasPrefix()` (#11242) This commit simplifies `PdPrefixManager::HasPrefix()` by simply checking if `mPrefix` is empty (rather than `IsValidOmrPrefix()`). A favored PD prefix is always validated before it is assigned to `mPrefix`, and when the prefix is removed, `mPrefix` is cleared. --- src/core/border_router/routing_manager.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/border_router/routing_manager.hpp b/src/core/border_router/routing_manager.hpp index c377b25d8..4a80d3c91 100644 --- a/src/core/border_router/routing_manager.hpp +++ b/src/core/border_router/routing_manager.hpp @@ -1474,7 +1474,7 @@ private: void Start(void) { StartStop(/* aStart= */ true); } void Stop(void) { StartStop(/* aStart= */ false); } bool IsRunning(void) const { return GetState() == kDhcp6PdStateRunning; } - bool HasPrefix(void) const { return IsValidOmrPrefix(mPrefix.GetPrefix()); } + bool HasPrefix(void) const { return !mPrefix.IsEmpty(); } const Ip6::Prefix &GetPrefix(void) const { return mPrefix.GetPrefix(); } State GetState(void) const;