From 1c2e7033bf45731a393ed36bbdeb0745724dc69f Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Tue, 29 Jan 2019 11:54:38 -0800 Subject: [PATCH] [cli] fix ping interval bounds check to avoid Timer::Start() assert (#3531) --- src/cli/cli.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/cli/cli.cpp b/src/cli/cli.cpp index b59bf9df3..be84cd619 100644 --- a/src/cli/cli.cpp +++ b/src/cli/cli.cpp @@ -1939,9 +1939,8 @@ void Interpreter::ProcessPing(int argc, char *argv[]) break; case 3: - mInterval = static_cast(value); - VerifyOrExit(mInterval <= Timer::kMaxDt, error = OT_ERROR_INVALID_ARGS); - mInterval = mInterval * 1000; + VerifyOrExit(value <= Timer::kMaxDt / 1000, error = OT_ERROR_INVALID_ARGS); + mInterval = static_cast(value) * 1000; break; default: