espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-07-08 13:20:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

[cli] add lower bounds check to channel selection (#3523)

Browse Source
This commit is contained in:
Jonathan Hui
2019-01-28 08:39:18 -08:00
committed by GitHub
parent 70cb48f17a
commit 251207d725
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/cli.cpp
+4 -2
View File
@@ -887,7 +887,8 @@ void Interpreter::ProcessDiscover(int argc, char *argv[])
if (argc > 0)
{
SuccessOrExit(error = ParseLong(argv[0], value));
VerifyOrExit(value <= static_cast<long>(sizeof(scanChannels) * CHAR_BIT), error = OT_ERROR_INVALID_ARGS);
VerifyOrExit((0 <= value) && (value < static_cast<long>(sizeof(scanChannels) * CHAR_BIT)),
error = OT_ERROR_INVALID_ARGS);
scanChannels = 1 << value;
}
@@ -2742,7 +2743,8 @@ void Interpreter::ProcessScan(int argc, char *argv[])
else
{
SuccessOrExit(error = ParseLong(argv[0], value));
VerifyOrExit(value < static_cast<long>(sizeof(scanChannels) * CHAR_BIT), error = OT_ERROR_INVALID_ARGS);
VerifyOrExit((0 <= value) && (value < static_cast<long>(sizeof(scanChannels) * CHAR_BIT)),
error = OT_ERROR_INVALID_ARGS);
scanChannels = 1 << value;
}
}