From 275c38a5d24f52d011a2aa967a6fbf7ec9153dc2 Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Thu, 26 Mar 2020 21:32:16 -0700 Subject: [PATCH] [meshcop] reduce maximum number types in MGMT_GET.req (#4740) --- src/core/meshcop/dataset.hpp | 1 + src/core/meshcop/dataset_manager.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/meshcop/dataset.hpp b/src/core/meshcop/dataset.hpp index e21980238..a2fc522f8 100644 --- a/src/core/meshcop/dataset.hpp +++ b/src/core/meshcop/dataset.hpp @@ -56,6 +56,7 @@ public: { kMaxSize = 256, ///< Maximum size of MeshCoP Dataset (bytes) kMaxValueSize = 16, ///< Maximum size of each Dataset TLV value (bytes) + kMaxGetTypes = 64, ///< Maximum number of types in MGMT_GET.req }; /** diff --git a/src/core/meshcop/dataset_manager.cpp b/src/core/meshcop/dataset_manager.cpp index 190c6ee80..0a3470b0e 100644 --- a/src/core/meshcop/dataset_manager.cpp +++ b/src/core/meshcop/dataset_manager.cpp @@ -299,7 +299,7 @@ void DatasetManager::HandleGet(const Coap::Message &aMessage, const Ip6::Message { Tlv tlv; uint16_t offset = aMessage.GetOffset(); - uint8_t tlvs[Dataset::kMaxSize]; + uint8_t tlvs[Dataset::kMaxGetTypes]; uint8_t length = 0; while (offset < aMessage.GetLength())