espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-07-31 08:07:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dataset] add API otDatasetTlvsCompare (#12684)

Browse Source 
Thread spec doesn't define the order of TLVs in the dataset, so that
we can't call `memcmp` to compare two dataset.  If we convert the
dataset to otOperationalDataset and then compare each value of
otOperationalDataset, we will met an issue if the new Thread spec
defines new TLVs in the dataset in the future.

This commit add a new dataset API `otDatasetTlvsCompare` to check
whether two dataset contain the exact same set of TLVs (same types and
values).
This commit is contained in:
Zhanglong Xia
2026-03-23 13:04:05 -05:00
committed by GitHub
parent 13776bc05c
commit 366a021076
6 changed files with 133 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_dataset.cpp
+59
View File
@@ -259,6 +259,65 @@ void TestDataset(void)
VerifyOrQuit(!dataset2.IsSubsetOf(dataset));
VerifyOrQuit(!dataset.IsSubsetOf(dataset2));
// Validate `Equals()`
SuccessOrQuit(dataset.SetFrom(kTlvBytes, sizeof(kTlvBytes)));
SuccessOrQuit(dataset2.SetFrom(kTlvBytes, sizeof(kTlvBytes)));
VerifyOrQuit(dataset.Equals(dataset2));
VerifyOrQuit(dataset2.Equals(dataset));
// Order of TLVs should not matter for `Equals()`
ChannelTlvValue channel;
channel.SetChannelAndPage(11);
dataset.Clear();
SuccessOrQuit(dataset.Write<PanIdTlv>(0xface));
SuccessOrQuit(dataset.Write<ChannelTlv>(channel));
dataset2.Clear();
SuccessOrQuit(dataset2.Write<ChannelTlv>(channel));
SuccessOrQuit(dataset2.Write<PanIdTlv>(0xface));
VerifyOrQuit(dataset.Equals(dataset2));
VerifyOrQuit(dataset2.Equals(dataset));
// Different TLVs
dataset.Clear();
SuccessOrQuit(dataset.Write<PanIdTlv>(0xface));
dataset2.Clear();
SuccessOrQuit(dataset2.Write<PanIdTlv>(0xface));
SuccessOrQuit(dataset2.Write<ChannelTlv>(channel));
VerifyOrQuit(!dataset.Equals(dataset2));
VerifyOrQuit(!dataset2.Equals(dataset));
// Validate `Equals()` with unknown TLVs
{
const uint8_t kUnknownTlvValue[] = {0x01, 0x02, 0x03, 0x04};
const uint8_t kUnknownTlvValue2[] = {0x01, 0x02, 0x03, 0x05};
const Tlv::Type kUnknownTlvType = static_cast<Tlv::Type>(222);
dataset.Clear();
SuccessOrQuit(dataset.Write<PanIdTlv>(0xface));
SuccessOrQuit(dataset.WriteTlv(kUnknownTlvType, kUnknownTlvValue, sizeof(kUnknownTlvValue)));
dataset2.Clear();
SuccessOrQuit(dataset2.WriteTlv(kUnknownTlvType, kUnknownTlvValue, sizeof(kUnknownTlvValue)));
SuccessOrQuit(dataset2.Write<PanIdTlv>(0xface));
VerifyOrQuit(dataset.Equals(dataset2));
VerifyOrQuit(dataset2.Equals(dataset));
// Different values for the same unknown TLV type
SuccessOrQuit(dataset2.WriteTlv(kUnknownTlvType, kUnknownTlvValue2, sizeof(kUnknownTlvValue2)));
VerifyOrQuit(!dataset.Equals(dataset2));
VerifyOrQuit(!dataset2.Equals(dataset));
}
}
} // namespace MeshCoP