From 3a46740c245e36c5a69df92ae2fb02461005bb08 Mon Sep 17 00:00:00 2001
From: Abtin Keshavarzian <abtink@google.com>
Date: Fri, 15 Dec 2017 16:21:49 -0800
Subject: [PATCH] [core] add explicit to one-argument constructors (#2422)

---
 src/core/api/link_raw.hpp                  | 2 +-
 src/core/coap/coap.hpp                     | 4 ++--
 src/core/coap/coap_secure.hpp              | 2 +-
 src/core/common/message.hpp                | 2 +-
 src/core/common/notifier.hpp               | 2 +-
 src/core/meshcop/announce_begin_client.hpp | 2 +-
 src/core/meshcop/commissioner.hpp          | 2 +-
 src/core/meshcop/dataset_manager.hpp       | 4 ++--
 src/core/meshcop/dataset_manager_ftd.hpp   | 4 ++--
 src/core/meshcop/dtls.hpp                  | 2 +-
 src/core/meshcop/energy_scan_client.hpp    | 2 +-
 src/core/meshcop/joiner.hpp                | 2 +-
 src/core/meshcop/joiner_router.hpp         | 2 +-
 src/core/meshcop/leader.hpp                | 2 +-
 src/core/meshcop/panid_query_client.hpp    | 2 +-
 src/core/net/icmp6.hpp                     | 2 +-
 src/core/net/ip6.hpp                       | 2 +-
 src/core/net/ip6_mpl.hpp                   | 2 +-
 src/core/net/ip6_routes.hpp                | 2 +-
 src/core/net/udp6.hpp                      | 2 +-
 src/core/thread/announce_begin_server.hpp  | 2 +-
 src/core/thread/energy_scan_server.hpp     | 2 +-
 src/core/thread/panid_query_server.hpp     | 2 +-
 src/core/thread/thread_netif.hpp           | 2 +-
 24 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/src/core/api/link_raw.hpp b/src/core/api/link_raw.hpp
index d2bcca3fb..4151f6ca8 100644
--- a/src/core/api/link_raw.hpp
+++ b/src/core/api/link_raw.hpp
@@ -55,7 +55,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    LinkRaw(Instance &aInstance);
+    explicit LinkRaw(Instance &aInstance);
 
     /**
      * This method returns true if the raw link-layer is enabled.
diff --git a/src/core/coap/coap.hpp b/src/core/coap/coap.hpp
index 02ca4ed98..8ee5b1c56 100644
--- a/src/core/coap/coap.hpp
+++ b/src/core/coap/coap.hpp
@@ -747,7 +747,7 @@ public:
      * @param[in] aInstance      A reference to the OpenThread instance.
      *
      */
-    Coap(Instance &aInstance);
+    explicit Coap(Instance &aInstance);
 
 private:
     static void HandleRetransmissionTimer(Timer &aTimer);
@@ -769,7 +769,7 @@ public:
      * @param[in] aInstance      A reference to the OpenThread instance.
      *
      */
-    ApplicationCoap(Instance &aInstance);
+    explicit ApplicationCoap(Instance &aInstance);
 
 private:
     static void HandleRetransmissionTimer(Timer &aTimer);
diff --git a/src/core/coap/coap_secure.hpp b/src/core/coap/coap_secure.hpp
index 8742d75d6..396efcc9b 100644
--- a/src/core/coap/coap_secure.hpp
+++ b/src/core/coap/coap_secure.hpp
@@ -73,7 +73,7 @@ public:
      * @param[in]  aInstance  A reference to the OpenThread instance.
      *
      */
-    CoapSecure(Instance &aInstance);
+    explicit CoapSecure(Instance &aInstance);
 
     /**
      * This method starts the secure CoAP agent.
diff --git a/src/core/common/message.hpp b/src/core/common/message.hpp
index ab20f60fd..c3458edc3 100644
--- a/src/core/common/message.hpp
+++ b/src/core/common/message.hpp
@@ -1140,7 +1140,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    MessagePool(Instance &aInstance);
+    explicit MessagePool(Instance &aInstance);
 
     /**
      * This method is used to obtain a new message. The default priority `kDefaultMessagePriority`
diff --git a/src/core/common/notifier.hpp b/src/core/common/notifier.hpp
index 7c2869b61..e23904e23 100644
--- a/src/core/common/notifier.hpp
+++ b/src/core/common/notifier.hpp
@@ -106,7 +106,7 @@ public:
      *  @param[in] aInstance     A reference to OpenThread instance.
      *
      */
-    Notifier(Instance &aInstance);
+    explicit Notifier(Instance &aInstance);
 
     /**
      * This method registers a callback.
diff --git a/src/core/meshcop/announce_begin_client.hpp b/src/core/meshcop/announce_begin_client.hpp
index 1fd0f1826..26b2e4a89 100644
--- a/src/core/meshcop/announce_begin_client.hpp
+++ b/src/core/meshcop/announce_begin_client.hpp
@@ -54,7 +54,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    AnnounceBeginClient(Instance &aInstance);
+    explicit AnnounceBeginClient(Instance &aInstance);
 
     /**
      * This method sends a Announce Begin message.
diff --git a/src/core/meshcop/commissioner.hpp b/src/core/meshcop/commissioner.hpp
index 21b7200d1..393ebda9c 100644
--- a/src/core/meshcop/commissioner.hpp
+++ b/src/core/meshcop/commissioner.hpp
@@ -65,7 +65,7 @@ public:
      * @param[in]  aInstance     A reference to the OpenThread instance.
      *
      */
-    Commissioner(Instance &aInstance);
+    explicit Commissioner(Instance &aInstance);
 
     /**
      * This method starts the Commissioner service.
diff --git a/src/core/meshcop/dataset_manager.hpp b/src/core/meshcop/dataset_manager.hpp
index b452f68b6..2e0ebddc9 100644
--- a/src/core/meshcop/dataset_manager.hpp
+++ b/src/core/meshcop/dataset_manager.hpp
@@ -282,7 +282,7 @@ public:
      * @param[in]  aInstance      A reference to the OpenThread instance.
      *
      */
-    ActiveDatasetBase(Instance &aInstance);
+    explicit ActiveDatasetBase(Instance &aInstance);
 
     /**
      * This method restores the Active Operational Dataset from non-volatile memory.
@@ -364,7 +364,7 @@ public:
      * @param[in]  The Thread network interface.
      *
      */
-    PendingDatasetBase(Instance &aInstance);
+    explicit PendingDatasetBase(Instance &aInstance);
 
     /**
      * This method restores the Operational Dataset from non-volatile memory.
diff --git a/src/core/meshcop/dataset_manager_ftd.hpp b/src/core/meshcop/dataset_manager_ftd.hpp
index c23102a6e..650b5f6f6 100644
--- a/src/core/meshcop/dataset_manager_ftd.hpp
+++ b/src/core/meshcop/dataset_manager_ftd.hpp
@@ -53,7 +53,7 @@ namespace MeshCoP {
 class ActiveDataset: public ActiveDatasetBase
 {
 public:
-    ActiveDataset(Instance &aInstance);
+    explicit ActiveDataset(Instance &aInstance);
 
     otError GenerateLocal(void);
 
@@ -74,7 +74,7 @@ private:
 class PendingDataset: public PendingDatasetBase
 {
 public:
-    PendingDataset(Instance &aInstance);
+    explicit PendingDataset(Instance &aInstance);
 
     void StartLeader(void);
 
diff --git a/src/core/meshcop/dtls.hpp b/src/core/meshcop/dtls.hpp
index 9c6fa2887..4f12eb675 100644
--- a/src/core/meshcop/dtls.hpp
+++ b/src/core/meshcop/dtls.hpp
@@ -72,7 +72,7 @@ public:
      * @param[in]  aNetif  A reference to the Thread network interface.
      *
      */
-    Dtls(Instance &aInstance);
+    explicit Dtls(Instance &aInstance);
 
     /**
      * This function pointer is called when a connection is established or torn down.
diff --git a/src/core/meshcop/energy_scan_client.hpp b/src/core/meshcop/energy_scan_client.hpp
index 10563de51..af93fce5c 100644
--- a/src/core/meshcop/energy_scan_client.hpp
+++ b/src/core/meshcop/energy_scan_client.hpp
@@ -58,7 +58,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    EnergyScanClient(Instance &aInstance);
+    explicit EnergyScanClient(Instance &aInstance);
 
     /**
      * This method sends an Energy Scan Query message.
diff --git a/src/core/meshcop/joiner.hpp b/src/core/meshcop/joiner.hpp
index 6012a73f1..f3034fd45 100644
--- a/src/core/meshcop/joiner.hpp
+++ b/src/core/meshcop/joiner.hpp
@@ -63,7 +63,7 @@ public:
      * @param[in]  aInstance     A reference to the OpenThread instance.
      *
      */
-    Joiner(Instance &aInstance);
+    explicit Joiner(Instance &aInstance);
 
     /**
      * This method starts the Joiner service.
diff --git a/src/core/meshcop/joiner_router.hpp b/src/core/meshcop/joiner_router.hpp
index a301d4af8..041340188 100644
--- a/src/core/meshcop/joiner_router.hpp
+++ b/src/core/meshcop/joiner_router.hpp
@@ -64,7 +64,7 @@ public:
      * @param[in]  aInstance     A reference to the OpenThread instance.
      *
      */
-    JoinerRouter(Instance &aInstance);
+    explicit JoinerRouter(Instance &aInstance);
 
     /**
      * This method returns the Joiner UDP Port.
diff --git a/src/core/meshcop/leader.hpp b/src/core/meshcop/leader.hpp
index b9e4c1647..74c3ae866 100644
--- a/src/core/meshcop/leader.hpp
+++ b/src/core/meshcop/leader.hpp
@@ -70,7 +70,7 @@ public:
      * @param[in]  aInstance     A reference to the OpenThread instance.
      *
      */
-    Leader(Instance &aInstance);
+    explicit Leader(Instance &aInstance);
 
     /**
      * This method sends a MGMT_DATASET_CHANGED message to commissioner.
diff --git a/src/core/meshcop/panid_query_client.hpp b/src/core/meshcop/panid_query_client.hpp
index 84c0e14af..bd0de7bb7 100644
--- a/src/core/meshcop/panid_query_client.hpp
+++ b/src/core/meshcop/panid_query_client.hpp
@@ -58,7 +58,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    PanIdQueryClient(Instance &aInstance);
+    explicit PanIdQueryClient(Instance &aInstance);
 
     /**
      * This method sends a PAN ID Query message.
diff --git a/src/core/net/icmp6.hpp b/src/core/net/icmp6.hpp
index 533f4f282..45303d61b 100644
--- a/src/core/net/icmp6.hpp
+++ b/src/core/net/icmp6.hpp
@@ -231,7 +231,7 @@ public:
      * @param[in]  aInstance A reference to the OpenThread instance.
      *
      */
-    Icmp(Instance &aInstance);
+    explicit Icmp(Instance &aInstance);
 
     /**
      * This method returns a new ICMP message with sufficient header space reserved.
diff --git a/src/core/net/ip6.hpp b/src/core/net/ip6.hpp
index 40ae92649..00600af77 100644
--- a/src/core/net/ip6.hpp
+++ b/src/core/net/ip6.hpp
@@ -123,7 +123,7 @@ public:
      * @param[in]  aInstance   A reference to the otInstance object.
      *
      */
-    Ip6(Instance &aInstance);
+    explicit Ip6(Instance &aInstance);
 
     /**
      * This method sends an IPv6 datagram.
diff --git a/src/core/net/ip6_mpl.hpp b/src/core/net/ip6_mpl.hpp
index d79de6f73..98b699cf2 100644
--- a/src/core/net/ip6_mpl.hpp
+++ b/src/core/net/ip6_mpl.hpp
@@ -439,7 +439,7 @@ public:
      * @param[in]  aInstance  A reference to the OpenThread instance.
      *
      */
-    Mpl(Instance &aInstance);
+    explicit Mpl(Instance &aInstance);
 
     /**
      * This method initializes the MPL option.
diff --git a/src/core/net/ip6_routes.hpp b/src/core/net/ip6_routes.hpp
index 0a0b9e51c..ed184f5c3 100644
--- a/src/core/net/ip6_routes.hpp
+++ b/src/core/net/ip6_routes.hpp
@@ -80,7 +80,7 @@ public:
      * @param[in]  aInstance  A reference to the OpenThread instance.
      *
      */
-    Routes(Instance &aInstance);
+    explicit Routes(Instance &aInstance);
 
     /**
      * This method adds an IPv6 route.
diff --git a/src/core/net/udp6.hpp b/src/core/net/udp6.hpp
index 1a1cfb631..bcce9fa93 100644
--- a/src/core/net/udp6.hpp
+++ b/src/core/net/udp6.hpp
@@ -175,7 +175,7 @@ public:
      * @param[in]  aIp6  A reference to OpenThread instance.
      *
      */
-    Udp(Instance &aInstance);
+    explicit Udp(Instance &aInstance);
 
     /**
      * This method adds a UDP socket.
diff --git a/src/core/thread/announce_begin_server.hpp b/src/core/thread/announce_begin_server.hpp
index 80faa291d..07cc37c3d 100644
--- a/src/core/thread/announce_begin_server.hpp
+++ b/src/core/thread/announce_begin_server.hpp
@@ -56,7 +56,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    AnnounceBeginServer(Instance &aInstance);
+    explicit AnnounceBeginServer(Instance &aInstance);
 
     /**
      * This method begins the MLE Announce transmission process using Count=3 and Period=1s.
diff --git a/src/core/thread/energy_scan_server.hpp b/src/core/thread/energy_scan_server.hpp
index 71e67dc94..19cd6e267 100644
--- a/src/core/thread/energy_scan_server.hpp
+++ b/src/core/thread/energy_scan_server.hpp
@@ -64,7 +64,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    EnergyScanServer(Instance &aInstance);
+    explicit EnergyScanServer(Instance &aInstance);
 
 private:
     enum
diff --git a/src/core/thread/panid_query_server.hpp b/src/core/thread/panid_query_server.hpp
index 46736030a..e23063d0b 100644
--- a/src/core/thread/panid_query_server.hpp
+++ b/src/core/thread/panid_query_server.hpp
@@ -63,7 +63,7 @@ public:
      * This constructor initializes the object.
      *
      */
-    PanIdQueryServer(Instance &aInstance);
+    explicit PanIdQueryServer(Instance &aInstance);
 
 private:
     enum
diff --git a/src/core/thread/thread_netif.hpp b/src/core/thread/thread_netif.hpp
index 72ef1848e..01886226f 100644
--- a/src/core/thread/thread_netif.hpp
+++ b/src/core/thread/thread_netif.hpp
@@ -104,7 +104,7 @@ public:
      * @param[in]  aInstance  A reference to the OpenThread instance.
      *
      */
-    ThreadNetif(Instance &aInstance);
+    explicit ThreadNetif(Instance &aInstance);
 
     /**
      * This method enables the Thread network interface.