From 3d4812d15137a784aa16dbe9c6aa72d0dabd25f6 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Mon, 16 Mar 2026 15:31:56 -0700 Subject: [PATCH] [tests] handle return error value in TCAT unit test (#12685) This commit updates `tests/unit/test_tcat.cpp` to properly handle the `Error` return value from `NetworkName::Set()`, resolving compiler warnings about unhandled return types. In `TestInitInstanceTcat()`, `IgnoreError()` is used when setting default test values since `NetworkName::Set()` returns `kErrorNone` or `kErrorAlready` when the same name is set again. --- tests/unit/test_tcat.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/unit/test_tcat.cpp b/tests/unit/test_tcat.cpp index 89d9c811b..bc737463e 100644 --- a/tests/unit/test_tcat.cpp +++ b/tests/unit/test_tcat.cpp @@ -262,8 +262,8 @@ static Instance *TestInitInstanceTcat(void) // reset default data items used across tests sFullDataset = AsCoreType(&kFullDataset); sPartialDataset = AsCoreType(&kPartialDataset); - sCommNetworkName.Set(kNetworkName); - sCommDomainName.Set(kDomainName); + IgnoreError(sCommNetworkName.Set(kNetworkName)); + IgnoreError(sCommDomainName.Set(kDomainName)); memcpy(&sCommExtPanId, &kExtPanId, sizeof(sCommExtPanId)); memcpy(&sCommAuth, &kCommCert1AuthField, sizeof(sCommAuth)); memcpy(&sDeviceAuth, &kDeviceCert1AuthField, sizeof(sDeviceAuth)); @@ -580,7 +580,7 @@ public: // New situation: network name present, but mismatch - Extraction revoked NetworkName wrongNetworkName; - wrongNetworkName.Set("WrongName"); + SuccessOrQuit(wrongNetworkName.Set("WrongName")); MockNetworkName(agent, true, &wrongNetworkName); VerifyOrQuit(CommandClassesAuthorized(agent, kClassGeneral | kClassDecommissioning | kClassApplication)); VerifyOrQuit(!SetActiveDatasetAuthorized(agent, sFullDataset)); @@ -687,7 +687,7 @@ public: // If Network Name does not match NetworkName wrongNetworkName; - wrongNetworkName.Set(kWrongName); + SuccessOrQuit(wrongNetworkName.Set(kWrongName)); MockNetworkName(agent, true, &wrongNetworkName); VerifyOrQuit(CommandClassesAuthorized(agent, kClassGeneral | kClassExtraction | kClassApplication)); VerifyOrQuit(!SetActiveDatasetAuthorized(agent, sFullDataset));