From 3fb736c566754060c0456823911f6d9801a03e76 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Thu, 27 Dec 2018 16:30:32 -0800 Subject: [PATCH] [ncp-base] limit legacy related member variable definitions to FTD/MTD builds (#3407) This commit moves the definition of legacy related member variable in `NcpBase` into a `#if OPENTHREAD_MTD || OPENTHREAD_FTD` block. This addresses Coverity warning for un-initialized member variables from constructor. --- src/ncp/ncp_base.hpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ncp/ncp_base.hpp b/src/ncp/ncp_base.hpp index 7cee5a16e..801ef0739 100644 --- a/src/ncp/ncp_base.hpp +++ b/src/ncp/ncp_base.hpp @@ -553,18 +553,18 @@ protected: uint32_t mOutboundInsecureIpFrameCounter; // Number of insecure outbound data/IP frames. uint32_t mDroppedOutboundIpFrameCounter; // Number of dropped outbound data/IP frames. uint32_t mDroppedInboundIpFrameCounter; // Number of dropped inbound data/IP frames. -#endif // OPENTHREAD_MTD || OPENTHREAD_FTD - uint32_t mFramingErrorCounter; // Number of improperly formed received spinel frames. - uint32_t mRxSpinelFrameCounter; // Number of received (inbound) spinel frames. - uint32_t mRxSpinelOutOfOrderTidCounter; // Number of out of order received spinel frames (tid increase > 1). - uint32_t mTxSpinelFrameCounter; // Number of sent (outbound) spinel frames. - #if OPENTHREAD_ENABLE_LEGACY const otNcpLegacyHandlers *mLegacyHandlers; uint8_t mLegacyUlaPrefix[OT_NCP_LEGACY_ULA_PREFIX_LENGTH]; otExtAddress mLegacyLastJoinedNode; bool mLegacyNodeDidJoin; #endif +#endif // OPENTHREAD_MTD || OPENTHREAD_FTD + + uint32_t mFramingErrorCounter; // Number of improperly formed received spinel frames. + uint32_t mRxSpinelFrameCounter; // Number of received (inbound) spinel frames. + uint32_t mRxSpinelOutOfOrderTidCounter; // Number of out of order received spinel frames (tid increase > 1). + uint32_t mTxSpinelFrameCounter; // Number of sent (outbound) spinel frames. bool mDidInitialUpdates; };