espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-13 12:40:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mac-frame] check rx frame security level in GenerateEnhAck() (#9315)

Browse Source 
This commit updates the `Mac::TxFrame::GenerateEnhAck()` method to
check the security level of the received frame. If the security level
is not `kSecurityEncMic32`, it will return `kErrorParse`. This should
help prevent radio platform implementations from trying to perform tx
security on an invalid generated enhanced ack frame. Specifically, it
can help prevent radio platforms from calling `ProcessTxSecurity()`
on an enhanced ack frame with a security level of `kSecurityNone`
which can cause an assert in `AesCcm::Init()` due to the tag length
being zero.
This commit is contained in:
Abtin Keshavarzian
2023-07-28 09:16:39 -07:00
committed by GitHub
parent 650e30f81c
commit 3fd192dfa7
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/mac/mac_frame.cpp
+2
View File
@@ -1362,6 +1362,8 @@ Error TxFrame::GenerateEnhAck(const RxFrame &aFrame, bool aIsFramePending, const
SuccessOrExit(error = aFrame.GetSecurityControlField(securityControlField)); SuccessOrExit(error = aFrame.GetSecurityControlField(securityControlField));
SuccessOrExit(error = aFrame.GetKeyId(keyId)); SuccessOrExit(error = aFrame.GetKeyId(keyId));
VerifyOrExit((securityControlField & kSecLevelMask) == kSecurityEncMic32, error = kErrorParse);
SetSecurityControlField(securityControlField); SetSecurityControlField(securityControlField);
SetKeyId(keyId); SetKeyId(keyId);
} }