From 41a73b8add6e94ba4982cf8b60850a90929c4da1 Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Tue, 27 Oct 2020 21:07:13 -0700 Subject: [PATCH] [clang-tidy] readability-avoid-const-params-in-decls (#5717) --- include/openthread/coap.h | 2 +- include/openthread/instance.h | 2 +- script/make-pretty | 1 + src/core/api/coap_api.cpp | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/openthread/coap.h b/include/openthread/coap.h index a9da2d99e..5089df803 100644 --- a/include/openthread/coap.h +++ b/include/openthread/coap.h @@ -747,7 +747,7 @@ const otCoapOption *otCoapOptionIteratorGetNextOption(otCoapOptionIterator *aIte * * @see otCoapMessageAppendUintOption */ -otError otCoapOptionIteratorGetOptionUintValue(otCoapOptionIterator *aIterator, uint64_t *const aValue); +otError otCoapOptionIteratorGetOptionUintValue(otCoapOptionIterator *aIterator, uint64_t *aValue); /** * This function fills current option value into @p aValue. diff --git a/include/openthread/instance.h b/include/openthread/instance.h index 6a69a630a..108b2e24f 100644 --- a/include/openthread/instance.h +++ b/include/openthread/instance.h @@ -53,7 +53,7 @@ extern "C" { * @note This number versions both OpenThread platform and user APIs. * */ -#define OPENTHREAD_API_VERSION (40) +#define OPENTHREAD_API_VERSION (41) /** * @addtogroup api-instance diff --git a/script/make-pretty b/script/make-pretty index 8c4f30bde..338f6c0e5 100755 --- a/script/make-pretty +++ b/script/make-pretty @@ -119,6 +119,7 @@ readonly OT_CLANG_TIDY_CHECKS="\ modernize-use-bool-literals,\ modernize-use-equals-delete,\ modernize-use-nullptr,\ +readability-avoid-const-params-in-decls,\ readability-make-member-function-const,\ readability-simplify-boolean-expr,\ " diff --git a/src/core/api/coap_api.cpp b/src/core/api/coap_api.cpp index 721e4cd95..b84ec1882 100644 --- a/src/core/api/coap_api.cpp +++ b/src/core/api/coap_api.cpp @@ -204,7 +204,7 @@ const otCoapOption *otCoapOptionIteratorGetNextOption(otCoapOptionIterator *aIte return iterator.GetOption(); } -otError otCoapOptionIteratorGetOptionUintValue(otCoapOptionIterator *aIterator, uint64_t *const aValue) +otError otCoapOptionIteratorGetOptionUintValue(otCoapOptionIterator *aIterator, uint64_t *aValue) { return static_cast(aIterator)->ReadOptionValue(*aValue); }