From 42e590a8fca73bd84ac38f8a4af2b174a382f651 Mon Sep 17 00:00:00 2001 From: Yakun Xu Date: Thu, 5 Jul 2018 11:45:53 +0800 Subject: [PATCH] [posix-app] add missing check for spinel radio (#2855) --- src/posix/platform/radio_spinel.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/posix/platform/radio_spinel.cpp b/src/posix/platform/radio_spinel.cpp index 281f89408..6887a034d 100644 --- a/src/posix/platform/radio_spinel.cpp +++ b/src/posix/platform/radio_spinel.cpp @@ -969,7 +969,6 @@ otError RadioSpinel::Remove(spinel_prop_key_t aKey, const char *aFormat, ...) otError RadioSpinel::WaitResponse(void) { - otError error = OT_ERROR_NONE; struct timeval end; struct timeval now; struct timeval timeout = {kMaxWaitTime / 1000, (kMaxWaitTime % 1000) * 1000}; @@ -1030,13 +1029,11 @@ otError RadioSpinel::WaitResponse(void) } } while (mWaitingTid || !mIsReady); - error = mError; - exit: - LogIfFail(mInstance, "Error waiting response", error); + LogIfFail(mInstance, "Error waiting response", mError); // This indicates end of waiting repsonse. mWaitingKey = SPINEL_PROP_LAST_STATUS; - return error; + return mError; } spinel_tid_t RadioSpinel::GetNextTid(void) @@ -1412,13 +1409,13 @@ void otPlatRadioSetExtendedAddress(otInstance *aInstance, const otExtAddress *aA void otPlatRadioSetShortAddress(otInstance *aInstance, uint16_t aAddress) { - sRadioSpinel.SetShortAddress(aAddress); + SuccessOrDie(sRadioSpinel.SetShortAddress(aAddress)); OT_UNUSED_VARIABLE(aInstance); } void otPlatRadioSetPromiscuous(otInstance *aInstance, bool aEnable) { - sRadioSpinel.SetPromiscuous(aEnable); + SuccessOrDie(sRadioSpinel.SetPromiscuous(aEnable)); OT_UNUSED_VARIABLE(aInstance); }