From 451d8827ad03a84f33961542a040a4b852457bd9 Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Sat, 7 Nov 2020 19:45:28 -0800 Subject: [PATCH] [clang-tidy] readability-redundant-member-init (#5781) --- script/make-pretty | 1 + src/core/coap/coap.cpp | 5 +---- src/core/coap/coap_message.hpp | 5 +---- src/core/coap/coap_secure.cpp | 1 - src/core/common/instance.cpp | 10 +--------- src/core/common/message.cpp | 1 - src/core/common/notifier.cpp | 2 -- src/core/common/timer.hpp | 1 - src/core/mac/mac.cpp | 8 -------- src/core/net/icmp6.cpp | 1 - src/core/net/ip6.cpp | 1 - src/core/net/netif.cpp | 4 ---- src/core/net/udp6.cpp | 2 -- src/core/thread/address_resolver.cpp | 4 ---- src/core/thread/announce_sender.cpp | 1 - src/core/thread/discover_scanner.cpp | 1 - src/core/thread/link_metrics.cpp | 1 - src/lib/spinel/spinel_encoder.hpp | 1 - src/ncp/ncp_base.cpp | 2 -- src/ncp/ncp_uart.cpp | 2 -- 20 files changed, 4 insertions(+), 50 deletions(-) diff --git a/script/make-pretty b/script/make-pretty index 7d6061198..c5c6b1011 100755 --- a/script/make-pretty +++ b/script/make-pretty @@ -125,6 +125,7 @@ modernize-use-equals-delete,\ modernize-use-nullptr,\ readability-avoid-const-params-in-decls,\ readability-make-member-function-const,\ +readability-redundant-member-init,\ readability-simplify-boolean-expr,\ readability-static-accessed-through-instance,\ " diff --git a/src/core/coap/coap.cpp b/src/core/coap/coap.cpp index 5b8c7f324..21b853c7c 100644 --- a/src/core/coap/coap.cpp +++ b/src/core/coap/coap.cpp @@ -48,10 +48,8 @@ namespace Coap { CoapBase::CoapBase(Instance &aInstance, Sender aSender) : InstanceLocator(aInstance) - , mPendingRequests() , mMessageId(Random::NonCrypto::GetUint16()) , mRetransmissionTimer(aInstance, Coap::HandleRetransmissionTimer, this) - , mResources() , mContext(nullptr) , mInterceptor(nullptr) , mResponsesQueue(aInstance) @@ -764,8 +762,7 @@ void CoapBase::Metadata::UpdateIn(Message &aMessage) const } ResponsesQueue::ResponsesQueue(Instance &aInstance) - : mQueue() - , mTimer(aInstance, ResponsesQueue::HandleTimer, this) + : mTimer(aInstance, ResponsesQueue::HandleTimer, this) { } diff --git a/src/core/coap/coap_message.hpp b/src/core/coap/coap_message.hpp index bf155e10a..6852aa253 100644 --- a/src/core/coap/coap_message.hpp +++ b/src/core/coap/coap_message.hpp @@ -902,10 +902,7 @@ public: * This constructor initializes the message queue. * */ - MessageQueue(void) - : ot::MessageQueue() - { - } + MessageQueue(void) = default; /** * This method returns a pointer to the first message. diff --git a/src/core/coap/coap_secure.cpp b/src/core/coap/coap_secure.cpp index 130291bd9..06769f88b 100644 --- a/src/core/coap/coap_secure.cpp +++ b/src/core/coap/coap_secure.cpp @@ -50,7 +50,6 @@ CoapSecure::CoapSecure(Instance &aInstance, bool aLayerTwoSecurity) , mDtls(aInstance, aLayerTwoSecurity) , mConnectedCallback(nullptr) , mConnectedContext(nullptr) - , mTransmitQueue() , mTransmitTask(aInstance, CoapSecure::HandleTransmit, this) { } diff --git a/src/core/common/instance.cpp b/src/core/common/instance.cpp index 70bc65697..d1bb08bd2 100644 --- a/src/core/common/instance.cpp +++ b/src/core/common/instance.cpp @@ -59,18 +59,10 @@ otHeapCAllocFn ot::Instance::mCAlloc = nullptr; #endif // OPENTHREAD_MTD || OPENTHREAD_FTD Instance::Instance(void) - : mTaskletScheduler() - , mTimerMilliScheduler(*this) + : mTimerMilliScheduler(*this) #if OPENTHREAD_CONFIG_PLATFORM_USEC_TIMER_ENABLE , mTimerMicroScheduler(*this) #endif -#if OPENTHREAD_MTD || OPENTHREAD_FTD -#if !OPENTHREAD_CONFIG_MULTIPLE_INSTANCE_ENABLE && !OPENTHREAD_CONFIG_HEAP_EXTERNAL_ENABLE - , mHeap() -#endif - , mMbedTls() -#endif // #if OPENTHREAD_MTD || OPENTHREAD_FTD - , mRandomManager() , mRadio(*this) #if OPENTHREAD_MTD || OPENTHREAD_FTD , mNotifier(*this) diff --git a/src/core/common/message.cpp b/src/core/common/message.cpp index 37bb5241d..54e582604 100644 --- a/src/core/common/message.cpp +++ b/src/core/common/message.cpp @@ -47,7 +47,6 @@ MessagePool::MessagePool(Instance &aInstance) : InstanceLocator(aInstance) #if !OPENTHREAD_CONFIG_PLATFORM_MESSAGE_MANAGEMENT , mNumFreeBuffers(kNumBuffers) - , mBufferPool() #endif { #if OPENTHREAD_CONFIG_PLATFORM_MESSAGE_MANAGEMENT diff --git a/src/core/common/notifier.cpp b/src/core/common/notifier.cpp index caf9c606b..4a96300cd 100644 --- a/src/core/common/notifier.cpp +++ b/src/core/common/notifier.cpp @@ -42,8 +42,6 @@ namespace ot { Notifier::Notifier(Instance &aInstance) : InstanceLocator(aInstance) - , mEventsToSignal() - , mSignaledEvents() , mTask(aInstance, Notifier::EmitEvents, this) { for (ExternalCallback &callback : mExternalCallbacks) diff --git a/src/core/common/timer.hpp b/src/core/common/timer.hpp index 16bfabc11..e3bf7c27b 100644 --- a/src/core/common/timer.hpp +++ b/src/core/common/timer.hpp @@ -276,7 +276,6 @@ protected: */ explicit TimerScheduler(Instance &aInstance) : InstanceLocator(aInstance) - , mTimerList() { } diff --git a/src/core/mac/mac.cpp b/src/core/mac/mac.cpp index cc981f71d..bf397c6bd 100644 --- a/src/core/mac/mac.cpp +++ b/src/core/mac/mac.cpp @@ -102,13 +102,8 @@ Mac::Mac(Instance &aInstance) , mPanChannel(OPENTHREAD_CONFIG_DEFAULT_CHANNEL) , mRadioChannel(OPENTHREAD_CONFIG_DEFAULT_CHANNEL) , mSupportedChannelMask(Get().GetSupportedChannelMask()) - , mNetworkName() -#if (OPENTHREAD_CONFIG_THREAD_VERSION >= OT_THREAD_VERSION_1_2) - , mDomainName() -#endif , mScanChannel(Radio::kChannelMin) , mScanDuration(0) - , mScanChannelMask() , mMaxFrameRetriesDirect(kDefaultMaxFrameRetriesDirect) #if OPENTHREAD_FTD , mMaxFrameRetriesIndirect(kDefaultMaxFrameRetriesIndirect) @@ -124,9 +119,6 @@ Mac::Mac(Instance &aInstance) , mOobFrame(nullptr) , mKeyIdMode2FrameCounter(0) , mCcaSampleCount(0) -#if OPENTHREAD_CONFIG_MAC_FILTER_ENABLE - , mFilter() -#endif { ExtAddress randomExtAddress; diff --git a/src/core/net/icmp6.cpp b/src/core/net/icmp6.cpp index 5763d6570..51a30a869 100644 --- a/src/core/net/icmp6.cpp +++ b/src/core/net/icmp6.cpp @@ -47,7 +47,6 @@ namespace Ip6 { Icmp::Icmp(Instance &aInstance) : InstanceLocator(aInstance) - , mHandlers() , mEchoSequence(1) , mEchoMode(OT_ICMP6_ECHO_HANDLER_ALL) { diff --git a/src/core/net/ip6.cpp b/src/core/net/ip6.cpp index fcfc59226..aa5cc1ce4 100644 --- a/src/core/net/ip6.cpp +++ b/src/core/net/ip6.cpp @@ -60,7 +60,6 @@ Ip6::Ip6(Instance &aInstance) , mIsReceiveIp6FilterEnabled(false) , mReceiveIp6DatagramCallback(nullptr) , mReceiveIp6DatagramCallbackContext(nullptr) - , mSendQueue() , mSendQueueTask(aInstance, Ip6::HandleSendQueue, this) , mIcmp(aInstance) , mUdp(aInstance) diff --git a/src/core/net/netif.cpp b/src/core/net/netif.cpp index 3f15723b7..e733fa0cb 100644 --- a/src/core/net/netif.cpp +++ b/src/core/net/netif.cpp @@ -105,13 +105,9 @@ const otNetifMulticastAddress Netif::kLinkLocalAllRoutersMulticastAddress = { Netif::Netif(Instance &aInstance) : InstanceLocator(aInstance) - , mUnicastAddresses() - , mMulticastAddresses() , mMulticastPromiscuous(false) , mAddressCallback(nullptr) , mAddressCallbackContext(nullptr) - , mExtUnicastAddressPool() - , mExtMulticastAddressPool() { } diff --git a/src/core/net/udp6.cpp b/src/core/net/udp6.cpp index 063a059aa..91b5e0e70 100644 --- a/src/core/net/udp6.cpp +++ b/src/core/net/udp6.cpp @@ -176,8 +176,6 @@ exit: Udp::Udp(Instance &aInstance) : InstanceLocator(aInstance) , mEphemeralPort(kDynamicPortMin) - , mReceivers() - , mSockets() #if OPENTHREAD_FTD && OPENTHREAD_CONFIG_BACKBONE_ROUTER_ENABLE , mPrevBackboneSockets(nullptr) #endif diff --git a/src/core/thread/address_resolver.cpp b/src/core/thread/address_resolver.cpp index 58cd35e10..1c05a1c76 100644 --- a/src/core/thread/address_resolver.cpp +++ b/src/core/thread/address_resolver.cpp @@ -57,10 +57,6 @@ AddressResolver::AddressResolver(Instance &aInstance) , mAddressQuery(UriPath::kAddressQuery, &AddressResolver::HandleAddressQuery, this) , mAddressNotification(UriPath::kAddressNotify, &AddressResolver::HandleAddressNotification, this) , mCacheEntryPool(aInstance) - , mCachedList() - , mSnoopedList() - , mQueryList() - , mQueryRetryList() , mIcmpHandler(&AddressResolver::HandleIcmpReceive, this) { Get().AddResource(mAddressError); diff --git a/src/core/thread/announce_sender.cpp b/src/core/thread/announce_sender.cpp index fd18d982a..f8b549577 100644 --- a/src/core/thread/announce_sender.cpp +++ b/src/core/thread/announce_sender.cpp @@ -48,7 +48,6 @@ namespace ot { AnnounceSenderBase::AnnounceSenderBase(Instance &aInstance, Timer::Handler aHandler) : InstanceLocator(aInstance) - , mChannelMask() , mPeriod(0) , mJitter(0) , mCount(0) diff --git a/src/core/thread/discover_scanner.cpp b/src/core/thread/discover_scanner.cpp index fa183fcd5..66b1f0fa1 100644 --- a/src/core/thread/discover_scanner.cpp +++ b/src/core/thread/discover_scanner.cpp @@ -50,7 +50,6 @@ DiscoverScanner::DiscoverScanner(Instance &aInstance) , mHandlerContext(nullptr) , mTimer(aInstance, DiscoverScanner::HandleTimer, this) , mFilterIndexes() - , mScanChannels() , mState(kStateIdle) , mScanChannel(0) , mAdvDataLength(0) diff --git a/src/core/thread/link_metrics.cpp b/src/core/thread/link_metrics.cpp index 5af82f244..80d29d9e2 100644 --- a/src/core/thread/link_metrics.cpp +++ b/src/core/thread/link_metrics.cpp @@ -108,7 +108,6 @@ LinkMetrics::LinkMetrics(Instance &aInstance) : InstanceLocator(aInstance) , mLinkMetricsReportCallback(nullptr) , mLinkMetricsReportCallbackContext(nullptr) - , mLinkMetricsSeriesInfoPool() { } diff --git a/src/lib/spinel/spinel_encoder.hpp b/src/lib/spinel/spinel_encoder.hpp index 84f2df6f7..44ea0781b 100644 --- a/src/lib/spinel/spinel_encoder.hpp +++ b/src/lib/spinel/spinel_encoder.hpp @@ -62,7 +62,6 @@ public: : mNcpBuffer(aNcpBuffer) , mNumOpenStructs(0) , mSavedNumOpenStructs(0) - , mSavedPosition() { } diff --git a/src/ncp/ncp_base.cpp b/src/ncp/ncp_base.cpp index 152c6fe6b..682344dff 100644 --- a/src/ncp/ncp_base.cpp +++ b/src/ncp/ncp_base.cpp @@ -197,7 +197,6 @@ NcpBase::NcpBase(Instance *aInstance) : mInstance(aInstance) , mTxFrameBuffer(mTxBuffer, sizeof(mTxBuffer)) , mEncoder(mTxFrameBuffer) - , mDecoder() , mHostPowerStateInProgress(false) , mLastStatus(SPINEL_STATUS_OK) , mScanChannelMask(Radio::kSupportedChannels) @@ -207,7 +206,6 @@ NcpBase::NcpBase(Instance *aInstance) , mDiscoveryScanPanId(0xffff) , mUpdateChangedPropsTask(*aInstance, NcpBase::UpdateChangedProps, this) , mThreadChangedFlags(0) - , mChangedPropsSet() , mHostPowerState(SPINEL_HOST_POWER_STATE_ONLINE) , mHostPowerReplyFrameTag(Spinel::Buffer::kInvalidTag) , mHostPowerStateHeader(0) diff --git a/src/ncp/ncp_uart.cpp b/src/ncp/ncp_uart.cpp index 8d1f9b6cb..e5d0e1c03 100644 --- a/src/ncp/ncp_uart.cpp +++ b/src/ncp/ncp_uart.cpp @@ -84,10 +84,8 @@ NcpUart::NcpUart(Instance *aInstance) : NcpBase(aInstance) , mFrameEncoder(mUartBuffer) , mFrameDecoder(mRxBuffer, &NcpUart::HandleFrame, this) - , mUartBuffer() , mState(kStartingFrame) , mByte(0) - , mRxBuffer() , mUartSendImmediate(false) , mUartSendTask(*aInstance, EncodeAndSendToUart, this) #if OPENTHREAD_ENABLE_NCP_SPINEL_ENCRYPTER