espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-10-21 23:18:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

[message] improve scoping of Buffer constants (#11885)

Browse Source 
This commit moves two global constants, `kBufferSize` and
`kNumBuffers`, into their respective class scopes to improve
encapsulation and avoid potential name conflicts.

The `kBufferSize` constant is moved into the `Buffer` class as
`Buffer::kSize`. As `kBufferSize` is a generic and commonly used
name, this change prevents potential symbol collisions.

Similarly, the `kNumBuffers` constant is moved into the `MessagePool`
class, as it is exclusively used within that class.

All usages of these constants have been updated throughout the
codebase to reflect their new names.
This commit is contained in:
Abtin Keshavarzian
2025-08-29 18:21:04 -07:00
committed by GitHub
parent 269268fbf6
commit 4d1ae8552a
5 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_checksum.cpp
+4 -4
View File
@@ -173,7 +173,7 @@ void CorruptMessage(Message &aMessage)
void TestUdpMessageChecksum(void)
{
constexpr uint16_t kMinSize = sizeof(Ip6::Udp::Header);
constexpr uint16_t kMaxSize = kBufferSize * 3 + 24;
constexpr uint16_t kMaxSize = Buffer::kSize * 3 + 24;
const char *kSourceAddress = "fd00:1122:3344:5566:7788:99aa:bbcc:ddee";
const char *kDestAddress = "fd01:2345:6789:abcd:ef01:2345:6789:abcd";
@@ -241,7 +241,7 @@ void TestUdpMessageChecksum(void)
void TestIcmp6MessageChecksum(void)
{
constexpr uint16_t kMinSize = sizeof(Ip6::Icmp::Header);
constexpr uint16_t kMaxSize = kBufferSize * 3 + 24;
constexpr uint16_t kMaxSize = Buffer::kSize * 3 + 24;
const char *kSourceAddress = "fd00:feef:dccd:baab:9889:7667:5444:3223";
const char *kDestAddress = "fd01:abab:beef:cafe:1234:5678:9abc:0";
@@ -310,7 +310,7 @@ void TestIcmp6MessageChecksum(void)
void TestTcp4MessageChecksum(void)
{
constexpr size_t kMinSize = sizeof(Ip4::Tcp::Header);
constexpr size_t kMaxSize = kBufferSize * 3 + 24;
constexpr size_t kMaxSize = Buffer::kSize * 3 + 24;
const char *kSourceAddress = "12.34.56.78";
const char *kDestAddress = "87.65.43.21";
@@ -365,7 +365,7 @@ void TestTcp4MessageChecksum(void)
void TestUdp4MessageChecksum(void)
{
constexpr uint16_t kMinSize = sizeof(Ip4::Udp::Header);
constexpr uint16_t kMaxSize = kBufferSize * 3 + 24;
constexpr uint16_t kMaxSize = Buffer::kSize * 3 + 24;
const char *kSourceAddress = "12.34.56.78";
const char *kDestAddress = "87.65.43.21";