From 5f39ba055bb5adcc28fd545226cbd6836a015c2e Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Fri, 16 Jul 2021 09:49:18 -0700 Subject: [PATCH] [srp-server] fix clang-tidy warnings (#6822) - enable SRP server in clang-tidy check - remove static member access through instance --- script/make-pretty | 1 + src/core/net/srp_server.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/script/make-pretty b/script/make-pretty index 506717ace..ce9a148b7 100755 --- a/script/make-pretty +++ b/script/make-pretty @@ -114,6 +114,7 @@ readonly OT_CLANG_TIDY_BUILD_OPTS=( '-DOT_SLAAC=ON' '-DOT_SNTP_CLIENT=ON' '-DOT_SRP_CLIENT=ON' + '-DOT_SRP_SERVER=ON' '-DOT_THREAD_VERSION=1.2' '-DOT_TREL=ON' '-DOT_COVERAGE=ON' diff --git a/src/core/net/srp_server.cpp b/src/core/net/srp_server.cpp index 97f0a6f36..02863ccda 100644 --- a/src/core/net/srp_server.cpp +++ b/src/core/net/srp_server.cpp @@ -1853,7 +1853,7 @@ Server::UpdateMetadata *Server::UpdateMetadata::New(Instance & aIn void * buf; UpdateMetadata *update = nullptr; - buf = aInstance.HeapCAlloc(1, sizeof(UpdateMetadata)); + buf = Instance::HeapCAlloc(1, sizeof(UpdateMetadata)); VerifyOrExit(buf != nullptr); update = new (buf) UpdateMetadata(aInstance, aHeader, aHost, aMessageInfo);