espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-11 19:50:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[error] add missing IgnoreError (#4931)

Browse Source
This commit is contained in:
Abtin Keshavarzian
2020-05-06 22:05:25 -07:00
committed by Jonathan Hui
parent 64dfe6349c
commit 612e10e664
9 changed files with 40 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_netif.cpp
+14 -13
View File
@@ -32,6 +32,7 @@
#include <openthread/config.h>
#include "common/code_utils.hpp"
#include "common/debug.hpp"
#include "common/instance.hpp"
#include "net/netif.hpp"
@@ -104,14 +105,14 @@ void TestNetifMulticastAddresses(void)
const char *kTestAddress2 = "ff03::114";
const char *kTestAddress3 = "ff04::114";
addresses[0].FromString(kLinkLocalAllRouters);
addresses[1].FromString(kRealmLocalAllRouters);
addresses[2].FromString(kLinkLocalAllNodes);
addresses[3].FromString(kRealmLocalAllNodes);
addresses[4].FromString(kRealmLocalAllMpl);
addresses[5].FromString(kTestAddress1);
addresses[6].FromString(kTestAddress2);
addresses[7].FromString(kTestAddress3);
IgnoreError(addresses[0].FromString(kLinkLocalAllRouters));
IgnoreError(addresses[1].FromString(kRealmLocalAllRouters));
IgnoreError(addresses[2].FromString(kLinkLocalAllNodes));
IgnoreError(addresses[3].FromString(kRealmLocalAllNodes));
IgnoreError(addresses[4].FromString(kRealmLocalAllMpl));
IgnoreError(addresses[5].FromString(kTestAddress1));
IgnoreError(addresses[6].FromString(kTestAddress2));
IgnoreError(addresses[7].FromString(kTestAddress3));
VerifyMulticastAddressList(netif, addresses, 0);
@@ -134,7 +135,7 @@ void TestNetifMulticastAddresses(void)
VerifyOrQuit(netif.UnsubscribeAllRoutersMulticast() == OT_ERROR_NOT_FOUND,
"UnsubscribeAllRoutersMulticast() did not fail when not subscribed");
netifAddress.GetAddress().FromString(kTestAddress1);
IgnoreError(netifAddress.GetAddress().FromString(kTestAddress1));
SuccessOrQuit(netif.SubscribeMulticast(netifAddress), "SubscribeMulticast() failed");
VerifyMulticastAddressList(netif, &addresses[2], 4);
@@ -147,7 +148,7 @@ void TestNetifMulticastAddresses(void)
VerifyOrQuit(netif.UnsubscribeAllNodesMulticast() == OT_ERROR_NOT_FOUND,
"UnsubscribeAllNodesMulticast() did not fail when not subscribed");
address.FromString(kTestAddress2);
IgnoreError(address.FromString(kTestAddress2));
SuccessOrQuit(netif.SubscribeExternalMulticast(address), "SubscribeExternalMulticast() failed");
VerifyMulticastAddressList(netif, &addresses[5], 2);
@@ -163,15 +164,15 @@ void TestNetifMulticastAddresses(void)
VerifyOrQuit(netif.SubscribeAllRoutersMulticast() == OT_ERROR_ALREADY,
"SubscribeAllRoutersMulticast() did not fail when already subscribed");
address.FromString(kTestAddress3);
IgnoreError(address.FromString(kTestAddress3));
SuccessOrQuit(netif.SubscribeExternalMulticast(address), "SubscribeExternalMulticast() failed");
VerifyMulticastAddressList(netif, &addresses[0], 8);
address.FromString(kTestAddress1); // same as netifAddress (internal)
IgnoreError(address.FromString(kTestAddress1)); // same as netifAddress (internal)
VerifyOrQuit(netif.UnsubscribeExternalMulticast(address) == OT_ERROR_INVALID_ARGS,
"UnsubscribeExternalMulticast() did not fail when address was not external");
address.FromString(kRealmLocalAllMpl);
IgnoreError(address.FromString(kRealmLocalAllMpl));
VerifyOrQuit(netif.UnsubscribeExternalMulticast(address) == OT_ERROR_INVALID_ARGS,
"UnsubscribeExternalMulticast() did not fail when address was fixed address");