From 64dfe6349cbe8e97ae694e7e4c456727313a7f67 Mon Sep 17 00:00:00 2001
From: Moandor <moandor.y@gmail.com>
Date: Thu, 7 May 2020 09:45:03 +0800
Subject: [PATCH] [posix] remove duplicate otExitCodeToString definition
 (#4928)

---
 examples/platforms/samr21/CMakeLists.txt |  2 ++
 src/ncp/CMakeLists.txt                   |  1 +
 src/posix/platform/misc.cpp              | 43 ------------------------
 third_party/microchip/CMakeLists.txt     |  4 +--
 4 files changed, 5 insertions(+), 45 deletions(-)

diff --git a/examples/platforms/samr21/CMakeLists.txt b/examples/platforms/samr21/CMakeLists.txt
index a3066ac57..dd7b70800 100644
--- a/examples/platforms/samr21/CMakeLists.txt
+++ b/examples/platforms/samr21/CMakeLists.txt
@@ -88,6 +88,8 @@ target_compile_definitions(openthread-samr21
 
 target_compile_options(openthread-samr21
     PRIVATE
+        -Wno-implicit-function-declaration
+        -Wno-expansion-to-defined
         ${OT_CFLAGS}
 )
 
diff --git a/src/ncp/CMakeLists.txt b/src/ncp/CMakeLists.txt
index 885902aff..01c6383ce 100644
--- a/src/ncp/CMakeLists.txt
+++ b/src/ncp/CMakeLists.txt
@@ -105,6 +105,7 @@ target_link_libraries(openthread-ncp-ftd
     PUBLIC
         openthread-ftd
     PRIVATE
+        ${OT_PLATFORM_LIB}
         ${OT_MBEDTLS}
         openthread-hdlc
         openthread-spinel-ncp
diff --git a/src/posix/platform/misc.cpp b/src/posix/platform/misc.cpp
index dab40916f..0251b7a1e 100644
--- a/src/posix/platform/misc.cpp
+++ b/src/posix/platform/misc.cpp
@@ -108,46 +108,3 @@ exit:
 
     return fd;
 }
-
-const char *otExitCodeToString(uint8_t aExitCode)
-{
-    const char *retval = NULL;
-
-    switch (aExitCode)
-    {
-    case OT_EXIT_SUCCESS:
-        retval = "Success";
-        break;
-
-    case OT_EXIT_FAILURE:
-        retval = "Failure";
-        break;
-
-    case OT_EXIT_INVALID_ARGUMENTS:
-        retval = "InvalidArgument";
-        break;
-
-    case OT_EXIT_RADIO_SPINEL_INCOMPATIBLE:
-        retval = "RadioSpinelIncompatible";
-        break;
-
-    case OT_EXIT_RADIO_SPINEL_RESET:
-        retval = "RadioSpinelReset";
-        break;
-
-    case OT_EXIT_RADIO_SPINEL_NO_RESPONSE:
-        retval = "RadioSpinelNoResponse";
-        break;
-
-    case OT_EXIT_ERROR_ERRNO:
-        retval = strerror(errno);
-        break;
-
-    default:
-        assert(false);
-        retval = "UnknownExitCode";
-        break;
-    }
-
-    return retval;
-}
diff --git a/third_party/microchip/CMakeLists.txt b/third_party/microchip/CMakeLists.txt
index 9b3819c09..e004762c2 100644
--- a/third_party/microchip/CMakeLists.txt
+++ b/third_party/microchip/CMakeLists.txt
@@ -80,10 +80,10 @@ target_compile_options(samr21-driver
     PUBLIC
         -Werror
         -Wno-unused-parameter
-        -Wno-implicit-function-declaration
-        -Wno-expansion-to-defined
         -fno-strict-aliasing
     PRIVATE
+        -Wno-implicit-function-declaration
+        -Wno-expansion-to-defined
         ${OT_CFLAGS}
 )