From 686c0de5fa79d5afe5b3128fabdb61e05610607d Mon Sep 17 00:00:00 2001
From: Abtin Keshavarzian <abtink@google.com>
Date: Tue, 14 Dec 2021 18:37:22 -0800
Subject: [PATCH] [linked-list] fix `OwningList::RemoveAllMatching()` (#7231)

This commit fixes the `OwningList::RemoveAllMatching()` to use the
`LinkedList` one. It also updates unit test `test_linked_list` to
cover this method.
---
 src/core/common/owning_list.hpp |  2 +-
 tests/unit/test_linked_list.cpp | 36 ++++++++++++++++++++++++++++++++-
 2 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/src/core/common/owning_list.hpp b/src/core/common/owning_list.hpp
index 75d201e8a..9f57f10b6 100644
--- a/src/core/common/owning_list.hpp
+++ b/src/core/common/owning_list.hpp
@@ -147,7 +147,7 @@ public:
      */
     template <typename Indicator> void RemoveAllMatching(const Indicator &aIndicator, OwningList &aRemovedList)
     {
-        RemoveAllMatching(aIndicator, aRemovedList);
+        LinkedList<Type>::RemoveAllMatching(aIndicator, aRemovedList);
     }
 };
 
diff --git a/tests/unit/test_linked_list.cpp b/tests/unit/test_linked_list.cpp
index 65944b52d..f84f63dce 100644
--- a/tests/unit/test_linked_list.cpp
+++ b/tests/unit/test_linked_list.cpp
@@ -298,8 +298,10 @@ void TestLinkedList(void)
 
 void TestOwningList(void)
 {
-    Entry             a("a", 1), b("b", 2), c("c", 3), d("d", 4), e("e", 5);
+    Entry             a("a", 1, kAlphaType), b("b", 2, kAlphaType), c("c", 3, kBetaType);
+    Entry             d("d", 4, kBetaType), e("e", 5, kAlphaType), f("f", 6, kBetaType);
     OwningList<Entry> list;
+    OwningList<Entry> removedList;
     OwnedPtr<Entry>   ptr;
 
     printf("TestOwningList\n");
@@ -389,6 +391,38 @@ void TestOwningList(void)
     VerifyOrQuit(!a.WasFreed());
     a.Free();
     VerifyOrQuit(a.WasFreed());
+
+    // Test `RemoveAllMatching()`
+
+    a.ResetTestFlags();
+    b.ResetTestFlags();
+    c.ResetTestFlags();
+    d.ResetTestFlags();
+    e.ResetTestFlags();
+    f.ResetTestFlags();
+    list.Push(a);
+    list.Push(b);
+    list.Push(c);
+    list.Push(d);
+    list.Push(e);
+    list.Push(f);
+    VerifyLinkedListContent(&list, &f, &e, &d, &c, &b, &a, nullptr);
+
+    list.RemoveAllMatching(kAlphaType, removedList);
+    VerifyLinkedListContent(&list, &f, &d, &c, nullptr);
+    VerifyLinkedListContent(&removedList, &a, &b, &e, nullptr);
+    VerifyOrQuit(!a.WasFreed());
+    VerifyOrQuit(!c.WasFreed());
+
+    removedList.Clear();
+    list.RemoveAllMatching(kAlphaType, removedList);
+    VerifyOrQuit(removedList.IsEmpty());
+    VerifyLinkedListContent(&list, &f, &d, &c, nullptr);
+
+    list.RemoveAllMatching(kBetaType, removedList);
+    VerifyOrQuit(list.IsEmpty());
+    VerifyLinkedListContent(&removedList, &c, &d, &f, nullptr);
+    VerifyOrQuit(!c.WasFreed());
 }
 
 } // namespace ot