From 68ddd042abfe6b3df7a63bbb4f61c58efd8b8da8 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Mon, 6 Apr 2026 21:47:03 -0700 Subject: [PATCH] [mle] enhance logs for scheduled delayed message transmissions (#12848) This commit updates the logging in `Mle::DelayedSender` to provide clearer information about delayed message transmissions. The `MessageAction` enum values `kMessageDelay` and `kMessageRemoveDelayed` are renamed to `kMessageScheduleDelayedSend` and `kMessageRemoveDelayedSend` to better reflect their purpose. The corresponding string mappings are also updated to "Schedule tx of" and "Remove scheduled tx of". Additionally, a new log entry is added to `AddSchedule()` to explicitly record the delay duration in milliseconds, making it easier to track when the scheduled message is expected to be sent. --- src/core/thread/mle.cpp | 15 ++++++++------- src/core/thread/mle.hpp | 4 ++-- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/core/thread/mle.cpp b/src/core/thread/mle.cpp index cbaa0391c..df62f71e1 100644 --- a/src/core/thread/mle.cpp +++ b/src/core/thread/mle.cpp @@ -2886,11 +2886,11 @@ void Mle::LogError(MessageAction aAction, MessageType aType, Error aError) const char *Mle::MessageActionToString(MessageAction aAction) { -#define MessageActionMapList(_) \ - _(kMessageSend, "Send") \ - _(kMessageReceive, "Receive") \ - _(kMessageDelay, "Delay") \ - _(kMessageRemoveDelayed, "Remove Delayed") +#define MessageActionMapList(_) \ + _(kMessageSend, "Send") \ + _(kMessageReceive, "Receive") \ + _(kMessageScheduleDelayedSend, "Schedule tx of") \ + _(kMessageRemoveDelayedSend, "Remove scheduled tx of") DefineEnumStringArray(MessageActionMapList); @@ -3285,7 +3285,8 @@ void Mle::DelayedSender::AddSchedule(MessageType aMessageType, mSchedules.Enqueue(*schedule); schedule = nullptr; - Log(kMessageDelay, aMessageType, aDestination); + Log(kMessageScheduleDelayedSend, aMessageType, aDestination); + LogInfo(" Will send in %lu msec", ToUlong(aDelay)); exit: FreeMessage(schedule); @@ -3455,7 +3456,7 @@ void Mle::DelayedSender::LogRemove(const Schedule &aSchedule) Header header; header.ReadFrom(aSchedule); - Log(kMessageRemoveDelayed, header.mMessageType, header.mDestination); + Log(kMessageRemoveDelayedSend, header.mMessageType, header.mDestination); } #else void Mle::DelayedSender::LogRemove(const Schedule &) {} diff --git a/src/core/thread/mle.hpp b/src/core/thread/mle.hpp index c957e02fb..3ad1edd20 100644 --- a/src/core/thread/mle.hpp +++ b/src/core/thread/mle.hpp @@ -1475,8 +1475,8 @@ private: { kMessageSend, kMessageReceive, - kMessageDelay, - kMessageRemoveDelayed, + kMessageScheduleDelayedSend, + kMessageRemoveDelayedSend, }; enum MessageType : uint8_t