espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-10 04:37:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[netdata] centralize service/server TLV logic in Service::Manager (#10624)

Browse Source 
This commit updates the `NetworkData::Service::Manager` class to
provide helper methods for adding and removing different service
types (DNS/SRP anycast or unicast services, backbone router
service).

With this change, the definitions of `ServiceData` and `ServerData`
formats for different service types are now `private` to the
`Service::Manager` class. This centralizes the logic for constructing
and parsing the service/server TLVs, making it easier to update and
add new fields to these formats in the future.
This commit is contained in:
Abtin Keshavarzian
2024-08-21 19:25:10 -07:00
committed by GitHub
parent 8a0ea2b692
commit 697adfd112
10 changed files with 320 additions and 507 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_network_data.cpp
+12 -12
View File
@@ -637,7 +637,7 @@ void TestNetworkDataDsnSrpServices(void)
uint8_t mSequenceNumber;
uint16_t mRloc16;
bool Matches(Service::DnsSrpAnycast::Info aInfo) const
bool Matches(Service::DnsSrpAnycastInfo aInfo) const
{
VerifyOrQuit(aInfo.mAnycastAddress.GetIid().IsAnycastServiceLocator());
@@ -652,7 +652,7 @@ void TestNetworkDataDsnSrpServices(void)
uint16_t mPort;
uint16_t mRloc16;
bool Matches(const Service::DnsSrpUnicast::Info &aInfo) const
bool Matches(const Service::DnsSrpUnicastInfo &aInfo) const
{
Ip6::SockAddr sockAddr;
@@ -699,12 +699,12 @@ void TestNetworkDataDsnSrpServices(void)
const uint8_t kPreferredAnycastEntryIndex = 2;
Service::Manager &manager = instance->Get<Service::Manager>();
Service::Manager::Iterator iterator;
Service::DnsSrpAnycast::Info anycastInfo;
Service::DnsSrpUnicast::Info unicastInfo;
Service::DnsSrpUnicast::Type type;
Rlocs rlocs;
Service::Manager &manager = instance->Get<Service::Manager>();
Service::Manager::Iterator iterator;
Service::DnsSrpAnycastInfo anycastInfo;
Service::DnsSrpUnicastInfo unicastInfo;
Service::DnsSrpUnicastType type;
Rlocs rlocs;
reinterpret_cast<TestLeader &>(instance->Get<Leader>()).Populate(kNetworkData, sizeof(kNetworkData));
@@ -756,7 +756,7 @@ void TestNetworkDataDsnSrpServices(void)
printf("\nDNS/SRP Unicast Service entries (server data)\n");
iterator.Clear();
type = Service::DnsSrpUnicast::kFromServerData;
type = Service::kAddrInServerData;
for (const UnicastEntry &entry : kUnicastEntriesFromServerData)
{
@@ -774,7 +774,7 @@ void TestNetworkDataDsnSrpServices(void)
printf("\nDNS/SRP Unicast Service entries (service data)\n");
iterator.Clear();
type = Service::DnsSrpUnicast::kFromServiceData;
type = Service::kAddrInServiceData;
for (const UnicastEntry &entry : kUnicastEntriesFromServiceData)
{
@@ -947,8 +947,8 @@ void TestNetworkDataDsnSrpAnycastSeqNumSelection(void)
for (const TestInfo &test : kTests)
{
Service::Manager::Iterator iterator;
Service::DnsSrpAnycast::Info anycastInfo;
Service::Manager::Iterator iterator;
Service::DnsSrpAnycastInfo anycastInfo;
reinterpret_cast<TestLeader &>(instance->Get<Leader>()).Populate(test.mNetworkData, test.mNetworkDataLength);