From 6dd72ce8e99a867bd6cd77ae1a72bff546dcb649 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Mon, 24 Aug 2026 15:05:28 -0700 Subject: [PATCH] [meshcop-tlvs] fix `kRevMask` in `VendorStackVersionTlv` (#13547) This commit fixes a bug in `VendorStackVersionTlv` where `kRevMask` was incorrectly defined using `kBuildOffset` instead of `kRevOffset`, causing the Revision field bitmask to be shifted incorrectly. --- src/core/meshcop/meshcop_tlvs.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/meshcop/meshcop_tlvs.hpp b/src/core/meshcop/meshcop_tlvs.hpp index cebe8775e..62bc8ef5c 100644 --- a/src/core/meshcop/meshcop_tlvs.hpp +++ b/src/core/meshcop/meshcop_tlvs.hpp @@ -898,7 +898,7 @@ private: static constexpr uint8_t kBuildOffset = 4; static constexpr uint16_t kBuildMask = 0xfff << kBuildOffset; static constexpr uint8_t kRevOffset = 0; - static constexpr uint16_t kRevMask = 0xf << kBuildOffset; + static constexpr uint16_t kRevMask = 0xf << kRevOffset; // For `mMinorMajor` static constexpr uint8_t kMinorOffset = 4;