From 6f5c939eebb5458e33ff06c817ec6868b46fc31b Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Tue, 20 Feb 2018 17:29:50 +0000 Subject: [PATCH] [tests] fix occasional failures in Cert_5_3_05_RoutingLinkQuality.py (#2564) Updating the bidirectional link quality requires a two-way exchange via MLE Advertisements. In the worst case, this can take 2.5x the worst-case MLE Advertisement period. This commit increases the delay after updating link quality configurations. --- tests/scripts/thread-cert/Cert_5_3_05_RoutingLinkQuality.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/scripts/thread-cert/Cert_5_3_05_RoutingLinkQuality.py b/tests/scripts/thread-cert/Cert_5_3_05_RoutingLinkQuality.py index 587eb554e..ee901451b 100755 --- a/tests/scripts/thread-cert/Cert_5_3_05_RoutingLinkQuality.py +++ b/tests/scripts/thread-cert/Cert_5_3_05_RoutingLinkQuality.py @@ -104,7 +104,7 @@ class Cert_5_3_5_RoutingLinkQuality(unittest.TestCase): # 4 & 5 self.nodes[LEADER].add_whitelist(self.nodes[DUT_ROUTER1].get_addr64(), config.RSSI['LINK_QULITY_1']) self.nodes[DUT_ROUTER1].add_whitelist(self.nodes[LEADER].get_addr64(), config.RSSI['LINK_QULITY_1']) - self.simulator.go(70) + self.simulator.go(3 * config.MAX_ADVERTISEMENT_INTERVAL) # Verify the ICMPv6 Echo Request took the longer path because it cost less. self.assertTrue(self.nodes[ROUTER3].ping(leader_rloc)) @@ -114,7 +114,7 @@ class Cert_5_3_5_RoutingLinkQuality(unittest.TestCase): # 6 & 7 self.nodes[LEADER].add_whitelist(self.nodes[DUT_ROUTER1].get_addr64(), config.RSSI['LINK_QULITY_2']) self.nodes[DUT_ROUTER1].add_whitelist(self.nodes[LEADER].get_addr64(), config.RSSI['LINK_QULITY_2']) - self.simulator.go(70) + self.simulator.go(3 * config.MAX_ADVERTISEMENT_INTERVAL) # Verify the direct neighbor would be prioritized when there are two paths with the same cost. self.assertTrue(self.nodes[ROUTER3].ping(leader_rloc)) @@ -124,7 +124,7 @@ class Cert_5_3_5_RoutingLinkQuality(unittest.TestCase): # 8 & 9 self.nodes[LEADER].add_whitelist(self.nodes[DUT_ROUTER1].get_addr64(), config.RSSI['LINK_QULITY_0']) self.nodes[DUT_ROUTER1].add_whitelist(self.nodes[LEADER].get_addr64(), config.RSSI['LINK_QULITY_0']) - self.simulator.go(70) + self.simulator.go(3 * config.MAX_ADVERTISEMENT_INTERVAL) # Verify the ICMPv6 Echo Request took the longer path. leader_rloc = self.nodes[LEADER].get_ip6_address(config.ADDRESS_TYPE.RLOC)