From 7799bae4ef6cb032a28ff0557451fa7f9ae1f651 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Wed, 23 Jun 2021 18:14:56 -0700 Subject: [PATCH] [srp-server] ensure to clear `mHasRegisteredAnyService` on server stop (#6763) This commit updates `Srp::Server` to clear `mHasRegisteredAnyService` when server is stopped and all the hosts and services are deleted. This boolean flag is used to save the port number in non-volatile settings so that we can ensure to pick a different port number the next time the server starts. This change addresses an issue where the port number may not be saved and therefore not changed if the server is stopped and restarted two times in a row. --- src/core/net/srp_server.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/net/srp_server.cpp b/src/core/net/srp_server.cpp index bc9e88c95..2bfd089c3 100644 --- a/src/core/net/srp_server.cpp +++ b/src/core/net/srp_server.cpp @@ -487,6 +487,7 @@ void Server::Stop(void) otLogInfoSrp("[server] stop listening on %hu", mSocket.GetSockName().mPort); IgnoreError(mSocket.Close()); + mHasRegisteredAnyService = false; exit: return;