[dataset] add API otDatasetIsValid support (#12757)

This commit adds an API otDatasetIsValid to check whether the given
Operational Dataset contains all the required TLVs (Active Timestamp,
Channel, Channel Mask, Extended PAN ID, Mesh-Local Prefix, Network
Key, Network Name, PAN ID, PSKc, and Security Policy). This API also
checks whether there are duplicated TLVs or the TLVs are not
well-formed.
This commit is contained in:
Zhanglong Xia
2026-03-26 17:26:03 -05:00
committed by GitHub
parent f5b89b7384
commit 789ad728fd
4 changed files with 119 additions and 1 deletions
+85
View File
@@ -77,3 +77,88 @@ TEST(otDatasetSetActiveTlvs, shouldTriggerStateCallbackOnSuccess)
fakePlatform.GoInMs(10000);
}
TEST(otDatasetIsValid, shouldReturnTrueForValidActiveDataset)
{
FakePlatform fakePlatform;
otOperationalDataset dataset;
otOperationalDatasetTlvs datasetTlvs;
EXPECT_EQ(otDatasetCreateNewNetwork(FakePlatform::CurrentInstance(), &dataset), OT_ERROR_NONE);
otDatasetConvertToTlvs(&dataset, &datasetTlvs);
EXPECT_TRUE(otDatasetIsValid(&datasetTlvs, true));
}
TEST(otDatasetIsValid, shouldReturnFalseForIncompleteActiveDataset)
{
FakePlatform fakePlatform;
otOperationalDataset dataset;
otOperationalDatasetTlvs datasetTlvs;
EXPECT_EQ(otDatasetCreateNewNetwork(FakePlatform::CurrentInstance(), &dataset), OT_ERROR_NONE);
// Remove a required field, e.g., Network Key
dataset.mComponents.mIsNetworkKeyPresent = false;
otDatasetConvertToTlvs(&dataset, &datasetTlvs);
EXPECT_FALSE(otDatasetIsValid(&datasetTlvs, true));
}
TEST(otDatasetIsValid, shouldReturnFalseForDuplicatedTlvs)
{
FakePlatform fakePlatform;
otOperationalDataset dataset;
otOperationalDatasetTlvs datasetTlvs;
EXPECT_EQ(otDatasetCreateNewNetwork(FakePlatform::CurrentInstance(), &dataset), OT_ERROR_NONE);
otDatasetConvertToTlvs(&dataset, &datasetTlvs);
// Duplicate a TLV (e.g. Network Name TLV)
// TLV format: Type (1 byte), Length (1 byte), Value (n bytes)
datasetTlvs.mTlvs[datasetTlvs.mLength] = OT_MESHCOP_TLV_NETWORKNAME; // Type: Network Name
datasetTlvs.mTlvs[datasetTlvs.mLength + 1] = 1; // Length: 1
datasetTlvs.mTlvs[datasetTlvs.mLength + 2] = 'A';
datasetTlvs.mLength += 3;
EXPECT_FALSE(otDatasetIsValid(&datasetTlvs, true));
}
TEST(otDatasetIsValid, shouldReturnTrueForValidPendingDataset)
{
FakePlatform fakePlatform;
otOperationalDataset dataset;
otOperationalDatasetTlvs datasetTlvs;
EXPECT_EQ(otDatasetCreateNewNetwork(FakePlatform::CurrentInstance(), &dataset), OT_ERROR_NONE);
// Pending Dataset MUST contain Pending Timestamp and Delay Timer.
dataset.mPendingTimestamp.mSeconds = 100;
dataset.mPendingTimestamp.mTicks = 0;
dataset.mComponents.mIsPendingTimestampPresent = true;
dataset.mDelay = 30000;
dataset.mComponents.mIsDelayPresent = true;
otDatasetConvertToTlvs(&dataset, &datasetTlvs);
EXPECT_TRUE(otDatasetIsValid(&datasetTlvs, false));
}
TEST(otDatasetIsValid, shouldReturnFalseForIncompletePendingDataset)
{
FakePlatform fakePlatform;
otOperationalDataset dataset;
otOperationalDatasetTlvs datasetTlvs;
EXPECT_EQ(otDatasetCreateNewNetwork(FakePlatform::CurrentInstance(), &dataset), OT_ERROR_NONE);
// Provide Pending Timestamp but omit Delay Timer.
dataset.mPendingTimestamp.mSeconds = 100;
dataset.mPendingTimestamp.mTicks = 0;
dataset.mComponents.mIsPendingTimestampPresent = true;
otDatasetConvertToTlvs(&dataset, &datasetTlvs);
EXPECT_FALSE(otDatasetIsValid(&datasetTlvs, false));
}