From 881c7eb7847ec4c434df88b729dc192a9f379cba Mon Sep 17 00:00:00 2001 From: "Duda, Lukasz" Date: Wed, 8 Apr 2020 22:47:00 +0200 Subject: [PATCH] [border-agent] remove the OT_CHANGED_BORDER_AGENT_STATE enumeration (#4788) --- include/openthread/instance.h | 3 +-- src/core/common/notifier.cpp | 8 ++------ src/core/meshcop/border_agent.cpp | 1 - 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/include/openthread/instance.h b/include/openthread/instance.h index 7fba573cc..4f69083f6 100644 --- a/include/openthread/instance.h +++ b/include/openthread/instance.h @@ -145,12 +145,11 @@ enum OT_CHANGED_SECURITY_POLICY = 1 << 20, ///< Security Policy changed OT_CHANGED_CHANNEL_MANAGER_NEW_CHANNEL = 1 << 21, ///< Channel Manager new pending Thread channel changed OT_CHANGED_SUPPORTED_CHANNEL_MASK = 1 << 22, ///< Supported channel mask changed - OT_CHANGED_BORDER_AGENT_STATE = 1 << 23, ///< Border agent state changed + OT_CHANGED_COMMISSIONER_STATE = 1 << 23, ///< Commissioner state changed OT_CHANGED_THREAD_NETIF_STATE = 1 << 24, ///< Thread network interface state changed OT_CHANGED_THREAD_BACKBONE_ROUTER_STATE = 1 << 25, ///< Backbone Router state changed OT_CHANGED_THREAD_BACKBONE_ROUTER_LOCAL = 1 << 26, ///< Local Backbone Router configuration changed OT_CHANGED_JOINER_STATE = 1 << 27, ///< Joiner state changed - OT_CHANGED_COMMISSIONER_STATE = 1 << 28, ///< Commissioner state changed }; /** diff --git a/src/core/common/notifier.cpp b/src/core/common/notifier.cpp index 7c3a7891a..6ecb95c3c 100644 --- a/src/core/common/notifier.cpp +++ b/src/core/common/notifier.cpp @@ -308,18 +308,14 @@ const char *Notifier::FlagToString(otChangedFlags aFlag) const retval = "ChanMask"; break; - case OT_CHANGED_BORDER_AGENT_STATE: - retval = "BorderAgentState"; + case OT_CHANGED_COMMISSIONER_STATE: + retval = "CommissionerState"; break; case OT_CHANGED_THREAD_NETIF_STATE: retval = "NetifState"; break; - case OT_CHANGED_COMMISSIONER_STATE: - retval = "CommissionerState"; - break; - default: break; } diff --git a/src/core/meshcop/border_agent.cpp b/src/core/meshcop/border_agent.cpp index dfd739322..92fd57627 100644 --- a/src/core/meshcop/border_agent.cpp +++ b/src/core/meshcop/border_agent.cpp @@ -743,7 +743,6 @@ void BorderAgent::SetState(otBorderAgentState aState) if (mState != aState) { mState = aState; - Get().Signal(OT_CHANGED_BORDER_AGENT_STATE); } }