From 8c70c780c8776622d8698ab925dff7eea9ad5a1f Mon Sep 17 00:00:00 2001 From: Rongli Sun Date: Tue, 27 May 2025 08:07:29 +0800 Subject: [PATCH] [log] suppress NOTE level logs to avoid log spam in user build (#11507) --- src/core/net/ip6.cpp | 6 +++--- src/core/thread/mesh_forwarder.cpp | 8 ++++---- src/core/thread/mesh_forwarder_ftd.cpp | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/core/net/ip6.cpp b/src/core/net/ip6.cpp index c3ef672c6..54aa594a6 100644 --- a/src/core/net/ip6.cpp +++ b/src/core/net/ip6.cpp @@ -750,7 +750,7 @@ void Ip6::UpdateReassemblyList(void) { if (now - message.GetTimestamp() >= TimeMilli::SecToMsec(kReassemblyTimeout)) { - LogNote("Reassembly timeout."); + LogInfo("Reassembly timeout."); SendIcmpError(message, Icmp::Header::kTypeTimeExceeded, Icmp::Header::kCodeFragmReasTimeEx); mReassemblyList.DequeueAndFree(message); @@ -1150,7 +1150,7 @@ void Ip6::DetermineAction(const Message &aMessage, if (Get().RouteLookup(aHeader.GetSource(), aHeader.GetDestination(), rloc16) != kErrorNone) { // No route in mesh, forward to host (as a last resort). - LogNote("Failed to find valid route for: %s", aHeader.GetDestination().ToString().AsCString()); + LogInfo("Failed to find valid route for: %s", aHeader.GetDestination().ToString().AsCString()); aForwardHost = true; ExitNow(); } @@ -1275,7 +1275,7 @@ Error Ip6::HandleDatagram(OwnedPtr aMessagePtr, bool aIsReassembled) if (udpHeader.GetDestinationPort() == Tmf::kUdpPort) { - LogNote("Dropping TMF message from untrusted origin"); + LogInfo("Dropping TMF message from untrusted origin"); ExitNow(error = kErrorDrop); } } diff --git a/src/core/thread/mesh_forwarder.cpp b/src/core/thread/mesh_forwarder.cpp index 119bd2506..b4cefc8f4 100644 --- a/src/core/thread/mesh_forwarder.cpp +++ b/src/core/thread/mesh_forwarder.cpp @@ -1886,7 +1886,7 @@ void MeshForwarder::LogMessage(MessageAction aAction, #if (OPENTHREAD_CONFIG_MAX_FRAMES_IN_DIRECT_TX_QUEUE > 0) case kMessageFullQueueDrop: #endif - logLevel = kLogLevelNote; + // default kLogLevelInfo for dropped message break; } @@ -1916,7 +1916,7 @@ void MeshForwarder::LogFrame(const char *aActionText, const Mac::Frame &aFrame, { if (aError != kErrorNone) { - LogNote("%s, aError:%s, %s", aActionText, ErrorToString(aError), aFrame.ToInfoString().AsCString()); + LogInfo("%s, aError:%s, %s", aActionText, ErrorToString(aError), aFrame.ToInfoString().AsCString()); } else { @@ -1928,14 +1928,14 @@ void MeshForwarder::LogFragmentFrameDrop(Error aError, const RxInfo &aRxInfo, const Lowpan::FragmentHeader &aFragmentHeader) { - LogNote("Dropping rx frag frame, error:%s, %s, tag:%d, offset:%d, dglen:%d", ErrorToString(aError), + LogInfo("Dropping rx frag frame, error:%s, %s, tag:%d, offset:%d, dglen:%d", ErrorToString(aError), aRxInfo.ToString().AsCString(), aFragmentHeader.GetDatagramTag(), aFragmentHeader.GetDatagramOffset(), aFragmentHeader.GetDatagramSize()); } void MeshForwarder::LogLowpanHcFrameDrop(Error aError, const RxInfo &aRxInfo) { - LogNote("Dropping rx lowpan HC frame, error:%s, %s", ErrorToString(aError), aRxInfo.ToString().AsCString()); + LogInfo("Dropping rx lowpan HC frame, error:%s, %s", ErrorToString(aError), aRxInfo.ToString().AsCString()); } MeshForwarder::RxInfo::InfoString MeshForwarder::RxInfo::ToString(void) const diff --git a/src/core/thread/mesh_forwarder_ftd.cpp b/src/core/thread/mesh_forwarder_ftd.cpp index def491724..2fa63becb 100644 --- a/src/core/thread/mesh_forwarder_ftd.cpp +++ b/src/core/thread/mesh_forwarder_ftd.cpp @@ -832,7 +832,7 @@ void MeshForwarder::GetForwardFramePriority(RxInfo &aRxInfo, Message::Priority & exit: if (error != kErrorNone) { - LogNote("Failed to get forwarded frame priority, error:%s, %s", ErrorToString(error), + LogInfo("Failed to get forwarded frame priority, error:%s, %s", ErrorToString(error), aRxInfo.ToString().AsCString()); } else if (isFragment)