[test] fix python issues in tests (#4960)

tests/scripts/thread-cert/command.py

@@ -439,7 +439,7 @@ def check_child_update_request_from_child(
     address_registration=CheckType.OPTIONAL,
     tlv_request_tlv=CheckType.OPTIONAL,
     active_timestamp=CheckType.OPTIONAL,
-    CIDs=[],
+    CIDs=(),
 ):
 
     command_msg.assertMleMessageContainsTlv(mle.Mode)
@@ -545,7 +545,7 @@ def check_child_update_response(
     response=CheckType.OPTIONAL,
     link_layer_frame_counter=CheckType.OPTIONAL,
     mle_frame_counter=CheckType.OPTIONAL,
-    CIDs=[],
+    CIDs=(),
 ):
     """Verify a properly formatted Child Update Response from parent
     """
@@ -568,7 +568,7 @@ def check_child_update_response(
         _check_address_registration(command_msg, CIDs)
 
 
-def _check_address_registration(command_msg, CIDs=[]):
+def _check_address_registration(command_msg, CIDs=()):
     addresses = command_msg.assertMleMessageContainsTlv(
         mle.AddressRegistration).addresses
     for cid in CIDs:
@@ -740,7 +740,7 @@ class SinglePrefixCheck:
 
 class PrefixesCheck:
 
-    def __init__(self, prefix_cnt=0, prefix_check_list=[]):
+    def __init__(self, prefix_cnt=0, prefix_check_list=()):
         self._prefix_cnt = prefix_cnt
         self._prefix_check_list = prefix_check_list
 
@@ -761,7 +761,7 @@ class PrefixesCheck:
 
 class CommissioningDataCheck:
 
-    def __init__(self, stable=None, sub_tlv_type_list=[]):
+    def __init__(self, stable=None, sub_tlv_type_list=()):
         self._stable = stable
         self._sub_tlv_type_list = sub_tlv_type_list
 

tests/scripts/thread-cert/dtls.py

@@ -292,7 +292,7 @@ class VariableVector(ConvertibleToBytes):
         ret = bytearray([])
         while length_in_byte > 0:
             ret += bytes(length_in_byte & 0xff)
-            length_in_byte == length_in_byte >> 8
+            length_in_byte = length_in_byte >> 8
         return ret
 
     @classmethod

tests/scripts/thread-cert/message.py

@@ -371,7 +371,7 @@ class Message(object):
 
 class MessagesSet(object):
 
-    def __init__(self, messages, commissioning_messages=[]):
+    def __init__(self, messages, commissioning_messages=()):
         self._messages = messages
         self._commissioning_messages = commissioning_messages
 

tests/scripts/thread-cert/network_data.py

@@ -392,7 +392,7 @@ class CommissioningData(NetworkData):
         return self.sub_tlvs == other.sub_tlvs
 
     def __repr__(self):
-        sub_tlvs_str = ", ".format(["{}".format(tlv) for tlv in self._sub_tlvs])
+        sub_tlvs_str = ", ".join(["{}".format(tlv) for tlv in self._sub_tlvs])
         return "CommissioningData(stable={}, sub_tlvs=[{}])".format(
             self._stable, sub_tlvs_str)
 
@@ -470,18 +470,18 @@ class Service(NetworkData):
                 self.sub_tlvs == other.sub_tlvs)
 
     def __repr__(self):
-        sub_tlvs_str = ", ".format(["{}".format(tlv) for tlv in self.sub_tlvs])
+        sub_tlvs_str = ", ".join(["{}".format(tlv) for tlv in self.sub_tlvs])
         return (
-            "LowpanId(stable={}, t={}, id={}, enterprise_number={}, service_data_length={}, service_data={},",
-            "sub_tlvs=[{}])").format(
-                self.stable,
-                self.t,
-                self.id,
-                self.enterprise_number,
-                self.service_data_length,
-                self.service_data,
-                sub_tlvs_str,
-            )
+            "LowpanId(stable={}, t={}, id={}, enterprise_number={}, service_data_length={}, service_data={}, sub_tlvs=[{}])"
+        ).format(
+            self.stable,
+            self.t,
+            self.id,
+            self.enterprise_number,
+            self.service_data_length,
+            self.service_data,
+            sub_tlvs_str,
+        )
 
 
 class ServiceSubTlvsFactory(NetworkDataSubTlvsFactory):