From 980097c2efe22e24a1bb7756cf21fa7a746f5d97 Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Fri, 26 Oct 2018 13:05:28 -0700 Subject: [PATCH] [mbedtls] disable debug by default (#3217) --- .travis/script.sh | 2 ++ src/core/meshcop/dtls.cpp | 3 +++ third_party/mbedtls/mbedtls-config.h | 1 - 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.travis/script.sh b/.travis/script.sh index 4db6589bb..8f24fab36 100755 --- a/.travis/script.sh +++ b/.travis/script.sh @@ -45,6 +45,8 @@ python --version || die [ $BUILD_TARGET != scan-build ] || { ./bootstrap || die + export CPPFLAGS="-DMBEDTLS_DEBUG_C" + scan-build ./configure \ --enable-application-coap \ --enable-application-coap-secure \ diff --git a/src/core/meshcop/dtls.cpp b/src/core/meshcop/dtls.cpp index 1f6d9d3cf..0df777598 100644 --- a/src/core/meshcop/dtls.cpp +++ b/src/core/meshcop/dtls.cpp @@ -162,8 +162,11 @@ otError Dtls::Start(bool aClient, MBEDTLS_ENTROPY_SOURCE_STRONG); VerifyOrExit(rval == 0); +#ifdef MBEDTLS_DEBUG_C // mbedTLS's debug level is almost the same as OpenThread's mbedtls_debug_set_threshold(OPENTHREAD_CONFIG_LOG_LEVEL); +#endif + otPlatRadioGetIeeeEui64(&GetInstance(), eui64.m8); rval = mbedtls_ctr_drbg_seed(&mCtrDrbg, mbedtls_entropy_func, &mEntropy, eui64.m8, sizeof(eui64)); VerifyOrExit(rval == 0); diff --git a/third_party/mbedtls/mbedtls-config.h b/third_party/mbedtls/mbedtls-config.h index 071c35a97..dee9cc928 100644 --- a/third_party/mbedtls/mbedtls-config.h +++ b/third_party/mbedtls/mbedtls-config.h @@ -70,7 +70,6 @@ __inline int windows_kernel_snprintf(char * s, size_t n, const char * format, .. #define MBEDTLS_CIPHER_C #define MBEDTLS_CMAC_C #define MBEDTLS_CTR_DRBG_C -#define MBEDTLS_DEBUG_C #define MBEDTLS_ECJPAKE_C #define MBEDTLS_ECP_C #define MBEDTLS_ECP_DP_SECP256R1_ENABLED