espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-09 04:07:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[link-metrics] update the scaling of link margin and RSSI metrics (#8078)

Browse Source 
This commit updates the scaling of the link margin and RSSI metrics.
The metric values are scaled when appended in the message (in a
Report sub-TLV) or when they are read back from received message. The
stored value in `MetricsValues` are changed to be always the actual
metric value (not the scaled value). This ensures that the value are
stored in proper int type (e.g., RSSI is `int8` vs the scaled value
which is `[0,255]`). Methods are added to perform the scaling which
now rounds to closest integer ensuring the reverse scaling gives back
the original value. Unit test is added to validate the scaling
methods.
This commit is contained in:
Abtin Keshavarzian
2022-08-25 11:08:44 -07:00
committed by GitHub
parent cba1bebf1f
commit 989a56e96d
5 changed files with 159 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_link_quality.cpp
+52
View File
@@ -31,6 +31,7 @@
#include "common/array.hpp"
#include "common/code_utils.hpp"
#include "thread/link_metrics.hpp"
#include "thread/link_quality.hpp"
namespace ot {
@@ -481,6 +482,53 @@ void TestSuccessRateTracker(void)
}
}
#if OPENTHREAD_CONFIG_MLE_LINK_METRICS_INITIATOR_ENABLE || OPENTHREAD_CONFIG_MLE_LINK_METRICS_SUBJECT_ENABLE
class UnitTester
{
public:
static void TestLinkMetricsScaling(void)
{
printf("\nTestLinkMetricsScaling\n");
// Test Link Margin scaling from [0,130] -> [0, 255]
for (uint8_t linkMargin = 0; linkMargin <= 130; linkMargin++)
{
double scaled = 255.0 / 130.0 * linkMargin;
uint8_t scaledAsU8 = static_cast<uint8_t>(scaled + 0.5);
printf("\nLinkMargin : %-3u -> Scaled : %.1f (rounded:%u)", linkMargin, scaled, scaledAsU8);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleLinkMarginToRawValue(linkMargin) == scaledAsU8);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleRawValueToLinkMargin(scaledAsU8) == linkMargin);
}
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleLinkMarginToRawValue(131) == 255);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleLinkMarginToRawValue(150) == 255);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleLinkMarginToRawValue(255) == 255);
// Test RSSI scaling from [-130, 0] -> [0, 255]
for (int8_t rssi = -128; rssi <= 0; rssi++)
{
double scaled = 255.0 / 130.0 * (rssi + 130.0);
uint8_t scaledAsU8 = static_cast<uint8_t>(scaled + 0.5);
printf("\nRSSI : %-3d -> Scaled :%.1f (rounded:%u)", rssi, scaled, scaledAsU8);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleRssiToRawValue(rssi) == scaledAsU8);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleRawValueToRssi(scaledAsU8) == rssi);
}
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleRssiToRawValue(1) == 255);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleRssiToRawValue(10) == 255);
VerifyOrQuit(LinkMetrics::LinkMetrics::ScaleRssiToRawValue(127) == 255);
}
};
#endif
} // namespace ot
int main(void)
@@ -488,6 +536,10 @@ int main(void)
ot::TestRssAveraging();
ot::TestLinkQualityCalculations();
ot::TestSuccessRateTracker();
#if OPENTHREAD_CONFIG_MLE_LINK_METRICS_INITIATOR_ENABLE || OPENTHREAD_CONFIG_MLE_LINK_METRICS_SUBJECT_ENABLE
ot::UnitTester::TestLinkMetricsScaling();
#endif
printf("\nAll tests passed\n");
return 0;
}