diff --git a/src/core/api/dataset_api.cpp b/src/core/api/dataset_api.cpp index a4153d257..457c78350 100644 --- a/src/core/api/dataset_api.cpp +++ b/src/core/api/dataset_api.cpp @@ -44,63 +44,63 @@ using namespace ot; bool otDatasetIsCommissioned(otInstance *aInstance) { - return AsCoreType(aInstance).Get().IsCommissioned(); + return AsCoreType(aInstance).Get().IsCommissioned(); } otError otDatasetGetActive(otInstance *aInstance, otOperationalDataset *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Read(AsCoreType(aDataset)); + return AsCoreType(aInstance).Get().Read(AsCoreType(aDataset)); } otError otDatasetGetActiveTlvs(otInstance *aInstance, otOperationalDatasetTlvs *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Read(*aDataset); + return AsCoreType(aInstance).Get().Read(*aDataset); } otError otDatasetSetActive(otInstance *aInstance, const otOperationalDataset *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Save(AsCoreType(aDataset)); + return AsCoreType(aInstance).Get().Save(AsCoreType(aDataset)); } otError otDatasetSetActiveTlvs(otInstance *aInstance, const otOperationalDatasetTlvs *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Save(*aDataset); + return AsCoreType(aInstance).Get().Save(*aDataset); } otError otDatasetGetPending(otInstance *aInstance, otOperationalDataset *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Read(AsCoreType(aDataset)); + return AsCoreType(aInstance).Get().Read(AsCoreType(aDataset)); } otError otDatasetGetPendingTlvs(otInstance *aInstance, otOperationalDatasetTlvs *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Read(*aDataset); + return AsCoreType(aInstance).Get().Read(*aDataset); } otError otDatasetSetPending(otInstance *aInstance, const otOperationalDataset *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Save(AsCoreType(aDataset)); + return AsCoreType(aInstance).Get().Save(AsCoreType(aDataset)); } otError otDatasetSetPendingTlvs(otInstance *aInstance, const otOperationalDatasetTlvs *aDataset) { OT_ASSERT(aDataset != nullptr); - return AsCoreType(aInstance).Get().Save(*aDataset); + return AsCoreType(aInstance).Get().Save(*aDataset); } otError otDatasetSendMgmtActiveGet(otInstance * aInstance, @@ -109,8 +109,8 @@ otError otDatasetSendMgmtActiveGet(otInstance * aInstan uint8_t aLength, const otIp6Address * aAddress) { - return AsCoreType(aInstance).Get().SendGetRequest(AsCoreType(aDatasetComponents), aTlvTypes, - aLength, aAddress); + return AsCoreType(aInstance).Get().SendGetRequest(AsCoreType(aDatasetComponents), + aTlvTypes, aLength, aAddress); } otError otDatasetSendMgmtActiveSet(otInstance * aInstance, @@ -120,8 +120,8 @@ otError otDatasetSendMgmtActiveSet(otInstance * aInstance, otDatasetMgmtSetCallback aCallback, void * aContext) { - return AsCoreType(aInstance).Get().SendSetRequest(AsCoreType(aDataset), aTlvs, aLength, - aCallback, aContext); + return AsCoreType(aInstance).Get().SendSetRequest(AsCoreType(aDataset), aTlvs, + aLength, aCallback, aContext); } otError otDatasetSendMgmtPendingGet(otInstance * aInstance, @@ -130,8 +130,8 @@ otError otDatasetSendMgmtPendingGet(otInstance * aInsta uint8_t aLength, const otIp6Address * aAddress) { - return AsCoreType(aInstance).Get().SendGetRequest(AsCoreType(aDatasetComponents), - aTlvTypes, aLength, aAddress); + return AsCoreType(aInstance).Get().SendGetRequest(AsCoreType(aDatasetComponents), + aTlvTypes, aLength, aAddress); } otError otDatasetSendMgmtPendingSet(otInstance * aInstance, @@ -141,8 +141,8 @@ otError otDatasetSendMgmtPendingSet(otInstance * aInstance, otDatasetMgmtSetCallback aCallback, void * aContext) { - return AsCoreType(aInstance).Get().SendSetRequest(AsCoreType(aDataset), aTlvs, aLength, - aCallback, aContext); + return AsCoreType(aInstance).Get().SendSetRequest(AsCoreType(aDataset), aTlvs, + aLength, aCallback, aContext); } #if OPENTHREAD_FTD diff --git a/src/core/api/dataset_ftd_api.cpp b/src/core/api/dataset_ftd_api.cpp index 4c2608830..ea1792d43 100644 --- a/src/core/api/dataset_ftd_api.cpp +++ b/src/core/api/dataset_ftd_api.cpp @@ -44,7 +44,7 @@ using namespace ot; otError otDatasetCreateNewNetwork(otInstance *aInstance, otOperationalDataset *aDataset) { - return AsCoreType(aInstance).Get().CreateNewNetwork(AsCoreType(aDataset)); + return AsCoreType(aInstance).Get().CreateNewNetwork(AsCoreType(aDataset)); } uint32_t otDatasetGetDelayTimerMinimal(otInstance *aInstance) diff --git a/src/core/api/link_api.cpp b/src/core/api/link_api.cpp index a1d38be7d..e9c30a354 100644 --- a/src/core/api/link_api.cpp +++ b/src/core/api/link_api.cpp @@ -77,8 +77,8 @@ otError otLinkSetChannel(otInstance *aInstance, uint8_t aChannel) VerifyOrExit(instance.Get().IsDisabled(), error = kErrorInvalidState); SuccessOrExit(error = instance.Get().SetPanChannel(aChannel)); - instance.Get().Clear(); - instance.Get().Clear(); + instance.Get().Clear(); + instance.Get().Clear(); exit: return error; @@ -141,8 +141,8 @@ otError otLinkSetPanId(otInstance *aInstance, otPanId aPanId) VerifyOrExit(instance.Get().IsDisabled(), error = kErrorInvalidState); instance.Get().SetPanId(aPanId); - instance.Get().Clear(); - instance.Get().Clear(); + instance.Get().Clear(); + instance.Get().Clear(); exit: return error; diff --git a/src/core/api/thread_api.cpp b/src/core/api/thread_api.cpp index 7b7275720..b6ab068c3 100644 --- a/src/core/api/thread_api.cpp +++ b/src/core/api/thread_api.cpp @@ -72,8 +72,8 @@ otError otThreadSetExtendedPanId(otInstance *aInstance, const otExtendedPanId *a prefix.SetFromExtendedPanId(extPanId); instance.Get().SetMeshLocalPrefix(prefix); - instance.Get().Clear(); - instance.Get().Clear(); + instance.Get().Clear(); + instance.Get().Clear(); exit: return error; @@ -123,8 +123,8 @@ otError otThreadSetNetworkKey(otInstance *aInstance, const otNetworkKey *aKey) instance.Get().SetNetworkKey(AsCoreType(aKey)); - instance.Get().Clear(); - instance.Get().Clear(); + instance.Get().Clear(); + instance.Get().Clear(); exit: return error; @@ -141,8 +141,8 @@ otError otThreadSetNetworkKeyRef(otInstance *aInstance, otNetworkKeyRef aKeyRef) VerifyOrExit(instance.Get().IsDisabled(), error = kErrorInvalidState); instance.Get().SetNetworkKeyRef((aKeyRef)); - instance.Get().Clear(); - instance.Get().Clear(); + instance.Get().Clear(); + instance.Get().Clear(); exit: return error; @@ -171,8 +171,8 @@ otError otThreadSetMeshLocalPrefix(otInstance *aInstance, const otMeshLocalPrefi VerifyOrExit(AsCoreType(aInstance).Get().IsDisabled(), error = kErrorInvalidState); AsCoreType(aInstance).Get().SetMeshLocalPrefix(AsCoreType(aMeshLocalPrefix)); - AsCoreType(aInstance).Get().Clear(); - AsCoreType(aInstance).Get().Clear(); + AsCoreType(aInstance).Get().Clear(); + AsCoreType(aInstance).Get().Clear(); exit: return error; @@ -210,8 +210,8 @@ otError otThreadSetNetworkName(otInstance *aInstance, const char *aNetworkName) VerifyOrExit(AsCoreType(aInstance).Get().IsDisabled(), error = kErrorInvalidState); error = AsCoreType(aInstance).Get().SetNetworkName(aNetworkName); - AsCoreType(aInstance).Get().Clear(); - AsCoreType(aInstance).Get().Clear(); + AsCoreType(aInstance).Get().Clear(); + AsCoreType(aInstance).Get().Clear(); exit: return error; diff --git a/src/core/api/thread_ftd_api.cpp b/src/core/api/thread_ftd_api.cpp index 3333e858e..e8d3a4b8e 100644 --- a/src/core/api/thread_ftd_api.cpp +++ b/src/core/api/thread_ftd_api.cpp @@ -296,8 +296,8 @@ otError otThreadSetPskc(otInstance *aInstance, const otPskc *aPskc) VerifyOrExit(AsCoreType(aInstance).Get().IsDisabled(), error = kErrorInvalidState); AsCoreType(aInstance).Get().SetPskc(AsCoreType(aPskc)); - AsCoreType(aInstance).Get().Clear(); - AsCoreType(aInstance).Get().Clear(); + AsCoreType(aInstance).Get().Clear(); + AsCoreType(aInstance).Get().Clear(); exit: return error; @@ -313,8 +313,8 @@ otError otThreadSetPskcRef(otInstance *aInstance, otPskcRef aKeyRef) VerifyOrExit(instance.Get().IsDisabled(), error = kErrorInvalidState); instance.Get().SetPskcRef(aKeyRef); - instance.Get().Clear(); - instance.Get().Clear(); + instance.Get().Clear(); + instance.Get().Clear(); exit: return error; diff --git a/src/core/common/instance.hpp b/src/core/common/instance.hpp index c1bf4b1ad..386755fa4 100644 --- a/src/core/common/instance.hpp +++ b/src/core/common/instance.hpp @@ -713,12 +713,12 @@ template <> inline MeshCoP::NetworkNameManager &Instance::Get(void) return mThreadNetif.mNetworkNameManager; } -template <> inline MeshCoP::ActiveDataset &Instance::Get(void) +template <> inline MeshCoP::ActiveDatasetManager &Instance::Get(void) { return mThreadNetif.mActiveDataset; } -template <> inline MeshCoP::PendingDataset &Instance::Get(void) +template <> inline MeshCoP::PendingDatasetManager &Instance::Get(void) { return mThreadNetif.mPendingDataset; } diff --git a/src/core/meshcop/dataset_manager.cpp b/src/core/meshcop/dataset_manager.cpp index b0bf93ce4..6202b56b0 100644 --- a/src/core/meshcop/dataset_manager.cpp +++ b/src/core/meshcop/dataset_manager.cpp @@ -268,7 +268,7 @@ void DatasetManager::SendSet(void) Dataset pendingDataset; Timestamp timestamp; - IgnoreError(Get().Read(pendingDataset)); + IgnoreError(Get().Read(pendingDataset)); if ((pendingDataset.GetTimestamp(Dataset::kActive, timestamp) == kErrorNone) && (Timestamp::Compare(×tamp, mLocal.GetTimestamp()) == 0)) @@ -656,22 +656,22 @@ exit: return error; } -ActiveDataset::ActiveDataset(Instance &aInstance) - : DatasetManager(aInstance, Dataset::kActive, ActiveDataset::HandleTimer) - , mResourceGet(UriPath::kActiveGet, &ActiveDataset::HandleGet, this) +ActiveDatasetManager::ActiveDatasetManager(Instance &aInstance) + : DatasetManager(aInstance, Dataset::kActive, ActiveDatasetManager::HandleTimer) + , mResourceGet(UriPath::kActiveGet, &ActiveDatasetManager::HandleGet, this) #if OPENTHREAD_FTD - , mResourceSet(UriPath::kActiveSet, &ActiveDataset::HandleSet, this) + , mResourceSet(UriPath::kActiveSet, &ActiveDatasetManager::HandleSet, this) #endif { Get().AddResource(mResourceGet); } -bool ActiveDataset::IsPartiallyComplete(void) const +bool ActiveDatasetManager::IsPartiallyComplete(void) const { return mLocal.IsSaved() && !mTimestampValid; } -bool ActiveDataset::IsCommissioned(void) const +bool ActiveDatasetManager::IsCommissioned(void) const { Dataset::Info datasetInfo; bool isValid = false; @@ -685,7 +685,10 @@ exit: return isValid; } -Error ActiveDataset::Save(const Timestamp &aTimestamp, const Message &aMessage, uint16_t aOffset, uint8_t aLength) +Error ActiveDatasetManager::Save(const Timestamp &aTimestamp, + const Message & aMessage, + uint16_t aOffset, + uint8_t aLength) { Error error = kErrorNone; Dataset dataset; @@ -698,39 +701,39 @@ exit: return error; } -void ActiveDataset::HandleGet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) +void ActiveDatasetManager::HandleGet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) { - static_cast(aContext)->HandleGet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); + static_cast(aContext)->HandleGet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); } -void ActiveDataset::HandleGet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) const +void ActiveDatasetManager::HandleGet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) const { DatasetManager::HandleGet(aMessage, aMessageInfo); } -void ActiveDataset::HandleTimer(Timer &aTimer) +void ActiveDatasetManager::HandleTimer(Timer &aTimer) { - aTimer.Get().HandleTimer(); + aTimer.Get().HandleTimer(); } -PendingDataset::PendingDataset(Instance &aInstance) - : DatasetManager(aInstance, Dataset::kPending, PendingDataset::HandleTimer) - , mDelayTimer(aInstance, PendingDataset::HandleDelayTimer) - , mResourceGet(UriPath::kPendingGet, &PendingDataset::HandleGet, this) +PendingDatasetManager::PendingDatasetManager(Instance &aInstance) + : DatasetManager(aInstance, Dataset::kPending, PendingDatasetManager::HandleTimer) + , mDelayTimer(aInstance, PendingDatasetManager::HandleDelayTimer) + , mResourceGet(UriPath::kPendingGet, &PendingDatasetManager::HandleGet, this) #if OPENTHREAD_FTD - , mResourceSet(UriPath::kPendingSet, &PendingDataset::HandleSet, this) + , mResourceSet(UriPath::kPendingSet, &PendingDatasetManager::HandleSet, this) #endif { Get().AddResource(mResourceGet); } -void PendingDataset::Clear(void) +void PendingDatasetManager::Clear(void) { DatasetManager::Clear(); mDelayTimer.Stop(); } -void PendingDataset::ClearNetwork(void) +void PendingDatasetManager::ClearNetwork(void) { Dataset dataset; @@ -739,7 +742,7 @@ void PendingDataset::ClearNetwork(void) IgnoreError(DatasetManager::Save(dataset)); } -Error PendingDataset::Save(const Dataset::Info &aDatasetInfo) +Error PendingDatasetManager::Save(const Dataset::Info &aDatasetInfo) { Error error; @@ -750,7 +753,7 @@ exit: return error; } -Error PendingDataset::Save(const otOperationalDatasetTlvs &aDataset) +Error PendingDatasetManager::Save(const otOperationalDatasetTlvs &aDataset) { Error error; @@ -761,7 +764,7 @@ exit: return error; } -Error PendingDataset::Save(const Dataset &aDataset) +Error PendingDatasetManager::Save(const Dataset &aDataset) { Error error; @@ -772,7 +775,10 @@ exit: return error; } -Error PendingDataset::Save(const Timestamp &aTimestamp, const Message &aMessage, uint16_t aOffset, uint8_t aLength) +Error PendingDatasetManager::Save(const Timestamp &aTimestamp, + const Message & aMessage, + uint16_t aOffset, + uint8_t aLength) { Error error = kErrorNone; Dataset dataset; @@ -786,7 +792,7 @@ exit: return error; } -void PendingDataset::StartDelayTimer(void) +void PendingDatasetManager::StartDelayTimer(void) { DelayTimerTlv *delayTimer; Dataset dataset; @@ -810,12 +816,12 @@ void PendingDataset::StartDelayTimer(void) } } -void PendingDataset::HandleDelayTimer(Timer &aTimer) +void PendingDatasetManager::HandleDelayTimer(Timer &aTimer) { - aTimer.Get().HandleDelayTimer(); + aTimer.Get().HandleDelayTimer(); } -void PendingDataset::HandleDelayTimer(void) +void PendingDatasetManager::HandleDelayTimer(void) { DelayTimerTlv *delayTimer; Dataset dataset; @@ -840,7 +846,7 @@ void PendingDataset::HandleDelayTimer(void) dataset.ConvertToActive(); - Get().Save(dataset); + Get().Save(dataset); Clear(); @@ -848,19 +854,19 @@ exit: return; } -void PendingDataset::HandleGet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) +void PendingDatasetManager::HandleGet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) { - static_cast(aContext)->HandleGet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); + static_cast(aContext)->HandleGet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); } -void PendingDataset::HandleGet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) const +void PendingDatasetManager::HandleGet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) const { DatasetManager::HandleGet(aMessage, aMessageInfo); } -void PendingDataset::HandleTimer(Timer &aTimer) +void PendingDatasetManager::HandleTimer(Timer &aTimer) { - aTimer.Get().HandleTimer(); + aTimer.Get().HandleTimer(); } } // namespace MeshCoP diff --git a/src/core/meshcop/dataset_manager.hpp b/src/core/meshcop/dataset_manager.hpp index ec7c316ba..9d5487429 100644 --- a/src/core/meshcop/dataset_manager.hpp +++ b/src/core/meshcop/dataset_manager.hpp @@ -363,16 +363,16 @@ private: void * mMgmtSetCallbackContext; }; -class ActiveDataset : public DatasetManager, private NonCopyable +class ActiveDatasetManager : public DatasetManager, private NonCopyable { public: /** - * This constructor initializes the ActiveDataset object. + * This constructor initializes the ActiveDatasetManager object. * * @param[in] aInstance A reference to the OpenThread instance. * */ - explicit ActiveDataset(Instance &aInstance); + explicit ActiveDatasetManager(Instance &aInstance); /** * This method indicates whether the Active Dataset is partially complete. @@ -505,16 +505,16 @@ private: #endif }; -class PendingDataset : public DatasetManager, private NonCopyable +class PendingDatasetManager : public DatasetManager, private NonCopyable { public: /** - * This constructor initializes the PendingDataset object. + * This constructor initializes the PendingDatasetManager object. * * @param[in] aInstance A reference to the OpenThread instance. * */ - explicit PendingDataset(Instance &aInstance); + explicit PendingDatasetManager(Instance &aInstance); /** * This method clears the Pending Operational Dataset. diff --git a/src/core/meshcop/dataset_manager_ftd.cpp b/src/core/meshcop/dataset_manager_ftd.cpp index da57c5f03..916f50816 100644 --- a/src/core/meshcop/dataset_manager_ftd.cpp +++ b/src/core/meshcop/dataset_manager_ftd.cpp @@ -159,7 +159,7 @@ Error DatasetManager::HandleSet(Coap::Message &aMessage, const Ip6::MessageInfo if (GetType() == Dataset::kPending && (!hasNetworkKey || !doesAffectNetworkKey)) { // no change to network key, active timestamp must be ahead - const Timestamp *localActiveTimestamp = Get().GetTimestamp(); + const Timestamp *localActiveTimestamp = Get().GetTimestamp(); VerifyOrExit(Timestamp::Compare(&activeTimestamp, localActiveTimestamp) > 0); } @@ -184,7 +184,7 @@ Error DatasetManager::HandleSet(Coap::Message &aMessage, const Ip6::MessageInfo { // Thread specification allows partial dataset changes for MGMT_ACTIVE_SET.req/MGMT_PENDING_SET.req // from Commissioner based on existing active dataset. - IgnoreError(Get().Read(dataset)); + IgnoreError(Get().Read(dataset)); } if (GetType() == Dataset::kPending || !doesAffectConnectivity) @@ -232,7 +232,7 @@ Error DatasetManager::HandleSet(Coap::Message &aMessage, const Ip6::MessageInfo } else { - Get().ApplyActiveDataset(activeTimestamp, aMessage); + Get().ApplyActiveDataset(activeTimestamp, aMessage); } state = StateTlv::kAccept; @@ -298,7 +298,7 @@ exit: return error; } -Error ActiveDataset::GenerateLocal(void) +Error ActiveDatasetManager::GenerateLocal(void) { Error error = kErrorNone; Dataset dataset; @@ -396,23 +396,23 @@ exit: return error; } -void ActiveDataset::StartLeader(void) +void ActiveDatasetManager::StartLeader(void) { IgnoreError(GenerateLocal()); Get().AddResource(mResourceSet); } -void ActiveDataset::StopLeader(void) +void ActiveDatasetManager::StopLeader(void) { Get().RemoveResource(mResourceSet); } -void ActiveDataset::HandleSet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) +void ActiveDatasetManager::HandleSet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) { - static_cast(aContext)->HandleSet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); + static_cast(aContext)->HandleSet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); } -void ActiveDataset::HandleSet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) +void ActiveDatasetManager::HandleSet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) { SuccessOrExit(DatasetManager::HandleSet(aMessage, aMessageInfo)); IgnoreError(ApplyConfiguration()); @@ -421,23 +421,23 @@ exit: return; } -void PendingDataset::StartLeader(void) +void PendingDatasetManager::StartLeader(void) { StartDelayTimer(); Get().AddResource(mResourceSet); } -void PendingDataset::StopLeader(void) +void PendingDatasetManager::StopLeader(void) { Get().RemoveResource(mResourceSet); } -void PendingDataset::HandleSet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) +void PendingDatasetManager::HandleSet(void *aContext, otMessage *aMessage, const otMessageInfo *aMessageInfo) { - static_cast(aContext)->HandleSet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); + static_cast(aContext)->HandleSet(AsCoapMessage(aMessage), AsCoreType(aMessageInfo)); } -void PendingDataset::HandleSet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) +void PendingDatasetManager::HandleSet(Coap::Message &aMessage, const Ip6::MessageInfo &aMessageInfo) { SuccessOrExit(DatasetManager::HandleSet(aMessage, aMessageInfo)); StartDelayTimer(); @@ -446,7 +446,7 @@ exit: return; } -void PendingDataset::ApplyActiveDataset(const Timestamp &aTimestamp, Coap::Message &aMessage) +void PendingDatasetManager::ApplyActiveDataset(const Timestamp &aTimestamp, Coap::Message &aMessage) { uint16_t offset = aMessage.GetOffset(); Dataset dataset; diff --git a/src/core/meshcop/dataset_updater.cpp b/src/core/meshcop/dataset_updater.cpp index c1ca78e90..00782b227 100644 --- a/src/core/meshcop/dataset_updater.cpp +++ b/src/core/meshcop/dataset_updater.cpp @@ -113,7 +113,7 @@ void DatasetUpdater::PreparePendingDataset(void) IgnoreError(mDataset->Read(0, requestedDataset)); - error = Get().Read(dataset); + error = Get().Read(dataset); if (error != kErrorNone) { @@ -139,9 +139,9 @@ void DatasetUpdater::PreparePendingDataset(void) { Timestamp timestamp; - if (Get().GetTimestamp() != nullptr) + if (Get().GetTimestamp() != nullptr) { - timestamp = *Get().GetTimestamp(); + timestamp = *Get().GetTimestamp(); } timestamp.AdvanceRandomTicks(); @@ -154,7 +154,7 @@ void DatasetUpdater::PreparePendingDataset(void) tlv->GetTimestamp().AdvanceRandomTicks(); } - SuccessOrExit(error = Get().Save(dataset)); + SuccessOrExit(error = Get().Save(dataset)); exit: if (error != kErrorNone) @@ -187,7 +187,7 @@ void DatasetUpdater::HandleNotifierEvents(Events aEvents) IgnoreError(mDataset->Read(0, requestedDataset)); - if (aEvents.Contains(kEventActiveDatasetChanged) && Get().Read(dataset) == kErrorNone) + if (aEvents.Contains(kEventActiveDatasetChanged) && Get().Read(dataset) == kErrorNone) { if (requestedDataset.IsSubsetOf(dataset)) { @@ -199,7 +199,7 @@ void DatasetUpdater::HandleNotifierEvents(Events aEvents) } } - if (aEvents.Contains(kEventPendingDatasetChanged) && Get().Read(dataset) == kErrorNone) + if (aEvents.Contains(kEventPendingDatasetChanged) && Get().Read(dataset) == kErrorNone) { if (!requestedDataset.IsSubsetOf(dataset)) { diff --git a/src/core/meshcop/joiner.cpp b/src/core/meshcop/joiner.cpp index 33f7966ae..285916815 100644 --- a/src/core/meshcop/joiner.cpp +++ b/src/core/meshcop/joiner.cpp @@ -581,7 +581,7 @@ void Joiner::HandleJoinerEntrust(Coap::Message &aMessage, const Ip6::MessageInfo datasetInfo.SetChannel(Get().GetPanChannel()); datasetInfo.SetPanId(Get().GetPanId()); - IgnoreError(Get().Save(datasetInfo)); + IgnoreError(Get().Save(datasetInfo)); LogInfo("Joiner successful!"); diff --git a/src/core/meshcop/joiner_router.cpp b/src/core/meshcop/joiner_router.cpp index dff14114c..69715b13a 100644 --- a/src/core/meshcop/joiner_router.cpp +++ b/src/core/meshcop/joiner_router.cpp @@ -331,7 +331,7 @@ Coap::Message *JoinerRouter::PrepareJoinerEntrustMessage(void) networkName.SetNetworkName(Get().GetNetworkName().GetAsData()); SuccessOrExit(error = networkName.AppendTo(*message)); - IgnoreError(Get().Read(dataset)); + IgnoreError(Get().Read(dataset)); if ((tlv = dataset.GetTlv()) != nullptr) { diff --git a/src/core/thread/announce_sender.cpp b/src/core/thread/announce_sender.cpp index 37246f2f2..c5005761a 100644 --- a/src/core/thread/announce_sender.cpp +++ b/src/core/thread/announce_sender.cpp @@ -252,7 +252,7 @@ void AnnounceSender::HandleActiveDatasetChanged(void) { Mac::ChannelMask channelMask; - SuccessOrExit(Get().GetChannelMask(channelMask)); + SuccessOrExit(Get().GetChannelMask(channelMask)); VerifyOrExit(!channelMask.IsEmpty()); VerifyOrExit(channelMask != GetChannelMask()); diff --git a/src/core/thread/mle.cpp b/src/core/thread/mle.cpp index 418fcd4d9..396df6d16 100644 --- a/src/core/thread/mle.cpp +++ b/src/core/thread/mle.cpp @@ -244,8 +244,8 @@ void Mle::Stop(StopMode aMode) { if (aMode == kUpdateNetworkDatasets) { - Get().HandleDetach(); - Get().HandleDetach(); + Get().HandleDetach(); + Get().HandleDetach(); } VerifyOrExit(!IsDisabled()); @@ -315,8 +315,8 @@ void Mle::Restore(void) Settings::NetworkInfo networkInfo; Settings::ParentInfo parentInfo; - IgnoreError(Get().Restore()); - IgnoreError(Get().Restore()); + IgnoreError(Get().Restore()); + IgnoreError(Get().Restore()); #if OPENTHREAD_CONFIG_DUA_ENABLE Get().Restore(); @@ -481,7 +481,7 @@ Error Mle::BecomeDetached(void) // not in reattach stage after reset if (mReattachState == kReattachStop) { - Get().HandleDetach(); + Get().HandleDetach(); } #if OPENTHREAD_CONFIG_PARENT_SEARCH_ENABLE @@ -521,7 +521,7 @@ void Mle::Attach(AttachMode aMode) if (mReattachState == kReattachStart) { - if (Get().Restore() == kErrorNone) + if (Get().Restore() == kErrorNone) { mReattachState = kReattachActive; } @@ -1458,7 +1458,7 @@ Error Mle::AppendXtalAccuracy(Message &aMessage) Error Mle::AppendActiveTimestamp(Message &aMessage) { Error error = kErrorNone; - const MeshCoP::Timestamp *timestamp = Get().GetTimestamp(); + const MeshCoP::Timestamp *timestamp = Get().GetTimestamp(); VerifyOrExit(timestamp != nullptr); error = Tlv::Append(aMessage, *timestamp); @@ -1470,7 +1470,7 @@ exit: Error Mle::AppendPendingTimestamp(Message &aMessage) { Error error = kErrorNone; - const MeshCoP::Timestamp *timestamp = Get().GetTimestamp(); + const MeshCoP::Timestamp *timestamp = Get().GetTimestamp(); VerifyOrExit(timestamp != nullptr && timestamp->GetSeconds() != 0); error = Tlv::Append(aMessage, *timestamp); @@ -1910,9 +1910,9 @@ bool Mle::PrepareAnnounceState(void) Mac::ChannelMask channelMask; VerifyOrExit(!IsChild() && (mReattachState == kReattachStop) && - (Get().IsPartiallyComplete() || !IsFullThreadDevice())); + (Get().IsPartiallyComplete() || !IsFullThreadDevice())); - if (Get().GetChannelMask(channelMask) != kErrorNone) + if (Get().GetChannelMask(channelMask) != kErrorNone) { channelMask = Get().GetSupportedChannelMask(); } @@ -1936,9 +1936,9 @@ uint32_t Mle::Reattach(void) if (mReattachState == kReattachActive) { - if (Get().Restore() == kErrorNone) + if (Get().Restore() == kErrorNone) { - IgnoreError(Get().ApplyConfiguration()); + IgnoreError(Get().ApplyConfiguration()); mReattachState = kReattachPending; SetAttachState(kAttachStateStart); delay = 1 + Random::NonCrypto::GetUint32InRange(0, kAttachStartJitter); @@ -1951,7 +1951,7 @@ uint32_t Mle::Reattach(void) else if (mReattachState == kReattachPending) { mReattachState = kReattachStop; - IgnoreError(Get().Restore()); + IgnoreError(Get().Restore()); } VerifyOrExit(mReattachState == kReattachStop); @@ -2617,7 +2617,7 @@ Error Mle::GetNextAnnouceChannel(uint8_t &aChannel) const Mac::ChannelMask channelMask; - if (Get().GetChannelMask(channelMask) != kErrorNone) + if (Get().GetChannelMask(channelMask) != kErrorNone) { channelMask = Get().GetSupportedChannelMask(); } @@ -3221,7 +3221,7 @@ Error Mle::HandleLeaderData(RxInfo &aRxInfo) case kErrorNone: hasActiveTimestamp = true; - timestamp = Get().GetTimestamp(); + timestamp = Get().GetTimestamp(); // if received timestamp does not match the local value and message does not contain the dataset, // send MLE Data Request @@ -3246,7 +3246,7 @@ Error Mle::HandleLeaderData(RxInfo &aRxInfo) case kErrorNone: hasPendingTimestamp = true; - timestamp = Get().GetTimestamp(); + timestamp = Get().GetTimestamp(); // if received timestamp does not match the local value and message does not contain the dataset, // send MLE Data Request @@ -3291,8 +3291,8 @@ Error Mle::HandleLeaderData(RxInfo &aRxInfo) if (activeDatasetOffset > 0) { IgnoreError(aRxInfo.mMessage.Read(activeDatasetOffset, tlv)); - IgnoreError(Get().Save(activeTimestamp, aRxInfo.mMessage, - activeDatasetOffset + sizeof(tlv), tlv.GetLength())); + IgnoreError(Get().Save( + activeTimestamp, aRxInfo.mMessage, activeDatasetOffset + sizeof(tlv), tlv.GetLength())); } } @@ -3302,8 +3302,8 @@ Error Mle::HandleLeaderData(RxInfo &aRxInfo) if (pendingDatasetOffset > 0) { IgnoreError(aRxInfo.mMessage.Read(pendingDatasetOffset, tlv)); - IgnoreError(Get().Save(pendingTimestamp, aRxInfo.mMessage, - pendingDatasetOffset + sizeof(tlv), tlv.GetLength())); + IgnoreError(Get().Save( + pendingTimestamp, aRxInfo.mMessage, pendingDatasetOffset + sizeof(tlv), tlv.GetLength())); } } } @@ -3690,8 +3690,8 @@ void Mle::HandleChildIdResponse(RxInfo &aRxInfo) if (Tlv::FindTlvOffset(aRxInfo.mMessage, Tlv::kActiveDataset, offset) == kErrorNone) { IgnoreError(aRxInfo.mMessage.Read(offset, tlv)); - SuccessOrExit(error = Get().Save(timestamp, aRxInfo.mMessage, offset + sizeof(tlv), - tlv.GetLength())); + SuccessOrExit(error = Get().Save(timestamp, aRxInfo.mMessage, + offset + sizeof(tlv), tlv.GetLength())); } break; @@ -3705,7 +3705,7 @@ void Mle::HandleChildIdResponse(RxInfo &aRxInfo) // clear Pending Dataset if device succeed to reattach using stored Pending Dataset if (mReattachState == kReattachPending) { - Get().Clear(); + Get().Clear(); } // Pending Timestamp @@ -3716,13 +3716,13 @@ void Mle::HandleChildIdResponse(RxInfo &aRxInfo) if (Tlv::FindTlvOffset(aRxInfo.mMessage, Tlv::kPendingDataset, offset) == kErrorNone) { IgnoreError(aRxInfo.mMessage.Read(offset, tlv)); - IgnoreError(Get().Save(timestamp, aRxInfo.mMessage, offset + sizeof(tlv), - tlv.GetLength())); + IgnoreError(Get().Save(timestamp, aRxInfo.mMessage, offset + sizeof(tlv), + tlv.GetLength())); } break; case kErrorNotFound: - Get().ClearNetwork(); + Get().ClearNetwork(); break; default: @@ -4033,7 +4033,7 @@ void Mle::HandleAnnounce(RxInfo &aRxInfo) SuccessOrExit(error = Tlv::Find(aRxInfo.mMessage, timestamp)); SuccessOrExit(error = Tlv::Find(aRxInfo.mMessage, panId)); - localTimestamp = Get().GetTimestamp(); + localTimestamp = Get().GetTimestamp(); if (MeshCoP::Timestamp::Compare(×tamp, localTimestamp) > 0) { diff --git a/src/core/thread/mle_router.cpp b/src/core/thread/mle_router.cpp index 28c63dcbb..52e67a685 100644 --- a/src/core/thread/mle_router.cpp +++ b/src/core/thread/mle_router.cpp @@ -228,7 +228,7 @@ Error MleRouter::BecomeLeader(void) uint8_t maxRouterId; #endif - VerifyOrExit(!Get().IsPartiallyComplete(), error = kErrorInvalidState); + VerifyOrExit(!Get().IsPartiallyComplete(), error = kErrorInvalidState); VerifyOrExit(!IsDisabled(), error = kErrorInvalidState); VerifyOrExit(!IsLeader(), error = kErrorNone); VerifyOrExit(IsRouterEligible(), error = kErrorNotCapable); @@ -277,8 +277,8 @@ void MleRouter::StopLeader(void) { Get().RemoveResource(mAddressSolicit); Get().RemoveResource(mAddressRelease); - Get().StopLeader(); - Get().StopLeader(); + Get().StopLeader(); + Get().StopLeader(); StopAdvertiseTrickleTimer(); Get().Stop(); Get().UnsubscribeAllRoutersMulticast(); @@ -401,8 +401,8 @@ void MleRouter::SetStateRouter(uint16_t aRloc16) void MleRouter::SetStateLeader(uint16_t aRloc16) { - IgnoreError(Get().Restore()); - IgnoreError(Get().Restore()); + IgnoreError(Get().Restore()); + IgnoreError(Get().Restore()); SetRloc16(aRloc16); SetRole(kRoleLeader); @@ -420,8 +420,8 @@ void MleRouter::SetStateLeader(uint16_t aRloc16) Get().RegisterReceiver(TimeTicker::kMleRouter); Get().Start(); - Get().StartLeader(); - Get().StartLeader(); + Get().StartLeader(); + Get().StartLeader(); Get().AddResource(mAddressSolicit); Get().AddResource(mAddressRelease); Get().SetForwardingEnabled(true); @@ -2295,7 +2295,7 @@ void MleRouter::HandleChildIdRequest(RxInfo &aRxInfo) { case kErrorNone: needsActiveDatasetTlv = - (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) != 0); + (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) != 0); break; case kErrorNotFound: break; @@ -2309,7 +2309,7 @@ void MleRouter::HandleChildIdRequest(RxInfo &aRxInfo) { case kErrorNone: needsPendingDatasetTlv = - (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) != 0); + (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) != 0); break; case kErrorNotFound: break; @@ -2759,7 +2759,7 @@ void MleRouter::HandleDataRequest(RxInfo &aRxInfo) switch (Tlv::Find(aRxInfo.mMessage, timestamp)) { case kErrorNone: - if (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) == 0) + if (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) == 0) { break; } @@ -2778,7 +2778,7 @@ void MleRouter::HandleDataRequest(RxInfo &aRxInfo) switch (Tlv::Find(aRxInfo.mMessage, timestamp)) { case kErrorNone: - if (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) == 0) + if (MeshCoP::Timestamp::Compare(×tamp, Get().GetTimestamp()) == 0) { break; } @@ -4246,12 +4246,12 @@ Error MleRouter::AppendRoute(Message &aMessage, Neighbor *aNeighbor) Error MleRouter::AppendActiveDataset(Message &aMessage) { - return Get().AppendMleDatasetTlv(aMessage); + return Get().AppendMleDatasetTlv(aMessage); } Error MleRouter::AppendPendingDataset(Message &aMessage) { - return Get().AppendMleDatasetTlv(aMessage); + return Get().AppendMleDatasetTlv(aMessage); } bool MleRouter::HasMinDowngradeNeighborRouters(void) diff --git a/src/core/thread/thread_netif.hpp b/src/core/thread/thread_netif.hpp index 7d8662f3d..97efc3396 100644 --- a/src/core/thread/thread_netif.hpp +++ b/src/core/thread/thread_netif.hpp @@ -199,17 +199,17 @@ private: #if OPENTHREAD_CONFIG_SNTP_CLIENT_ENABLE Sntp::Client mSntpClient; #endif - MeshCoP::ActiveDataset mActiveDataset; - MeshCoP::PendingDataset mPendingDataset; - MeshCoP::ExtendedPanIdManager mExtendedPanIdManager; - MeshCoP::NetworkNameManager mNetworkNameManager; - Ip6::Filter mIp6Filter; - KeyManager mKeyManager; - Lowpan::Lowpan mLowpan; - Mac::Mac mMac; - MeshForwarder mMeshForwarder; - Mle::MleRouter mMleRouter; - Mle::DiscoverScanner mDiscoverScanner; + MeshCoP::ActiveDatasetManager mActiveDataset; + MeshCoP::PendingDatasetManager mPendingDataset; + MeshCoP::ExtendedPanIdManager mExtendedPanIdManager; + MeshCoP::NetworkNameManager mNetworkNameManager; + Ip6::Filter mIp6Filter; + KeyManager mKeyManager; + Lowpan::Lowpan mLowpan; + Mac::Mac mMac; + MeshForwarder mMeshForwarder; + Mle::MleRouter mMleRouter; + Mle::DiscoverScanner mDiscoverScanner; #if OPENTHREAD_CONFIG_MULTI_RADIO RadioSelector mRadioSelector; #endif