espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-14 05:00:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] use constexpr for constants in unit tests (#13145)

Browse Source 
This commit refactors various unit tests to use `constexpr` for
defining constants instead of anonymous `enum` types.

Using `constexpr` is the modern and preferred approach in C++, as it
provides explicit types for constants and improves code clarity and
type safety.
This commit is contained in:
Abtin Keshavarzian
2026-05-25 19:39:27 -07:00
committed by GitHub
parent 6847b9acdf
commit 9d95a19e52
15 changed files with 87 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_dns.cpp
+20 -31
View File
@@ -42,11 +42,8 @@ namespace ot {
void TestDnsName(void)
{
enum
{
kMaxSize = 300,
kMaxNameLength = Dns::Name::kMaxNameSize - 1,
};
static constexpr uint16_t kMaxSize = 300;
static constexpr uint16_t kMaxNameLength = Dns::Name::kMaxNameSize - 1;
struct TestName
{
@@ -635,19 +632,14 @@ void TestDnsName(void)
void TestDnsCompressedName(void)
{
enum
{
kHeaderOffset = 10,
kGuardBlockSize = 20,
kMaxBufferSize = 100,
kLabelSize = 64,
kNameSize = 256,
kName2EncodedSize = 4 + 2, // encoded "FOO" + pointer label (2 bytes)
kName3EncodedSize = 2, // pointer label (2 bytes)
kName4EncodedSize = 15 + 2, // encoded "Human.Readable" + pointer label (2 bytes).
};
static constexpr uint8_t kHeaderOffset = 10;
static constexpr uint8_t kGuardBlockSize = 20;
static constexpr uint16_t kMaxBufferSize = 100;
static constexpr uint16_t kLabelSize = 64;
static constexpr uint16_t kNameSize = 256;
static constexpr uint16_t kName2EncodedSize = 4 + 2; // encoded "FOO" + pointer label (2 bytes)
static constexpr uint16_t kName3EncodedSize = 2; // pointer label (2 bytes)
static constexpr uint16_t kName4EncodedSize = 15 + 2; // encoded "Human.Readable" + pointer label (2 bytes).
const char kName[] = "F.ISI.ARPA";
const char kLabel1[] = "FOO";
@@ -1155,19 +1147,16 @@ void TestDnsCompressedName(void)
void TestHeaderAndResourceRecords(void)
{
enum
{
kHeaderOffset = 0,
kQuestionCount = 1,
kAnswerCount = 2,
kAdditionalCount = 6,
kTtl = 7200,
kTxtTtl = 7300,
kSrvPort = 1234,
kSrvPriority = 1,
kSrvWeight = 2,
kMaxSize = 600,
};
static constexpr uint8_t kHeaderOffset = 0;
static constexpr uint16_t kQuestionCount = 1;
static constexpr uint16_t kAnswerCount = 2;
static constexpr uint16_t kAdditionalCount = 6;
static constexpr uint32_t kTtl = 7200;
static constexpr uint32_t kTxtTtl = 7300;
static constexpr uint16_t kSrvPort = 1234;
static constexpr uint16_t kSrvPriority = 1;
static constexpr uint16_t kSrvWeight = 2;
static constexpr uint16_t kMaxSize = 600;
const char kMessageString[] = "DnsMessage";
const char kDomainName[] = "example.com.";