From a0b9ac74f1b467df5722ea8613a2dcb690b93fd4 Mon Sep 17 00:00:00 2001
From: Jonathan Hui <jonhui@google.com>
Date: Thu, 18 Jan 2024 15:22:25 -0800
Subject: [PATCH] [github-actions] remove use of geekyeggo/delete-artifact
 (#9785)

Simply set retention to 1 day for coverage artifacts.
---
 .github/workflows/otbr.yml           | 15 ++++-----------
 .github/workflows/otns.yml           |  2 ++
 .github/workflows/posix.yml          | 20 ++++----------------
 .github/workflows/simulation-1.1.yml | 23 +++++++----------------
 .github/workflows/simulation-1.2.yml | 21 +++++----------------
 .github/workflows/toranj.yml         | 17 +----------------
 .github/workflows/unit.yml           | 18 +-----------------
 7 files changed, 24 insertions(+), 92 deletions(-)

diff --git a/.github/workflows/otbr.yml b/.github/workflows/otbr.yml
index ae4202c31..d964cddd9 100644
--- a/.github/workflows/otbr.yml
+++ b/.github/workflows/otbr.yml
@@ -90,6 +90,7 @@ jobs:
       with:
         name: cov-thread-1-3-backbone-docker
         path: /tmp/coverage/
+        retention-days: 1
     - uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
       if: ${{ failure() }}
       with:
@@ -107,6 +108,7 @@ jobs:
       with:
         name: cov-thread-1-3-backbone
         path: tmp/coverage.info
+        retention-days: 1
 
   thread-border-router:
     runs-on: ubuntu-20.04
@@ -210,6 +212,7 @@ jobs:
       with:
         name: cov-br-docker-${{ matrix.description }}-${{ matrix.otbr_mdns }}-${{matrix.otbr_trel}}
         path: /tmp/coverage/
+        retention-days: 1
     - uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
       if: ${{ failure() }}
       with:
@@ -227,6 +230,7 @@ jobs:
       with:
         name: cov-br-${{ matrix.description }}-${{ matrix.otbr_mdns }}-${{matrix.otbr_trel}}
         path: tmp/coverage.info
+        retention-days: 1
 
   upload-coverage:
     needs:
@@ -255,14 +259,3 @@ jobs:
       with:
         files: final.info
         fail_ci_if_error: true
-
-  delete-coverage-artifacts:
-    needs: upload-coverage
-    runs-on: ubuntu-20.04
-    permissions:
-      actions: write
-    steps:
-    - uses: geekyeggo/delete-artifact@65041433121f7239077fa20be14c0690f70569de # v4.1.0
-      with:
-        name: cov-*
-        useGlob: true
diff --git a/.github/workflows/otns.yml b/.github/workflows/otns.yml
index 207d10098..d21f7ad56 100644
--- a/.github/workflows/otns.yml
+++ b/.github/workflows/otns.yml
@@ -96,6 +96,7 @@ jobs:
       with:
         name: cov-otns-unittests
         path: tmp/coverage.info
+        retention-days: 1
 
   examples:
     name: Examples
@@ -197,6 +198,7 @@ jobs:
         with:
           name: cov-otns-stress-tests-${{ matrix.suite }}
           path: tmp/coverage.info
+          retention-days: 1
 
   upload-coverage:
     needs:
diff --git a/.github/workflows/posix.yml b/.github/workflows/posix.yml
index 775b8636a..efdb085f8 100644
--- a/.github/workflows/posix.yml
+++ b/.github/workflows/posix.yml
@@ -88,6 +88,7 @@ jobs:
       with:
         name: cov-expects-linux-1
         path: tmp/coverage.info
+        retention-days: 1
     - name: Run TUN Mode
       run: |
         sudo rm /etc/apt/sources.list.d/* && sudo apt-get update
@@ -125,6 +126,7 @@ jobs:
       with:
         name: cov-expects-linux-2
         path: tmp/coverage.info
+        retention-days: 1
 
   thread-cert:
     runs-on: ubuntu-20.04
@@ -215,6 +217,7 @@ jobs:
       with:
         name: cov-pty-linux-${{ matrix.DAEMON }}
         path: tmp/coverage.info
+        retention-days: 1
 
   pty-macos:
     name: pty-macos OT_DAEMON=${{ matrix.OT_DAEMON }}
@@ -282,6 +285,7 @@ jobs:
       with:
         name: cov-rcp-stack-reset
         path: tmp/coverage.info
+        retention-days: 1
 
   upload-coverage:
     needs:
@@ -314,19 +318,3 @@ jobs:
       with:
         files: final.info
         fail_ci_if_error: true
-
-  delete-coverage-artifacts:
-    needs: upload-coverage
-    runs-on: ubuntu-20.04
-    permissions:
-      actions: write
-    steps:
-    - name: Harden Runner
-      uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
-      with:
-        egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs
-
-    - uses: geekyeggo/delete-artifact@65041433121f7239077fa20be14c0690f70569de # v4.1.0
-      with:
-        name: cov-*
-        useGlob: true
diff --git a/.github/workflows/simulation-1.1.yml b/.github/workflows/simulation-1.1.yml
index 0a3308c2b..eedc18ca6 100644
--- a/.github/workflows/simulation-1.1.yml
+++ b/.github/workflows/simulation-1.1.yml
@@ -90,6 +90,7 @@ jobs:
       with:
         name: cov-packet-verification
         path: tmp/coverage.info
+        retention-days: 1
 
   cli-ftd:
     runs-on: ubuntu-20.04
@@ -133,6 +134,7 @@ jobs:
       with:
         name: cov-cli-ftd
         path: tmp/coverage.info
+        retention-days: 1
 
   cli-mtd:
     name: cli-mtd MESSAGE_USE_HEAP=${{ matrix.message_use_heap }}
@@ -183,6 +185,7 @@ jobs:
       with:
         name: cov-cli-mtd-${{ matrix.message_use_heap }}
         path: tmp/coverage.info
+        retention-days: 1
 
   cli-time-sync:
     runs-on: ubuntu-20.04
@@ -226,6 +229,7 @@ jobs:
       with:
         name: cov-cli-time-sync
         path: tmp/coverage.info
+        retention-days: 1
 
   expects:
     runs-on: ubuntu-20.04
@@ -267,6 +271,7 @@ jobs:
       with:
         name: cov-expects
         path: tmp/coverage.info
+        retention-days: 1
 
   ot-commissioner:
     runs-on: ubuntu-22.04
@@ -316,6 +321,7 @@ jobs:
       with:
         name: cov-ot-commissioner
         path: tmp/coverage.info
+        retention-days: 1
 
   multiple-instance:
     runs-on: ubuntu-20.04
@@ -355,6 +361,7 @@ jobs:
       with:
         name: cov-multiple-instance
         path: tmp/coverage.info
+        retention-days: 1
 
   upload-coverage:
     needs:
@@ -391,19 +398,3 @@ jobs:
       with:
         files: final.info
         fail_ci_if_error: true
-
-  delete-coverage-artifacts:
-    needs: upload-coverage
-    runs-on: ubuntu-20.04
-    permissions:
-      actions: write
-    steps:
-    - name: Harden Runner
-      uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
-      with:
-        egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs
-
-    - uses: geekyeggo/delete-artifact@65041433121f7239077fa20be14c0690f70569de # v4.1.0
-      with:
-        name: cov-*
-        useGlob: true
diff --git a/.github/workflows/simulation-1.2.yml b/.github/workflows/simulation-1.2.yml
index e3cd040d2..7e94ff8d4 100644
--- a/.github/workflows/simulation-1.2.yml
+++ b/.github/workflows/simulation-1.2.yml
@@ -113,6 +113,7 @@ jobs:
       with:
         name: cov-thread-1-3-${{ matrix.compiler.c }}-${{ matrix.arch }}
         path: tmp/coverage.info
+        retention-days: 1
 
   packet-verification-low-power:
     runs-on: ubuntu-20.04
@@ -185,6 +186,7 @@ jobs:
       with:
         name: cov-packet-verification-low-power
         path: tmp/coverage.info
+        retention-days: 1
 
   packet-verification-1-1-on-1-3:
     runs-on: ubuntu-20.04
@@ -232,6 +234,7 @@ jobs:
       with:
         name: cov-packet-verification-1-1-on-1-3
         path: tmp/coverage.info
+        retention-days: 1
 
   expects:
     runs-on: ubuntu-20.04
@@ -275,6 +278,7 @@ jobs:
       with:
         name: cov-expects
         path: tmp/coverage.info
+        retention-days: 1
 
   thread-1-3-posix:
     runs-on: ubuntu-20.04
@@ -338,6 +342,7 @@ jobs:
       with:
         name: cov-thread-1-3-posix
         path: tmp/coverage.info
+        retention-days: 1
 
   upload-coverage:
     needs:
@@ -372,19 +377,3 @@ jobs:
       with:
         files: final.info
         fail_ci_if_error: true
-
-  delete-coverage-artifacts:
-    needs: upload-coverage
-    runs-on: ubuntu-20.04
-    permissions:
-      actions: write
-    steps:
-    - name: Harden Runner
-      uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
-      with:
-        egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs
-
-    - uses: geekyeggo/delete-artifact@65041433121f7239077fa20be14c0690f70569de # v4.1.0
-      with:
-        name: cov-*
-        useGlob: true
diff --git a/.github/workflows/toranj.yml b/.github/workflows/toranj.yml
index 62af5b7ea..bb69395da 100644
--- a/.github/workflows/toranj.yml
+++ b/.github/workflows/toranj.yml
@@ -116,6 +116,7 @@ jobs:
       with:
         name: cov-toranj-cli-${{ matrix.TORANJ_RADIO }}
         path: tmp/coverage.info
+        retention-days: 1
 
   toranj-unittest:
     name: toranj-unittest
@@ -187,19 +188,3 @@ jobs:
       with:
         files: final.info
         fail_ci_if_error: true
-
-  delete-coverage-artifacts:
-    needs: upload-coverage
-    runs-on: ubuntu-20.04
-    permissions:
-      actions: write
-    steps:
-    - name: Harden Runner
-      uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
-      with:
-        egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs
-
-    - uses: geekyeggo/delete-artifact@65041433121f7239077fa20be14c0690f70569de # v4.1.0
-      with:
-        name: cov-*
-        useGlob: true
diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml
index 93d0bbf4b..70293674f 100644
--- a/.github/workflows/unit.yml
+++ b/.github/workflows/unit.yml
@@ -97,7 +97,7 @@ jobs:
       with:
         name: cov-unit-tests
         path: tmp/coverage.info
-
+        retention-days: 1
 
   upload-coverage:
     needs: unit-tests
@@ -127,19 +127,3 @@ jobs:
       with:
         files: final.info
         fail_ci_if_error: true
-
-  delete-coverage-artifacts:
-    needs: upload-coverage
-    runs-on: ubuntu-20.04
-    permissions:
-      actions: write
-    steps:
-    - name: Harden Runner
-      uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
-      with:
-        egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs
-
-    - uses: geekyeggo/delete-artifact@65041433121f7239077fa20be14c0690f70569de # v4.1.0
-      with:
-        name: cov-*
-        useGlob: true