From a0ff14c47542cd1ec46d04aa8afbcf97f7c8c493 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Wed, 15 Feb 2023 22:34:43 -0800 Subject: [PATCH] [test] update `test_srp_server` to clear the service instances (#8768) This commit updates `PrepareService()` functions to `memset` the `Service` instance to zero before populating its fields. This ensures that all new properties (e.g., recently added `mLease`/`mKeyLease`) are set to zero and use the corresponding default value. --- tests/unit/test_srp_server.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit/test_srp_server.cpp b/tests/unit/test_srp_server.cpp index 0209a8a9e..90ff6e63c 100644 --- a/tests/unit/test_srp_server.cpp +++ b/tests/unit/test_srp_server.cpp @@ -296,6 +296,7 @@ void PrepareService1(Srp::Client::Service &aService) {kTxtKey3, kTxtValue3, sizeof(kTxtValue3)}, }; + memset(&aService, 0, sizeof(aService)); aService.mName = kServiceName; aService.mInstanceName = kInstanceLabel; aService.mSubTypeLabels = kSubLabels; @@ -313,6 +314,7 @@ void PrepareService2(Srp::Client::Service &aService) static const char kSub4[] = "_44444444"; static const char *kSubLabels2[] = {kSub4, nullptr}; + memset(&aService, 0, sizeof(aService)); aService.mName = kService2Name; aService.mInstanceName = kInstance2Label; aService.mSubTypeLabels = kSubLabels2;