From aa1b2927c8898f46583b427ee3293133dd2e7f2c Mon Sep 17 00:00:00 2001
From: Yakun Xu <xyk@google.com>
Date: Thu, 14 May 2020 09:10:14 +0800
Subject: [PATCH] [diag] check RCP diag commands (#4955)

---
 src/core/diags/factory_diags.cpp        | 14 ++++++
 tests/scripts/expect/posix-diag-rcp.exp | 58 +++++++++++++++++++++++++
 2 files changed, 72 insertions(+)
 create mode 100755 tests/scripts/expect/posix-diag-rcp.exp

diff --git a/src/core/diags/factory_diags.cpp b/src/core/diags/factory_diags.cpp
index 463d6ee7a..43cb7f020 100644
--- a/src/core/diags/factory_diags.cpp
+++ b/src/core/diags/factory_diags.cpp
@@ -557,11 +557,25 @@ otError Diags::ProcessCmd(uint8_t aArgsLength, char *aArgs[], char *aOutput, siz
 {
     otError error = OT_ERROR_NONE;
 
+    // This `rcp` command is for debugging and testing only, building only when NDEBUG is not defined
+    // so that it will be excluded from release build.
+#if !defined(NDEBUG) && defined(OPENTHREAD_RADIO)
+    if (aArgsLength > 0 && !strcmp(aArgs[0], "rcp"))
+    {
+        aArgs++;
+        aArgsLength--;
+    }
+#endif
+
     if (aArgsLength == 0)
     {
         snprintf(aOutput, aOutputMaxLen, "diagnostics mode is %s\r\n", otPlatDiagModeGet() ? "enabled" : "disabled");
         ExitNow();
     }
+    else
+    {
+        aOutput[0] = '\0';
+    }
 
     for (size_t i = 0; i < OT_ARRAY_LENGTH(sCommands); i++)
     {
diff --git a/tests/scripts/expect/posix-diag-rcp.exp b/tests/scripts/expect/posix-diag-rcp.exp
new file mode 100755
index 000000000..5cd68346f
--- /dev/null
+++ b/tests/scripts/expect/posix-diag-rcp.exp
@@ -0,0 +1,58 @@
+#!/usr/bin/expect -f
+#
+#  Copyright (c) 2020, The OpenThread Authors.
+#  All rights reserved.
+#
+#  Redistribution and use in source and binary forms, with or without
+#  modification, are permitted provided that the following conditions are met:
+#  1. Redistributions of source code must retain the above copyright
+#     notice, this list of conditions and the following disclaimer.
+#  2. Redistributions in binary form must reproduce the above copyright
+#     notice, this list of conditions and the following disclaimer in the
+#     documentation and/or other materials provided with the distribution.
+#  3. Neither the name of the copyright holder nor the
+#     names of its contributors may be used to endorse or promote products
+#     derived from this software without specific prior written permission.
+#
+#  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+#  AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+#  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+#  ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+#  LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+#  CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+#  SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+#  INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+#  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+#  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+#  POSSIBILITY OF SUCH DAMAGE.
+#
+
+spawn $env(OT_COMMAND) $env(RCP_COMMAND) 1
+set timeout 1
+expect_after {
+    timeout { exit 1 }
+}
+send "diag rcp\n"
+expect "diagnostics mode is disabled"
+expect "Done"
+send "diag start\n"
+expect "start diagnostics mode"
+expect "status 0x00"
+expect "Done"
+send "diag rcp\n"
+expect "diagnostics mode is enabled"
+expect "Done"
+send "diag rcp channel\n"
+expect "failed"
+expect "status 0x7"
+expect "Done"
+send "diag rcp channel 11\n"
+expect "Done"
+send "diag rcp power\n"
+expect "failed"
+expect "status 0x7"
+expect "Done"
+send "diag rcp power 10\n"
+expect "Done"
+send "\x04"
+expect eof