From aaaae937d3819f696d2c0ad860e037ea75de9ff0 Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Tue, 19 Mar 2019 21:17:33 -0700 Subject: [PATCH] [style] prefer OT_UNUSED_VARIABLE (#3696) --- examples/apps/cli/main.c | 2 +- examples/apps/ncp/main.c | 2 +- examples/platforms/nrf52811/alarm.c | 8 +- examples/platforms/nrf52811/diag.c | 9 +- examples/platforms/nrf52811/radio.c | 51 +++++---- tests/fuzz/fuzzer_platform.c | 170 ++++++++++++++-------------- tests/unit/test_platform.cpp | 81 ++++++------- 7 files changed, 163 insertions(+), 160 deletions(-) diff --git a/examples/apps/cli/main.c b/examples/apps/cli/main.c index 31f97357a..f9ad5d9f6 100644 --- a/examples/apps/cli/main.c +++ b/examples/apps/cli/main.c @@ -60,7 +60,7 @@ void otPlatFree(void *aPtr) void otTaskletsSignalPending(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } int main(int argc, char *argv[]) diff --git a/examples/apps/ncp/main.c b/examples/apps/ncp/main.c index 3a8dcbd92..c51d4a0f7 100644 --- a/examples/apps/ncp/main.c +++ b/examples/apps/ncp/main.c @@ -59,7 +59,7 @@ void otPlatFree(void *aPtr) void otTaskletsSignalPending(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } int main(int argc, char *argv[]) diff --git a/examples/platforms/nrf52811/alarm.c b/examples/platforms/nrf52811/alarm.c index 9c13e0fbb..0920f5d4a 100644 --- a/examples/platforms/nrf52811/alarm.c +++ b/examples/platforms/nrf52811/alarm.c @@ -530,14 +530,14 @@ uint32_t otPlatAlarmMilliGetNow(void) void otPlatAlarmMilliStartAt(otInstance *aInstance, uint32_t aT0, uint32_t aDt) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); AlarmStartAt(aT0, aDt, kMsTimer); } void otPlatAlarmMilliStop(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); AlarmStop(kMsTimer); } @@ -549,14 +549,14 @@ uint32_t otPlatAlarmMicroGetNow(void) void otPlatAlarmMicroStartAt(otInstance *aInstance, uint32_t aT0, uint32_t aDt) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); AlarmStartAt(aT0, aDt, kUsTimer); } void otPlatAlarmMicroStop(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); AlarmStop(kUsTimer); } diff --git a/examples/platforms/nrf52811/diag.c b/examples/platforms/nrf52811/diag.c index bcf55bbeb..232f160a3 100644 --- a/examples/platforms/nrf52811/diag.c +++ b/examples/platforms/nrf52811/diag.c @@ -113,7 +113,8 @@ static bool startCarrierTransmision(void) static void processListen(otInstance *aInstance, int argc, char *argv[], char *aOutput, size_t aOutputMaxLen) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); + otError error = OT_ERROR_NONE; otEXPECT_ACTION(otPlatDiagModeGet(), error = OT_ERROR_INVALID_STATE); @@ -139,7 +140,7 @@ exit: static void processID(otInstance *aInstance, int argc, char *argv[], char *aOutput, size_t aOutputMaxLen) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); otError error = OT_ERROR_NONE; @@ -336,7 +337,7 @@ exit: static void processCcaThreshold(otInstance *aInstance, int argc, char *argv[], char *aOutput, size_t aOutputMaxLen) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); otError error = OT_ERROR_NONE; nrf_802154_cca_cfg_t ccaConfig; @@ -429,7 +430,7 @@ void otPlatDiagTxPowerSet(int8_t aTxPower) void otPlatDiagRadioReceived(otInstance *aInstance, otRadioFrame *aFrame, otError aError) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); if (sListen && (aError == OT_ERROR_NONE)) { diff --git a/examples/platforms/nrf52811/radio.c b/examples/platforms/nrf52811/radio.c index 96ae0c563..6f6e0395b 100644 --- a/examples/platforms/nrf52811/radio.c +++ b/examples/platforms/nrf52811/radio.c @@ -180,7 +180,7 @@ static inline void clearPendingEvents(void) #if !OPENTHREAD_CONFIG_ENABLE_PLATFORM_EUI64_CUSTOM_SOURCE void otPlatRadioGetIeeeEui64(otInstance *aInstance, uint8_t *aIeeeEui64) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); uint64_t factoryAddress = (uint64_t)NRF_FICR->DEVICEID[0] << 32; factoryAddress |= NRF_FICR->DEVICEID[1]; @@ -191,7 +191,7 @@ void otPlatRadioGetIeeeEui64(otInstance *aInstance, uint8_t *aIeeeEui64) void otPlatRadioSetPanId(otInstance *aInstance, uint16_t aPanId) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); uint8_t address[SHORT_ADDRESS_SIZE]; convertShortAddress(address, aPanId); @@ -201,14 +201,14 @@ void otPlatRadioSetPanId(otInstance *aInstance, uint16_t aPanId) void otPlatRadioSetExtendedAddress(otInstance *aInstance, const otExtAddress *aExtAddress) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); nrf_802154_extended_address_set(aExtAddress->m8); } void otPlatRadioSetShortAddress(otInstance *aInstance, uint16_t aShortAddress) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); uint8_t address[SHORT_ADDRESS_SIZE]; convertShortAddress(address, aShortAddress); @@ -231,7 +231,7 @@ void nrf5RadioDeinit(void) otRadioState otPlatRadioGetState(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); if (sDisabled) { @@ -278,7 +278,7 @@ otError otPlatRadioEnable(otInstance *aInstance) otError otPlatRadioDisable(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); otError error; @@ -297,14 +297,14 @@ otError otPlatRadioDisable(otInstance *aInstance) bool otPlatRadioIsEnabled(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return !sDisabled; } otError otPlatRadioSleep(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); if (nrf_802154_sleep()) { @@ -321,7 +321,7 @@ otError otPlatRadioSleep(otInstance *aInstance) otError otPlatRadioReceive(otInstance *aInstance, uint8_t aChannel) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); bool result; @@ -365,49 +365,49 @@ otError otPlatRadioTransmit(otInstance *aInstance, otRadioFrame *aFrame) otRadioFrame *otPlatRadioGetTransmitBuffer(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return &sTransmitFrame; } int8_t otPlatRadioGetRssi(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return nrf_802154_rssi_last_get(); } otRadioCaps otPlatRadioGetCaps(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return (otRadioCaps)(OT_RADIO_CAPS_ENERGY_SCAN | OT_RADIO_CAPS_ACK_TIMEOUT | OT_RADIO_CAPS_CSMA_BACKOFF); } bool otPlatRadioGetPromiscuous(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return nrf_802154_promiscuous_get(); } void otPlatRadioSetPromiscuous(otInstance *aInstance, bool aEnable) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); nrf_802154_promiscuous_set(aEnable); } void otPlatRadioEnableSrcMatch(otInstance *aInstance, bool aEnable) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); nrf_802154_auto_pending_bit_set(aEnable); } otError otPlatRadioAddSrcMatchShortEntry(otInstance *aInstance, const uint16_t aShortAddress) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); otError error; @@ -428,7 +428,7 @@ otError otPlatRadioAddSrcMatchShortEntry(otInstance *aInstance, const uint16_t a otError otPlatRadioAddSrcMatchExtEntry(otInstance *aInstance, const otExtAddress *aExtAddress) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); otError error; @@ -446,7 +446,7 @@ otError otPlatRadioAddSrcMatchExtEntry(otInstance *aInstance, const otExtAddress otError otPlatRadioClearSrcMatchShortEntry(otInstance *aInstance, const uint16_t aShortAddress) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); otError error; @@ -467,7 +467,7 @@ otError otPlatRadioClearSrcMatchShortEntry(otInstance *aInstance, const uint16_t otError otPlatRadioClearSrcMatchExtEntry(otInstance *aInstance, const otExtAddress *aExtAddress) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); otError error; @@ -485,21 +485,21 @@ otError otPlatRadioClearSrcMatchExtEntry(otInstance *aInstance, const otExtAddre void otPlatRadioClearSrcMatchShortEntries(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); nrf_802154_pending_bit_for_addr_reset(false); } void otPlatRadioClearSrcMatchExtEntries(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); nrf_802154_pending_bit_for_addr_reset(true); } otError otPlatRadioEnergyScan(otInstance *aInstance, uint8_t aScanChannel, uint16_t aScanDuration) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); sEnergyDetectionTime = (uint32_t)aScanDuration * 1000UL; sEnergyDetectionChannel = aScanChannel; @@ -522,8 +522,9 @@ otError otPlatRadioEnergyScan(otInstance *aInstance, uint8_t aScanChannel, uint1 otError otPlatRadioGetTransmitPower(otInstance *aInstance, int8_t *aPower) { + OT_UNUSED_VARIABLE(aInstance); + otError error = OT_ERROR_NONE; - (void)aInstance; if (aPower == NULL) { @@ -539,7 +540,7 @@ otError otPlatRadioGetTransmitPower(otInstance *aInstance, int8_t *aPower) otError otPlatRadioSetTransmitPower(otInstance *aInstance, int8_t aPower) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); sDefaultTxPower = aPower; nrf_802154_tx_power_set(aPower); @@ -802,7 +803,7 @@ void nrf_802154_energy_detected(uint8_t result) int8_t otPlatRadioGetReceiveSensitivity(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return NRF52811_RECEIVE_SENSITIVITY; } diff --git a/tests/fuzz/fuzzer_platform.c b/tests/fuzz/fuzzer_platform.c index a1e643523..d0a405d3a 100644 --- a/tests/fuzz/fuzzer_platform.c +++ b/tests/fuzz/fuzzer_platform.c @@ -53,14 +53,14 @@ uint32_t otPlatAlarmMilliGetNow(void) void otPlatAlarmMilliStartAt(otInstance *aInstance, uint32_t aT0, uint32_t aDt) { - (void)aInstance; - (void)aT0; - (void)aDt; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aT0); + OT_UNUSED_VARIABLE(aDt); } void otPlatAlarmMilliStop(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } uint32_t otPlatAlarmMicroGetNow(void) @@ -70,14 +70,14 @@ uint32_t otPlatAlarmMicroGetNow(void) void otPlatAlarmMicroStartAt(otInstance *aInstance, uint32_t aT0, uint32_t aDt) { - (void)aInstance; - (void)aT0; - (void)aDt; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aT0); + OT_UNUSED_VARIABLE(aDt); } void otPlatAlarmMicroStop(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } bool otDiagIsEnabled(void) @@ -87,35 +87,35 @@ bool otDiagIsEnabled(void) void otDiagProcessCmd(int aArgCount, char *aArgVector[], char *aOutput, size_t aOutputMaxLen) { - (void)aArgCount; - (void)aArgVector; - (void)aOutput; - (void)aOutputMaxLen; + OT_UNUSED_VARIABLE(aArgCount); + OT_UNUSED_VARIABLE(aArgVector); + OT_UNUSED_VARIABLE(aOutput); + OT_UNUSED_VARIABLE(aOutputMaxLen); } void otDiagProcessCmdLine(const char *aString, char *aOutput, size_t aOutputMaxLen) { - (void)aString; - (void)aOutput; - (void)aOutputMaxLen; + OT_UNUSED_VARIABLE(aString); + OT_UNUSED_VARIABLE(aOutput); + OT_UNUSED_VARIABLE(aOutputMaxLen); } void otPlatReset(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } otPlatResetReason otPlatGetResetReason(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_PLAT_RESET_REASON_POWER_ON; } void otPlatLog(otLogLevel aLogLevel, otLogRegion aLogRegion, const char *aFormat, ...) { - (void)aLogLevel; - (void)aLogRegion; - (void)aFormat; + OT_UNUSED_VARIABLE(aLogLevel); + OT_UNUSED_VARIABLE(aLogRegion); + OT_UNUSED_VARIABLE(aFormat); } void otPlatWakeHost(void) @@ -124,165 +124,165 @@ void otPlatWakeHost(void) void otPlatRadioGetIeeeEui64(otInstance *aInstance, uint8_t *aIeeeEui64) { - (void)aInstance; - (void)aIeeeEui64; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aIeeeEui64); } void otPlatRadioSetPanId(otInstance *aInstance, uint16_t aPanId) { - (void)aInstance; - (void)aPanId; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aPanId); } void otPlatRadioSetExtendedAddress(otInstance *aInstance, const otExtAddress *aExtAddr) { - (void)aInstance; - (void)aExtAddr; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aExtAddr); } void otPlatRadioSetShortAddress(otInstance *aInstance, uint16_t aShortAddr) { - (void)aInstance; - (void)aShortAddr; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aShortAddr); } void otPlatRadioSetPromiscuous(otInstance *aInstance, bool aEnabled) { - (void)aInstance; - (void)aEnabled; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aEnabled); } bool otPlatRadioIsEnabled(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return true; } otError otPlatRadioEnable(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatRadioDisable(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatRadioSleep(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatRadioReceive(otInstance *aInstance, uint8_t aChannel) { - (void)aInstance; - (void)aChannel; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aChannel); return OT_ERROR_NONE; } otError otPlatRadioTransmit(otInstance *aInstance, otRadioFrame *aFrame) { - (void)aInstance; - (void)aFrame; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aFrame); return OT_ERROR_NONE; } otError otPlatRadioGetTransmitPower(otInstance *aInstance, int8_t *aPower) { - (void)aInstance; - (void)aPower; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aPower); return OT_ERROR_NONE; } otRadioFrame *otPlatRadioGetTransmitBuffer(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return &sRadioTransmitFrame; } int8_t otPlatRadioGetRssi(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return 0; } otRadioCaps otPlatRadioGetCaps(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_RADIO_CAPS_NONE; } bool otPlatRadioGetPromiscuous(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return false; } void otPlatRadioEnableSrcMatch(otInstance *aInstance, bool aEnable) { - (void)aInstance; - (void)aEnable; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aEnable); } otError otPlatRadioAddSrcMatchShortEntry(otInstance *aInstance, const uint16_t aShortAddress) { - (void)aInstance; - (void)aShortAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aShortAddress); return OT_ERROR_NONE; } otError otPlatRadioAddSrcMatchExtEntry(otInstance *aInstance, const otExtAddress *aExtAddress) { - (void)aInstance; - (void)aExtAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aExtAddress); return OT_ERROR_NONE; } otError otPlatRadioClearSrcMatchShortEntry(otInstance *aInstance, const uint16_t aShortAddress) { - (void)aInstance; - (void)aShortAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aShortAddress); return OT_ERROR_NONE; } otError otPlatRadioClearSrcMatchExtEntry(otInstance *aInstance, const otExtAddress *aExtAddress) { - (void)aInstance; - (void)aExtAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aExtAddress); return OT_ERROR_NONE; } void otPlatRadioClearSrcMatchShortEntries(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } void otPlatRadioClearSrcMatchExtEntries(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } otError otPlatRadioEnergyScan(otInstance *aInstance, uint8_t aScanChannel, uint16_t aScanDuration) { - (void)aInstance; - (void)aScanChannel; - (void)aScanDuration; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aScanChannel); + OT_UNUSED_VARIABLE(aScanDuration); return OT_ERROR_NOT_IMPLEMENTED; } otError otPlatRadioSetTransmitPower(otInstance *aInstance, int8_t aPower) { - (void)aInstance; - (void)aPower; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aPower); return OT_ERROR_NOT_IMPLEMENTED; } int8_t otPlatRadioGetReceiveSensitivity(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return 0; } @@ -320,66 +320,66 @@ otError otPlatRandomGetTrue(uint8_t *aOutput, uint16_t aOutputLength) void otPlatSettingsInit(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } otError otPlatSettingsBeginChange(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatSettingsCommitChange(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatSettingsAbandonChange(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatSettingsGet(otInstance *aInstance, uint16_t aKey, int aIndex, uint8_t *aValue, uint16_t *aValueLength) { - (void)aInstance; - (void)aKey; - (void)aIndex; - (void)aValue; - (void)aValueLength; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aIndex); + OT_UNUSED_VARIABLE(aValue); + OT_UNUSED_VARIABLE(aValueLength); return OT_ERROR_NOT_FOUND; } otError otPlatSettingsSet(otInstance *aInstance, uint16_t aKey, const uint8_t *aValue, uint16_t aValueLength) { - (void)aInstance; - (void)aKey; - (void)aValue; - (void)aValueLength; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aValue); + OT_UNUSED_VARIABLE(aValueLength); return OT_ERROR_NONE; } otError otPlatSettingsAdd(otInstance *aInstance, uint16_t aKey, const uint8_t *aValue, uint16_t aValueLength) { - (void)aInstance; - (void)aKey; - (void)aValue; - (void)aValueLength; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aValue); + OT_UNUSED_VARIABLE(aValueLength); return OT_ERROR_NONE; } otError otPlatSettingsDelete(otInstance *aInstance, uint16_t aKey, int aIndex) { - (void)aInstance; - (void)aKey; - (void)aIndex; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aIndex); return OT_ERROR_NONE; } void otPlatSettingsWipe(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } otError otPlatUartEnable(void) @@ -394,7 +394,7 @@ otError otPlatUartDisable(void) otError otPlatUartSend(const uint8_t *aBuf, uint16_t aBufLength) { - (void)aBuf; - (void)aBufLength; + OT_UNUSED_VARIABLE(aBuf); + OT_UNUSED_VARIABLE(aBufLength); return OT_ERROR_NONE; } diff --git a/tests/unit/test_platform.cpp b/tests/unit/test_platform.cpp index 9c2273034..08095de5f 100644 --- a/tests/unit/test_platform.cpp +++ b/tests/unit/test_platform.cpp @@ -304,7 +304,7 @@ otError otPlatRadioReceive(otInstance *aInstance, uint8_t aChannel) otError otPlatRadioTransmit(otInstance *aInstance, otRadioFrame *aFrame) { - (void)aFrame; + OT_UNUSED_VARIABLE(aFrame); if (g_testPlatRadioTransmit) { @@ -345,46 +345,46 @@ bool otPlatRadioGetPromiscuous(otInstance *) void otPlatRadioEnableSrcMatch(otInstance *aInstance, bool aEnable) { - (void)aInstance; - (void)aEnable; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aEnable); } otError otPlatRadioAddSrcMatchShortEntry(otInstance *aInstance, const uint16_t aShortAddress) { - (void)aInstance; - (void)aShortAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aShortAddress); return OT_ERROR_NONE; } otError otPlatRadioAddSrcMatchExtEntry(otInstance *aInstance, const otExtAddress *aExtAddress) { - (void)aInstance; - (void)aExtAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aExtAddress); return OT_ERROR_NONE; } otError otPlatRadioClearSrcMatchShortEntry(otInstance *aInstance, const uint16_t aShortAddress) { - (void)aInstance; - (void)aShortAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aShortAddress); return OT_ERROR_NONE; } otError otPlatRadioClearSrcMatchExtEntry(otInstance *aInstance, const otExtAddress *aExtAddress) { - (void)aInstance; - (void)aExtAddress; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aExtAddress); return OT_ERROR_NONE; } void otPlatRadioClearSrcMatchShortEntries(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } void otPlatRadioClearSrcMatchExtEntries(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } otError otPlatRadioEnergyScan(otInstance *, uint8_t, uint16_t) @@ -394,14 +394,14 @@ otError otPlatRadioEnergyScan(otInstance *, uint8_t, uint16_t) otError otPlatRadioSetTransmitPower(otInstance *aInstance, int8_t aPower) { - (void)aInstance; - (void)aPower; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aPower); return OT_ERROR_NOT_IMPLEMENTED; } int8_t otPlatRadioGetReceiveSensitivity(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return 0; } // @@ -438,9 +438,10 @@ exit: void otPlatDiagProcess(int argc, char *argv[], char *aOutput) { + OT_UNUSED_VARIABLE(argc); + // no more diagnostics features for Posix platform sprintf(aOutput, "diag feature '%s' is not supported\r\n", argv[0]); - (void)argc; } void otPlatDiagModeSet(bool aMode) @@ -483,12 +484,12 @@ void otPlatUartReceived(const uint8_t *, uint16_t) void otPlatReset(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } otPlatResetReason otPlatGetResetReason(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_PLAT_RESET_REASON_POWER_ON; } @@ -502,73 +503,73 @@ void otPlatLog(otLogLevel, otLogRegion, const char *, ...) void otPlatSettingsInit(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } otError otPlatSettingsBeginChange(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatSettingsCommitChange(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatSettingsAbandonChange(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); return OT_ERROR_NONE; } otError otPlatSettingsGet(otInstance *aInstance, uint16_t aKey, int aIndex, uint8_t *aValue, uint16_t *aValueLength) { - (void)aInstance; - (void)aKey; - (void)aIndex; - (void)aValue; - (void)aValueLength; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aIndex); + OT_UNUSED_VARIABLE(aValue); + OT_UNUSED_VARIABLE(aValueLength); return OT_ERROR_NOT_FOUND; } otError otPlatSettingsSet(otInstance *aInstance, uint16_t aKey, const uint8_t *aValue, uint16_t aValueLength) { - (void)aInstance; - (void)aKey; - (void)aValue; - (void)aValueLength; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aValue); + OT_UNUSED_VARIABLE(aValueLength); return OT_ERROR_NONE; } otError otPlatSettingsAdd(otInstance *aInstance, uint16_t aKey, const uint8_t *aValue, uint16_t aValueLength) { - (void)aInstance; - (void)aKey; - (void)aValue; - (void)aValueLength; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aValue); + OT_UNUSED_VARIABLE(aValueLength); return OT_ERROR_NONE; } otError otPlatSettingsDelete(otInstance *aInstance, uint16_t aKey, int aIndex) { - (void)aInstance; - (void)aKey; - (void)aIndex; + OT_UNUSED_VARIABLE(aInstance); + OT_UNUSED_VARIABLE(aKey); + OT_UNUSED_VARIABLE(aIndex); return OT_ERROR_NONE; } void otPlatSettingsWipe(otInstance *aInstance) { - (void)aInstance; + OT_UNUSED_VARIABLE(aInstance); } #if OPENTHREAD_CONFIG_ENABLE_TIME_SYNC