From abcf3ba152cd226e73e3d60217687b62613de98b Mon Sep 17 00:00:00 2001
From: Marek Porwisz <59468987+MarekPorwisz@users.noreply.github.com>
Date: Tue, 25 May 2021 02:22:07 +0200
Subject: [PATCH] [static-analysis] address static code analysis issues (#6651)

We have run the static code analyser on the OpenThread code and some
issues were discovered.
This commit addresses those that were marked as High impact and were not
marked false positive after the inspection.

Signed-off-by: Marek Porwisz <marek.porwisz@nordicsemi.no>
---
 src/core/mac/data_poll_handler.cpp | 9 +++++++--
 src/ncp/ncp_base_mtd.cpp           | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/core/mac/data_poll_handler.cpp b/src/core/mac/data_poll_handler.cpp
index 9e4e1b53f..f4d61eac8 100644
--- a/src/core/mac/data_poll_handler.cpp
+++ b/src/core/mac/data_poll_handler.cpp
@@ -272,12 +272,17 @@ void DataPollHandler::HandleSentFrame(const Mac::TxFrame &aFrame, Error aError,
             {
                 uint32_t frameCounter;
                 uint8_t  keyId;
+                Error    error;
 
-                IgnoreError(aFrame.GetFrameCounter(frameCounter));
+                error = aFrame.GetFrameCounter(frameCounter);
+                OT_ASSERT(error == kErrorNone);
                 aChild.SetIndirectFrameCounter(frameCounter);
 
-                IgnoreError(aFrame.GetKeyId(keyId));
+                error = aFrame.GetKeyId(keyId);
+                OT_ASSERT(error == kErrorNone);
                 aChild.SetIndirectKeyId(keyId);
+
+                OT_UNUSED_VARIABLE(error);
             }
 
             ExitNow();
diff --git a/src/ncp/ncp_base_mtd.cpp b/src/ncp/ncp_base_mtd.cpp
index 3793c8bf6..59312cfff 100644
--- a/src/ncp/ncp_base_mtd.cpp
+++ b/src/ncp/ncp_base_mtd.cpp
@@ -911,7 +911,7 @@ template <> otError NcpBase::HandlePropertySet<SPINEL_PROP_THREAD_ASSISTING_PORT
     {
         uint16_t port;
 
-        IgnoreError(mDecoder.ReadUint16(port));
+        SuccessOrExit(error = mDecoder.ReadUint16(port));
         SuccessOrExit(error = otIp6AddUnsecurePort(mInstance, port));
     }