espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-10-02 13:57:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

[clang-tidy] readability-static-accessed-through-instance (#5771)

Browse Source
This commit is contained in:
Jonathan Hui
2020-11-05 10:18:11 -08:00
committed by GitHub
parent d5ee7ddbd4
commit c35ccd83bb
4 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
script/make-pretty
+1
View File
@@ -126,6 +126,7 @@ modernize-use-nullptr,\
readability-avoid-const-params-in-decls,\ readability-avoid-const-params-in-decls,\
readability-make-member-function-const,\ readability-make-member-function-const,\
readability-simplify-boolean-expr,\ readability-simplify-boolean-expr,\
readability-static-accessed-through-instance,\
" "
#performance-for-range-copy\ #performance-for-range-copy\
src/core/mac/mac.cpp
+3 -3
View File
@@ -577,7 +577,7 @@ void Mac::RequestCslFrameTransmission(uint32_t aDelay)
{ {
VerifyOrExit(mEnabled); VerifyOrExit(mEnabled);
mCslTxFireTime = mTimer.GetNow() + aDelay; mCslTxFireTime = TimerMilli::GetNow() + aDelay;
StartOperation(kOperationTransmitDataCsl); StartOperation(kOperationTransmitDataCsl);
@@ -785,7 +785,7 @@ void Mac::PerformNextOperation(void)
mOperation = kOperationWaitingForData; mOperation = kOperationWaitingForData;
} }
#if OPENTHREAD_CONFIG_MAC_CSL_TRANSMITTER_ENABLE #if OPENTHREAD_CONFIG_MAC_CSL_TRANSMITTER_ENABLE
else if (mPendingTransmitDataCsl && mTimer.GetNow() >= mCslTxFireTime) else if (mPendingTransmitDataCsl && TimerMilli::GetNow() >= mCslTxFireTime)
{ {
mPendingTransmitDataCsl = false; mPendingTransmitDataCsl = false;
mOperation = kOperationTransmitDataCsl; mOperation = kOperationTransmitDataCsl;
@@ -2456,7 +2456,7 @@ void Mac::UpdateFrameControlField(const Neighbor *aNeighbor, bool aIsTimeSync, u
else else
#endif #endif
#if OPENTHREAD_CONFIG_MAC_CSL_TRANSMITTER_ENABLE #if OPENTHREAD_CONFIG_MAC_CSL_TRANSMITTER_ENABLE
if (aNeighbor != nullptr && !Get<Mle::MleRouter>().IsActiveRouter(aNeighbor->GetRloc16()) && if (aNeighbor != nullptr && !Mle::MleRouter::IsActiveRouter(aNeighbor->GetRloc16()) &&
static_cast<const Child *>(aNeighbor)->IsCslSynchronized()) static_cast<const Child *>(aNeighbor)->IsCslSynchronized())
{ {
aFcf |= Frame::kFcfFrameVersion2015; aFcf |= Frame::kFcfFrameVersion2015;
src/core/mac/sub_mac.cpp
+1 -1
View File
@@ -940,7 +940,7 @@ void SubMac::SetCslPeriod(uint16_t aPeriod)
if (mCslPeriod > 0) if (mCslPeriod > 0)
{ {
mCslSampleTime = mCslTimer.GetNow(); mCslSampleTime = TimerMicro::GetNow();
Get<Radio>().UpdateCslSampleTime(mCslSampleTime.GetValue()); Get<Radio>().UpdateCslSampleTime(mCslSampleTime.GetValue());
mCslState = kCslSample; mCslState = kCslSample;
src/core/thread/mesh_forwarder_ftd.cpp
+2 -2
View File
@@ -905,7 +905,7 @@ otError MeshForwarder::GetDestinationRlocByServiceAloc(uint16_t aServiceAloc, ui
// Path cost // Path cost
curCost = Get<Mle::MleRouter>().GetCost(server16); curCost = Get<Mle::MleRouter>().GetCost(server16);
if (!Get<Mle::MleRouter>().IsActiveRouter(server16)) if (!Mle::MleRouter::IsActiveRouter(server16))
{ {
// Assume best link between remote child server and its parent. // Assume best link between remote child server and its parent.
curCost += 1; curCost += 1;
@@ -918,7 +918,7 @@ otError MeshForwarder::GetDestinationRlocByServiceAloc(uint16_t aServiceAloc, ui
{ {
uint8_t cost; uint8_t cost;
if (!Get<Mle::MleRouter>().IsActiveRouter(server16)) if (!Mle::MleRouter::IsActiveRouter(server16))
{ {
// Cost calculated only from Link Quality In as the parent only maintains // Cost calculated only from Link Quality In as the parent only maintains
// one-direction link info. // one-direction link info.