From c83f924a3d044226699a3241ce8d4fe6a7abaa02 Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Tue, 24 Feb 2026 13:11:40 -0800 Subject: [PATCH] [bbr] update `Manager::SendBackboneAnswer()` to use `InitAsPost()` (#12537) This commit updates `Manager::SendBackboneAnswer()` to use `Coap::Message::InitAsPost()`, which automatically determines the CoAP message type (Confirmable vs. Non-Confirmable) based on whether the destination address is multicast. This simplifies the code and removes the need for the local `proactive` boolean variable. --- src/core/backbone_router/bbr_manager.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/core/backbone_router/bbr_manager.cpp b/src/core/backbone_router/bbr_manager.cpp index 66311fc79..3e439031b 100644 --- a/src/core/backbone_router/bbr_manager.cpp +++ b/src/core/backbone_router/bbr_manager.cpp @@ -631,12 +631,10 @@ Error Manager::SendBackboneAnswer(const Ip6::Address &aDstAddr, Error error = kErrorNone; Coap::Message *message = nullptr; Ip6::MessageInfo messageInfo; - bool proactive = aDstAddr.IsMulticast(); VerifyOrExit((message = mBackboneTmfAgent.NewPriorityMessage()) != nullptr, error = kErrorNoBufs); - SuccessOrExit(error = message->Init(proactive ? Coap::kTypeNonConfirmable : Coap::kTypeConfirmable, Coap::kCodePost, - kUriBackboneAnswer)); + SuccessOrExit(error = message->InitAsPost(aDstAddr, kUriBackboneAnswer)); SuccessOrExit(error = message->AppendPayloadMarker()); SuccessOrExit(error = Tlv::Append(*message, aDua)); @@ -662,8 +660,8 @@ Error Manager::SendBackboneAnswer(const Ip6::Address &aDstAddr, error = mBackboneTmfAgent.SendMessage(*message, messageInfo); exit: - LogInfo("Send %s for %s (rloc16=%04x): %s", proactive ? "PRO_BB.ntf" : "BB.ans", aDua.ToString().AsCString(), - aSrcRloc16, ErrorToString(error)); + LogInfo("Send %s for %s (rloc16=%04x): %s", aDstAddr.IsMulticast() ? "PRO_BB.ntf" : "BB.ans", + aDua.ToString().AsCString(), aSrcRloc16, ErrorToString(error)); FreeMessageOnError(message, error); return error;