From c91820f78995b40bfc27f5cdabf0b00eff1038b2 Mon Sep 17 00:00:00 2001 From: Jonathan Hui Date: Tue, 27 Oct 2020 19:42:58 -0700 Subject: [PATCH] [clang-tidy] modernize-use-equals-delete (#5718) --- script/make-pretty | 1 + src/core/common/non_copyable.hpp | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/script/make-pretty b/script/make-pretty index b824f5a23..8c4f30bde 100755 --- a/script/make-pretty +++ b/script/make-pretty @@ -117,6 +117,7 @@ readonly OT_CLANG_TIDY_BUILD_OPTS=( readonly OT_CLANG_TIDY_CHECKS="\ -*,\ modernize-use-bool-literals,\ +modernize-use-equals-delete,\ modernize-use-nullptr,\ readability-make-member-function-const,\ readability-simplify-boolean-expr,\ diff --git a/src/core/common/non_copyable.hpp b/src/core/common/non_copyable.hpp index fa7f15420..1791e1926 100644 --- a/src/core/common/non_copyable.hpp +++ b/src/core/common/non_copyable.hpp @@ -42,12 +42,12 @@ namespace ot { */ class NonCopyable { +public: + NonCopyable(const NonCopyable &) = delete; + NonCopyable &operator=(const NonCopyable &) = delete; + protected: NonCopyable(void) {} - -private: - NonCopyable(const NonCopyable &); - NonCopyable &operator=(const NonCopyable &); }; } // namespace ot